[INFO] crate taxo 0.1.0 is already in cache [INFO] extracting crate taxo 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/taxo/0.1.0 [INFO] extracting crate taxo 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/taxo/0.1.0 [INFO] validating manifest of taxo-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of taxo-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing taxo-0.1.0 [INFO] finished frobbing taxo-0.1.0 [INFO] frobbed toml for taxo-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/taxo/0.1.0/Cargo.toml [INFO] started frobbing taxo-0.1.0 [INFO] finished frobbing taxo-0.1.0 [INFO] frobbed toml for taxo-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/taxo/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting taxo-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/taxo/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 699af3c1792d7ff96930ad1bd1bd6d04e2377aed833953c7797d2beb2ced02e8 [INFO] running `"docker" "start" "-a" "699af3c1792d7ff96930ad1bd1bd6d04e2377aed833953c7797d2beb2ced02e8"` [INFO] [stderr] Checking taxo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rules.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(Rules { rules_list: rules_list }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rules_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:45:7 [INFO] [stderr] | [INFO] [stderr] 45 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/regex.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rules.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(Rules { rules_list: rules_list }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rules_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:45:7 [INFO] [stderr] | [INFO] [stderr] 45 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/regex.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/taxo/rules.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Err(e) => return Err(format!("io error while reading file {}", e.description())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("io error while reading file {}", e.description()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/taxo/rules.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Err(e) => return Err(format!("io error while reading file {}", e.description())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("io error while reading file {}", e.description()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rules.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rules.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/taxo/rule/glob.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match opts_opt { [INFO] [stderr] 28 | | Some(optstr) => { [INFO] [stderr] 29 | | for ch in optstr.chars() { [INFO] [stderr] 30 | | match ch { [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => {} [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(optstr) = opts_opt { [INFO] [stderr] 28 | for ch in optstr.chars() { [INFO] [stderr] 29 | match ch { [INFO] [stderr] 30 | 'h' | 'd' => opts.require_literal_leading_dot = false, [INFO] [stderr] 31 | 's' => opts.require_literal_separator = false, [INFO] [stderr] 32 | 'S' => opts.require_literal_separator = true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rule/mod.rs:13:36 [INFO] [stderr] | [INFO] [stderr] 13 | Some(ch) => line.split(ch).map(|s| String::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | ('r', None) => RegexRule::new(String::from(rule), None, value).map(|rr| rr as Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | RegexRule::new(String::from(value), Some(rule), last).map(|rr| rr as Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rules.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rules.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/taxo/rule/glob.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match opts_opt { [INFO] [stderr] 28 | | Some(optstr) => { [INFO] [stderr] 29 | | for ch in optstr.chars() { [INFO] [stderr] 30 | | match ch { [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => {} [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(optstr) = opts_opt { [INFO] [stderr] 28 | for ch in optstr.chars() { [INFO] [stderr] 29 | match ch { [INFO] [stderr] 30 | 'h' | 'd' => opts.require_literal_leading_dot = false, [INFO] [stderr] 31 | 's' => opts.require_literal_separator = false, [INFO] [stderr] 32 | 'S' => opts.require_literal_separator = true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rule/mod.rs:13:36 [INFO] [stderr] | [INFO] [stderr] 13 | Some(ch) => line.split(ch).map(|s| String::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | ('r', None) => RegexRule::new(String::from(rule), None, value).map(|rr| rr as Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | RegexRule::new(String::from(value), Some(rule), last).map(|rr| rr as Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rules.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(Rules { rules_list: rules_list }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rules_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:45:7 [INFO] [stderr] | [INFO] [stderr] 45 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/regex.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rules.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(Rules { rules_list: rules_list }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rules_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:45:7 [INFO] [stderr] | [INFO] [stderr] 45 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/glob.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/taxo/rule/regex.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/taxo/rules.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Err(e) => return Err(format!("io error while reading file {}", e.description())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("io error while reading file {}", e.description()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rules.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rules.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/taxo/rule/glob.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match opts_opt { [INFO] [stderr] 28 | | Some(optstr) => { [INFO] [stderr] 29 | | for ch in optstr.chars() { [INFO] [stderr] 30 | | match ch { [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => {} [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(optstr) = opts_opt { [INFO] [stderr] 28 | for ch in optstr.chars() { [INFO] [stderr] 29 | match ch { [INFO] [stderr] 30 | 'h' | 'd' => opts.require_literal_leading_dot = false, [INFO] [stderr] 31 | 's' => opts.require_literal_separator = false, [INFO] [stderr] 32 | 'S' => opts.require_literal_separator = true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rule/mod.rs:13:36 [INFO] [stderr] | [INFO] [stderr] 13 | Some(ch) => line.split(ch).map(|s| String::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | ('r', None) => RegexRule::new(String::from(rule), None, value).map(|rr| rr as Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | RegexRule::new(String::from(value), Some(rule), last).map(|rr| rr as Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/taxo/rules.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Err(e) => return Err(format!("io error while reading file {}", e.description())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("io error while reading file {}", e.description()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rules.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rules.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(l) => if l != "" { rule::parse(String::from(l)).map(|r| Some(r)) } else { Ok(None) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/taxo/rule/glob.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match opts_opt { [INFO] [stderr] 28 | | Some(optstr) => { [INFO] [stderr] 29 | | for ch in optstr.chars() { [INFO] [stderr] 30 | | match ch { [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => {} [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(optstr) = opts_opt { [INFO] [stderr] 28 | for ch in optstr.chars() { [INFO] [stderr] 29 | match ch { [INFO] [stderr] 30 | 'h' | 'd' => opts.require_literal_leading_dot = false, [INFO] [stderr] 31 | 's' => opts.require_literal_separator = false, [INFO] [stderr] 32 | 'S' => opts.require_literal_separator = true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/taxo/rule/mod.rs:13:36 [INFO] [stderr] | [INFO] [stderr] 13 | Some(ch) => line.split(ch).map(|s| String::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | ('r', None) => RegexRule::new(String::from(rule), None, value).map(|rr| rr as Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/taxo/rule/mod.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | RegexRule::new(String::from(value), Some(rule), last).map(|rr| rr as Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.03s [INFO] running `"docker" "inspect" "699af3c1792d7ff96930ad1bd1bd6d04e2377aed833953c7797d2beb2ced02e8"` [INFO] running `"docker" "rm" "-f" "699af3c1792d7ff96930ad1bd1bd6d04e2377aed833953c7797d2beb2ced02e8"` [INFO] [stdout] 699af3c1792d7ff96930ad1bd1bd6d04e2377aed833953c7797d2beb2ced02e8