[INFO] crate taskforge 0.1.0 is already in cache [INFO] extracting crate taskforge 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/taskforge/0.1.0 [INFO] extracting crate taskforge 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/taskforge/0.1.0 [INFO] validating manifest of taskforge-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of taskforge-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing taskforge-0.1.0 [INFO] finished frobbing taskforge-0.1.0 [INFO] frobbed toml for taskforge-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/taskforge/0.1.0/Cargo.toml [INFO] started frobbing taskforge-0.1.0 [INFO] finished frobbing taskforge-0.1.0 [INFO] frobbed toml for taskforge-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/taskforge/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting taskforge-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/taskforge/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbd1ce24c2d32fd3234823307ad4fb4f0749d0785ab34df349a5e495affd99e3 [INFO] running `"docker" "start" "-a" "fbd1ce24c2d32fd3234823307ad4fb4f0749d0785ab34df349a5e495affd99e3"` [INFO] [stderr] Compiling libsqlite3-sys v0.10.0 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking bson v0.13.0 [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking taskforge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/task.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match self.completed_date { [INFO] [stderr] 106 | | Some(_) => true, [INFO] [stderr] 107 | | None => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `self.completed_date.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/list/sqlite.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | / match fs::create_dir(TEST_DIR) { [INFO] [stderr] 397 | | Ok(_) => (), [INFO] [stderr] 398 | | Err(_) => (), [INFO] [stderr] 399 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = fs::create_dir(TEST_DIR) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/task.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match self.completed_date { [INFO] [stderr] 106 | | Some(_) => true, [INFO] [stderr] 107 | | None => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `self.completed_date.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/task.rs:209:31 [INFO] [stderr] | [INFO] [stderr] 209 | assert!(task.title == "Some title".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Some title"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/task.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(task.priority, priority); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/task.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(task.priority, priority); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/task.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | priority = priority - 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `priority -= 1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `taskforge`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fbd1ce24c2d32fd3234823307ad4fb4f0749d0785ab34df349a5e495affd99e3"` [INFO] running `"docker" "rm" "-f" "fbd1ce24c2d32fd3234823307ad4fb4f0749d0785ab34df349a5e495affd99e3"` [INFO] [stdout] fbd1ce24c2d32fd3234823307ad4fb4f0749d0785ab34df349a5e495affd99e3