[INFO] crate target_build_utils 0.3.1 is already in cache [INFO] extracting crate target_build_utils 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/target_build_utils/0.3.1 [INFO] extracting crate target_build_utils 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/target_build_utils/0.3.1 [INFO] validating manifest of target_build_utils-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of target_build_utils-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing target_build_utils-0.3.1 [INFO] finished frobbing target_build_utils-0.3.1 [INFO] frobbed toml for target_build_utils-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/target_build_utils/0.3.1/Cargo.toml [INFO] started frobbing target_build_utils-0.3.1 [INFO] finished frobbing target_build_utils-0.3.1 [INFO] frobbed toml for target_build_utils-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/target_build_utils/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting target_build_utils-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/target_build_utils/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43c9a0561cb86e7267f18fe5b8c0550c505cd4f1b63a0a1c2ed2c9584e48b40b [INFO] running `"docker" "start" "-a" "43c9a0561cb86e7267f18fe5b8c0550c505cd4f1b63a0a1c2ed2c9584e48b40b"` [INFO] [stderr] Compiling target_build_utils v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/target_build_utils-eddba517733164c6/out/builtins.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/target_build_utils-eddba517733164c6/out/builtins.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 148 | | #[cfg(feature = "serde_json")] [INFO] [stderr] 149 | | fn load_json(path: &Path) -> Result { [INFO] [stderr] 150 | | use std::fs::File; [INFO] [stderr] ... | [INFO] [stderr] 194 | | Err(Error::TargetNotFound) [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:152:51 [INFO] [stderr] | [INFO] [stderr] 152 | let f = try!(File::open(path).map_err(|e| Error::Io(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | let target_path = env::var_os("RUST_TARGET_PATH") [INFO] [stderr] | ___________________________^ [INFO] [stderr] 187 | | .unwrap_or(OsString::new()); [INFO] [stderr] | |_________________________________________________________^ help: try this: `env::var_os("RUST_TARGET_PATH").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 148 | | #[cfg(feature = "serde_json")] [INFO] [stderr] 149 | | fn load_json(path: &Path) -> Result { [INFO] [stderr] 150 | | use std::fs::File; [INFO] [stderr] ... | [INFO] [stderr] 194 | | Err(Error::TargetNotFound) [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:152:51 [INFO] [stderr] | [INFO] [stderr] 152 | let f = try!(File::open(path).map_err(|e| Error::Io(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | let target_path = env::var_os("RUST_TARGET_PATH") [INFO] [stderr] | ___________________________^ [INFO] [stderr] 187 | | .unwrap_or(OsString::new()); [INFO] [stderr] | |_________________________________________________________^ help: try this: `env::var_os("RUST_TARGET_PATH").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 153 [INFO] [stderr] --> src/lib.rs:292:5 [INFO] [stderr] | [INFO] [stderr] 292 | / fn correct_archs() { [INFO] [stderr] 293 | | macro_rules! check_arch { [INFO] [stderr] 294 | | ($expected: expr, $bit: expr, $end: expr, $($str: expr),+) => { [INFO] [stderr] 295 | | $( [INFO] [stderr] ... | [INFO] [stderr] 350 | | , "powerpc64le-unknown-linux-gnu"); [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 124 [INFO] [stderr] --> src/lib.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | / fn correct_vendors() { [INFO] [stderr] 355 | | macro_rules! check_vnd { [INFO] [stderr] 356 | | ($expected: expr, $($str: expr),+) => { [INFO] [stderr] 357 | | $( [INFO] [stderr] ... | [INFO] [stderr] 406 | | check_vnd!("sun", "x86_64-sun-solaris"); [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 83 [INFO] [stderr] --> src/lib.rs:410:5 [INFO] [stderr] | [INFO] [stderr] 410 | / fn correct_os() { [INFO] [stderr] 411 | | macro_rules! check_os { [INFO] [stderr] 412 | | ($expected: expr, $($str: expr),+) => { [INFO] [stderr] 413 | | $( [INFO] [stderr] ... | [INFO] [stderr] 460 | | , "armv7s-apple-ios"); [INFO] [stderr] 461 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 83 [INFO] [stderr] --> src/lib.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / fn correct_env() { [INFO] [stderr] 465 | | macro_rules! check_env { [INFO] [stderr] 466 | | ($expected: expr, $($str: expr),+) => { [INFO] [stderr] 467 | | $( [INFO] [stderr] ... | [INFO] [stderr] 515 | | ); [INFO] [stderr] 516 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.92s [INFO] running `"docker" "inspect" "43c9a0561cb86e7267f18fe5b8c0550c505cd4f1b63a0a1c2ed2c9584e48b40b"` [INFO] running `"docker" "rm" "-f" "43c9a0561cb86e7267f18fe5b8c0550c505cd4f1b63a0a1c2ed2c9584e48b40b"` [INFO] [stdout] 43c9a0561cb86e7267f18fe5b8c0550c505cd4f1b63a0a1c2ed2c9584e48b40b