[INFO] crate tar 0.4.20 is already in cache
[INFO] extracting crate tar 0.4.20 into work/ex/clippy-test-run/sources/stable/reg/tar/0.4.20
[INFO] extracting crate tar 0.4.20 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tar/0.4.20
[INFO] validating manifest of tar-0.4.20 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tar-0.4.20 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tar-0.4.20
[INFO] finished frobbing tar-0.4.20
[INFO] frobbed toml for tar-0.4.20 written to work/ex/clippy-test-run/sources/stable/reg/tar/0.4.20/Cargo.toml
[INFO] started frobbing tar-0.4.20
[INFO] finished frobbing tar-0.4.20
[INFO] frobbed toml for tar-0.4.20 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tar/0.4.20/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tar-0.4.20 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tar/0.4.20:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 36118dc8d46f55c02198715a3c8e9310d24c6b6c420095e2241a4c5c10a632c2
[INFO] running `"docker" "start" "-a" "36118dc8d46f55c02198715a3c8e9310d24c6b6c420095e2241a4c5c10a632c2"`
[INFO] [stderr]     Checking xattr v0.2.2
[INFO] [stderr]     Checking tar v0.4.20 (/opt/crater/workdir)
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]   --> src/archive.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             fields: fields,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:22:24
[INFO] [stderr]    |
[INFO] [stderr] 22 | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]    |                        ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 raw: raw,
[INFO] [stderr]     |                 ^^^^^^^^ help: replace it with: `raw`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:246:13
[INFO] [stderr]     |
[INFO] [stderr] 246 |             size: size,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:247:13
[INFO] [stderr]     |
[INFO] [stderr] 247 |             header_pos: header_pos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_pos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:248:13
[INFO] [stderr]     |
[INFO] [stderr] 248 |             file_pos: file_pos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `file_pos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:250:13
[INFO] [stderr]     |
[INFO] [stderr] 250 |             header: header,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/archive.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             fields: fields,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 raw: raw,
[INFO] [stderr]     |                 ^^^^^^^^ help: replace it with: `raw`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:246:13
[INFO] [stderr]     |
[INFO] [stderr] 246 |             size: size,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:247:13
[INFO] [stderr]     |
[INFO] [stderr] 247 |             header_pos: header_pos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_pos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:248:13
[INFO] [stderr]     |
[INFO] [stderr] 248 |             file_pos: file_pos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `file_pos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/archive.rs:250:13
[INFO] [stderr]     |
[INFO] [stderr] 250 |             header: header,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entry.rs:404:9
[INFO] [stderr]     |
[INFO] [stderr] 404 | /         return fs::create_dir(dst).map_err(|err| {
[INFO] [stderr] 405 | |             Error::new(
[INFO] [stderr] 406 | |                 err.kind(),
[INFO] [stderr] 407 | |                 format!("{} when creating dir {}", err, dst.display()),
[INFO] [stderr] 408 | |             )
[INFO] [stderr] 409 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 404 |         fs::create_dir(dst).map_err(|err| {
[INFO] [stderr] 405 |             Error::new(
[INFO] [stderr] 406 |                 err.kind(),
[INFO] [stderr] 407 |                 format!("{} when creating dir {}", err, dst.display()),
[INFO] [stderr] 408 |             )
[INFO] [stderr] 409 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/header.rs:1400:15
[INFO] [stderr]      |
[INFO] [stderr] 1400 |     if src >= 8589934592 || (src >= 2097152 && dst.len() == 8) {
[INFO] [stderr]      |               ^^^^^^^^^^ help: consider: `8_589_934_592`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/header.rs:1400:37
[INFO] [stderr]      |
[INFO] [stderr] 1400 |     if src >= 8589934592 || (src >= 2097152 && dst.len() == 8) {
[INFO] [stderr]      |                                     ^^^^^^^ help: consider: `2_097_152`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/entry.rs:404:9
[INFO] [stderr]     |
[INFO] [stderr] 404 | /         return fs::create_dir(dst).map_err(|err| {
[INFO] [stderr] 405 | |             Error::new(
[INFO] [stderr] 406 | |                 err.kind(),
[INFO] [stderr] 407 | |                 format!("{} when creating dir {}", err, dst.display()),
[INFO] [stderr] 408 | |             )
[INFO] [stderr] 409 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:22:24
[INFO] [stderr]     |
[INFO] [stderr] 22  | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 404 |         fs::create_dir(dst).map_err(|err| {
[INFO] [stderr] 405 |             Error::new(
[INFO] [stderr] 406 |                 err.kind(),
[INFO] [stderr] 407 |                 format!("{} when creating dir {}", err, dst.display()),
[INFO] [stderr] 408 |             )
[INFO] [stderr] 409 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: long literal lacking separators
[INFO] [stderr]     --> src/header.rs:1400:15
[INFO] [stderr]      |
[INFO] [stderr] 1400 |     if src >= 8589934592 || (src >= 2097152 && dst.len() == 8) {
[INFO] [stderr]      |               ^^^^^^^^^^ help: consider: `8_589_934_592`
[INFO] [stderr]      |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]     --> src/lib.rs:22:24
[INFO] [stderr]      |
[INFO] [stderr] 22   | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]      |                        ^^^^^^^^
[INFO] [stderr]      = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)]
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] error: long literal lacking separators
[INFO] [stderr]     --> src/header.rs:1400:37
[INFO] [stderr]      |
[INFO] [stderr] 1400 |     if src >= 8589934592 || (src >= 2097152 && dst.len() == 8) {
[INFO] [stderr]      |                                     ^^^^^^^ help: consider: `2_097_152`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 9 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tar`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/archive.rs:236:33
[INFO] [stderr]     |
[INFO] [stderr] 236 |             .fold(0, |a, b| a + (*b as u32)) + 8 * 32;
[INFO] [stderr]     |                                 ^^^^^^^^^^^ help: try: `u32::from(*b)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/builder.rs:179:20
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let mode = self.mode.clone();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.mode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/builder.rs:211:20
[INFO] [stderr]     |
[INFO] [stderr] 211 |         let mode = self.mode.clone();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.mode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/builder.rs:245:20
[INFO] [stderr]     |
[INFO] [stderr] 245 |         let mode = self.mode.clone();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.mode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/builder.rs:276:20
[INFO] [stderr]     |
[INFO] [stderr] 276 |         let mode = self.mode.clone();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.mode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/entry_type.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn as_byte(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:130:20
[INFO] [stderr]     |
[INFO] [stderr] 130 |     pub fn is_file(&self) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:135:25
[INFO] [stderr]     |
[INFO] [stderr] 135 |     pub fn is_hard_link(&self) -> bool {
[INFO] [stderr]     |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:140:23
[INFO] [stderr]     |
[INFO] [stderr] 140 |     pub fn is_symlink(&self) -> bool {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:145:33
[INFO] [stderr]     |
[INFO] [stderr] 145 |     pub fn is_character_special(&self) -> bool {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:150:29
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn is_block_special(&self) -> bool {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:155:19
[INFO] [stderr]     |
[INFO] [stderr] 155 |     pub fn is_dir(&self) -> bool {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:160:20
[INFO] [stderr]     |
[INFO] [stderr] 160 |     pub fn is_fifo(&self) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:165:26
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn is_contiguous(&self) -> bool {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:170:28
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn is_gnu_longname(&self) -> bool {
[INFO] [stderr]     |                            ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:175:26
[INFO] [stderr]     |
[INFO] [stderr] 175 |     pub fn is_gnu_sparse(&self) -> bool {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:180:28
[INFO] [stderr]     |
[INFO] [stderr] 180 |     pub fn is_gnu_longlink(&self) -> bool {
[INFO] [stderr]     |                            ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:185:37
[INFO] [stderr]     |
[INFO] [stderr] 185 |     pub fn is_pax_global_extensions(&self) -> bool {
[INFO] [stderr]     |                                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/entry_type.rs:190:36
[INFO] [stderr]     |
[INFO] [stderr] 190 |     pub fn is_pax_local_extensions(&self) -> bool {
[INFO] [stderr]     |                                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/header.rs:611:23
[INFO] [stderr]     |
[INFO] [stderr] 611 |             return Ok(ustar.set_device_major(major));
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 611 |             return Ok(());
[INFO] [stderr]     |                       ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/header.rs:614:16
[INFO] [stderr]     |
[INFO] [stderr] 614 |             Ok(gnu.set_device_major(major))
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 614 |             Ok(())
[INFO] [stderr]     |                ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/header.rs:643:23
[INFO] [stderr]     |
[INFO] [stderr] 643 |             return Ok(ustar.set_device_minor(minor));
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 643 |             return Ok(());
[INFO] [stderr]     |                       ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/header.rs:646:16
[INFO] [stderr]     |
[INFO] [stderr] 646 |             Ok(gnu.set_device_minor(minor))
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 646 |             Ok(())
[INFO] [stderr]     |                ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/header.rs:693:33
[INFO] [stderr]     |
[INFO] [stderr] 693 |             .fold(0, |a, b| a + (*b as u32))
[INFO] [stderr]     |                                 ^^^^^^^^^^^ help: try: `u32::from(*b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/header.rs:719:30
[INFO] [stderr]     |
[INFO] [stderr] 719 |                 self.set_uid(meta.uid() as u64);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^ help: try: `u64::from(meta.uid())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/header.rs:720:30
[INFO] [stderr]     |
[INFO] [stderr] 720 |                 self.set_gid(meta.gid() as u64);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^ help: try: `u64::from(meta.gid())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:934:16
[INFO] [stderr]     |
[INFO] [stderr] 934 |             if prefix.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!prefix.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a reference to a reference
[INFO] [stderr]     --> src/header.rs:1343:18
[INFO] [stderr]      |
[INFO] [stderr] 1343 |         unsafe { mem::transmute(self) }
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const header::GnuExtSparseHeader as *const [u8; 512])`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a reference to a reference
[INFO] [stderr]     --> src/header.rs:1349:18
[INFO] [stderr]      |
[INFO] [stderr] 1349 |         unsafe { mem::transmute(self) }
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut header::GnuExtSparseHeader as *mut [u8; 512])`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/header.rs:1437:15
[INFO] [stderr]      |
[INFO] [stderr] 1437 |         dst = (src[0] ^ 0x80) as u64;
[INFO] [stderr]      |               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(src[0] ^ 0x80)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/header.rs:1444:16
[INFO] [stderr]      |
[INFO] [stderr] 1444 |         dst |= *byte as u64;
[INFO] [stderr]      |                ^^^^^^^^^^^^ help: try: `u64::from(*byte)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/pax.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |     fn is_newline(a: &u8) -> bool {
[INFO] [stderr]    |                      ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "36118dc8d46f55c02198715a3c8e9310d24c6b6c420095e2241a4c5c10a632c2"`
[INFO] running `"docker" "rm" "-f" "36118dc8d46f55c02198715a3c8e9310d24c6b6c420095e2241a4c5c10a632c2"`
[INFO] [stdout] 36118dc8d46f55c02198715a3c8e9310d24c6b6c420095e2241a4c5c10a632c2