[INFO] crate tange-collection 0.1.2 is already in cache [INFO] extracting crate tange-collection 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/tange-collection/0.1.2 [INFO] extracting crate tange-collection 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tange-collection/0.1.2 [INFO] validating manifest of tange-collection-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tange-collection-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tange-collection-0.1.2 [INFO] finished frobbing tange-collection-0.1.2 [INFO] frobbed toml for tange-collection-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/tange-collection/0.1.2/Cargo.toml [INFO] started frobbing tange-collection-0.1.2 [INFO] finished frobbing tange-collection-0.1.2 [INFO] frobbed toml for tange-collection-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tange-collection/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tange-collection-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tange-collection/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9570802d077b684de6619fb39b41388111a369c32704889900ae576da6106f5 [INFO] running `"docker" "start" "-a" "c9570802d077b684de6619fb39b41388111a369c32704889900ae576da6106f5"` [INFO] [stderr] Checking indexmap v0.4.1 [INFO] [stderr] Checking jobpool v0.3.8 [INFO] [stderr] Checking snap v0.2.5 [INFO] [stderr] Checking priority-queue v0.5.2 [INFO] [stderr] Checking tange v0.1.1 [INFO] [stderr] Checking tange-collection v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interfaces.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interfaces.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/interfaces.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | fn extend>(&mut self, i: &mut I) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/interfaces.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | fn add(&mut self, item: A) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/interfaces.rs:203:32 [INFO] [stderr] | [INFO] [stderr] 203 | fn add(&mut self, item: A) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/interfaces.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | fn extend>(&mut self, i: &mut I) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/interfaces.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | fn add(&mut self, item: A) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/interfaces.rs:203:32 [INFO] [stderr] | [INFO] [stderr] 203 | fn add(&mut self, item: A) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/interfaces.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn from_str(s: &str) -> Self { [INFO] [stderr] 122 | | Disk(Arc::new(s.to_owned())) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interfaces.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / match ek { [INFO] [stderr] 260 | | &ErrorKind::DeserializeAnyNotSupported => { [INFO] [stderr] 261 | | eprintln!("Bincode doesn't work with certain types!"); [INFO] [stderr] 262 | | panic!(); [INFO] [stderr] 263 | | }, [INFO] [stderr] 264 | | _ => None [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *ek { [INFO] [stderr] 260 | ErrorKind::DeserializeAnyNotSupported => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/memory.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | bw.write(line.as_bytes()).expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/memory.rs:470:17 [INFO] [stderr] | [INFO] [stderr] 470 | bw.write(b"\n").expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/collection/disk.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn from_memory(path: String, mc: &Vec>>) -> DiskCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Deferred>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/collection/disk.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | fn from_defs(&self, defs: Vec>>>) -> DiskCollection { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/disk.rs:484:17 [INFO] [stderr] | [INFO] [stderr] 484 | bw.write(line.as_bytes()).expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/disk.rs:485:17 [INFO] [stderr] | [INFO] [stderr] 485 | bw.write(b"\n").expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/partitioned.rs:115:6 [INFO] [stderr] | [INFO] [stderr] 115 | ) -> Vec>::VW as ValueWriter<(K, B)>>::Out>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/partitioned.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | / if !nl.contains_key(&k) { [INFO] [stderr] 157 | | nl.insert(k, v); [INFO] [stderr] 158 | | } else { [INFO] [stderr] 159 | | nl.entry(k) [INFO] [stderr] 160 | | .and_modify(|e| ri(e, &v)) [INFO] [stderr] 161 | | .or_insert_with(|| v); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________________^ help: consider using: `nl.entry(k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/partitioned.rs:229:6 [INFO] [stderr] | [INFO] [stderr] 229 | ) -> Deferred<<>::VW as ValueWriter<(K, C)>>::Out> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tange-collection`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/interfaces.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn from_str(s: &str) -> Self { [INFO] [stderr] 122 | | Disk(Arc::new(s.to_owned())) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interfaces.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / match ek { [INFO] [stderr] 260 | | &ErrorKind::DeserializeAnyNotSupported => { [INFO] [stderr] 261 | | eprintln!("Bincode doesn't work with certain types!"); [INFO] [stderr] 262 | | panic!(); [INFO] [stderr] 263 | | }, [INFO] [stderr] 264 | | _ => None [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *ek { [INFO] [stderr] 260 | ErrorKind::DeserializeAnyNotSupported => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/memory.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | bw.write(line.as_bytes()).expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/memory.rs:470:17 [INFO] [stderr] | [INFO] [stderr] 470 | bw.write(b"\n").expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:497:35 [INFO] [stderr] | [INFO] [stderr] 497 | let mut results = out.run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:507:35 [INFO] [stderr] | [INFO] [stderr] 507 | let mut results = out.run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:518:36 [INFO] [stderr] | [INFO] [stderr] 518 | let results = computed.run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:528:36 [INFO] [stderr] | [INFO] [stderr] 528 | let results = computed.run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:535:48 [INFO] [stderr] | [INFO] [stderr] 535 | let results = col.split(3).count().run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:547:31 [INFO] [stderr] | [INFO] [stderr] 547 | let results = out.run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:561:18 [INFO] [stderr] | [INFO] [stderr] 561 | .run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/memory.rs:570:18 [INFO] [stderr] | [INFO] [stderr] 570 | .run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/collection/disk.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn from_memory(path: String, mc: &Vec>>) -> DiskCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Deferred>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/collection/disk.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | fn from_defs(&self, defs: Vec>>>) -> DiskCollection { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/disk.rs:484:17 [INFO] [stderr] | [INFO] [stderr] 484 | bw.write(line.as_bytes()).expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/collection/disk.rs:485:17 [INFO] [stderr] | [INFO] [stderr] 485 | bw.write(b"\n").expect("Error writing out line"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `run` doesn't need a mutable reference [INFO] [stderr] --> src/collection/disk.rs:547:48 [INFO] [stderr] | [INFO] [stderr] 547 | let results = col.split(3).count().run(&mut LeveledScheduler).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/partitioned.rs:115:6 [INFO] [stderr] | [INFO] [stderr] 115 | ) -> Vec>::VW as ValueWriter<(K, B)>>::Out>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/partitioned.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | / if !nl.contains_key(&k) { [INFO] [stderr] 157 | | nl.insert(k, v); [INFO] [stderr] 158 | | } else { [INFO] [stderr] 159 | | nl.entry(k) [INFO] [stderr] 160 | | .and_modify(|e| ri(e, &v)) [INFO] [stderr] 161 | | .or_insert_with(|| v); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________________^ help: consider using: `nl.entry(k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/partitioned.rs:229:6 [INFO] [stderr] | [INFO] [stderr] 229 | ) -> Deferred<<>::VW as ValueWriter<(K, C)>>::Out> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tange-collection`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c9570802d077b684de6619fb39b41388111a369c32704889900ae576da6106f5"` [INFO] running `"docker" "rm" "-f" "c9570802d077b684de6619fb39b41388111a369c32704889900ae576da6106f5"` [INFO] [stdout] c9570802d077b684de6619fb39b41388111a369c32704889900ae576da6106f5