[INFO] crate tange 0.1.1 is already in cache
[INFO] extracting crate tange 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/tange/0.1.1
[INFO] extracting crate tange 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tange/0.1.1
[INFO] validating manifest of tange-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tange-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tange-0.1.1
[INFO] finished frobbing tange-0.1.1
[INFO] frobbed toml for tange-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/tange/0.1.1/Cargo.toml
[INFO] started frobbing tange-0.1.1
[INFO] finished frobbing tange-0.1.1
[INFO] frobbed toml for tange-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tange/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tange-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tange/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 05f08e87e84d329360cb1da89f73acb71c29d090317db155b6ccffdd58133f69
[INFO] running `"docker" "start" "-a" "05f08e87e84d329360cb1da89f73acb71c29d090317db155b6ccffdd58133f69"`
[INFO] [stderr]     Checking indexmap v0.4.1
[INFO] [stderr]     Checking jobpool v0.3.8
[INFO] [stderr]     Checking priority-queue v0.5.2
[INFO] [stderr]     Checking tange v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/deferred.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             graph: graph,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `graph`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scheduler.rs:35:20
[INFO] [stderr]    |
[INFO] [stderr] 35 |         DataStore {data: data, counts: counts}
[INFO] [stderr]    |                    ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scheduler.rs:35:32
[INFO] [stderr]    |
[INFO] [stderr] 35 |         DataStore {data: data, counts: counts}
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^ help: replace it with: `counts`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scheduler.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             tasks: tasks,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `tasks`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scheduler.rs:111:13
[INFO] [stderr]     |
[INFO] [stderr] 111 |             dependencies: dependencies
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/graph.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |             handle: handle,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/graph.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             handle: handle,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/graph.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             task: task,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `task`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/deferred.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             graph: graph,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `graph`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scheduler.rs:35:20
[INFO] [stderr]    |
[INFO] [stderr] 35 |         DataStore {data: data, counts: counts}
[INFO] [stderr]    |                    ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scheduler.rs:35:32
[INFO] [stderr]    |
[INFO] [stderr] 35 |         DataStore {data: data, counts: counts}
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^ help: replace it with: `counts`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scheduler.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             tasks: tasks,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `tasks`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scheduler.rs:111:13
[INFO] [stderr]     |
[INFO] [stderr] 111 |             dependencies: dependencies
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/graph.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |             handle: handle,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/graph.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             handle: handle,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/graph.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             task: task,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `task`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/scheduler.rs:409:9
[INFO] [stderr]     |
[INFO] [stderr] 409 |         ret
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/scheduler.rs:406:19
[INFO] [stderr]     |
[INFO] [stderr] 406 |           let ret = {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 407 | |             dsam.lock().unwrap().get(&out_handle)
[INFO] [stderr] 408 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/scheduler.rs:428:53
[INFO] [stderr]     |
[INFO] [stderr] 428 |     pub fn set_threads(&mut self, n_threads: usize) -> () {
[INFO] [stderr]     |                                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/scheduler.rs:563:9
[INFO] [stderr]     |
[INFO] [stderr] 563 |         ret
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/scheduler.rs:560:19
[INFO] [stderr]     |
[INFO] [stderr] 560 |           let ret = {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 561 | |             dsam.lock().unwrap().get(&out_handle)
[INFO] [stderr] 562 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/scheduler.rs:409:9
[INFO] [stderr]     |
[INFO] [stderr] 409 |         ret
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/scheduler.rs:406:19
[INFO] [stderr]     |
[INFO] [stderr] 406 |           let ret = {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 407 | |             dsam.lock().unwrap().get(&out_handle)
[INFO] [stderr] 408 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/scheduler.rs:428:53
[INFO] [stderr]     |
[INFO] [stderr] 428 |     pub fn set_threads(&mut self, n_threads: usize) -> () {
[INFO] [stderr]     |                                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/scheduler.rs:563:9
[INFO] [stderr]     |
[INFO] [stderr] 563 |         ret
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/scheduler.rs:560:19
[INFO] [stderr]     |
[INFO] [stderr] 560 |           let ret = {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 561 | |             dsam.lock().unwrap().get(&out_handle)
[INFO] [stderr] 562 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/deferred.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 ab.downcast_ref::<A>().map(|x| x.clone())
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ab.downcast_ref::<A>().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deferred.rs:198:8
[INFO] [stderr]     |
[INFO] [stderr] 198 |     if defs.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `defs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/deferred.rs:201:14
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Some(defs.clone().to_vec())
[INFO] [stderr]     |              ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Some(&(*defs).clone().to_vec())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Some(&[deferred::Deferred<A>]::clone(defs).to_vec())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/deferred.rs:222:25
[INFO] [stderr]     |
[INFO] [stderr] 222 |         let v: Vec<_> = (0..999usize).into_iter()
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..999usize)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/deferred.rs:236:25
[INFO] [stderr]     |
[INFO] [stderr] 236 |         let v: Vec<_> = (0..2usize).into_iter()
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..2usize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/scheduler.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             self.data.get(handle).map(|x| x.clone())
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.data.get(handle).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scheduler.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 | /     match fa {
[INFO] [stderr] 119 | |         &FnArgs::Single(ref g) => {
[INFO] [stderr] 120 | |             ds.get(&g.handle).map(|args| {
[INFO] [stderr] 121 | |                 Limbo::One(args)
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |         }
[INFO] [stderr] 131 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 118 |     match *fa {
[INFO] [stderr] 119 |         FnArgs::Single(ref g) => {
[INFO] [stderr] 120 |             ds.get(&g.handle).map(|args| {
[INFO] [stderr] 121 |                 Limbo::One(args)
[INFO] [stderr] 122 |             })
[INFO] [stderr] 123 |         },
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scheduler.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 | /             match fna {
[INFO] [stderr] 145 | |                 &FnArgs::Single(ref h) => hs.insert(h.handle.clone()),
[INFO] [stderr] 146 | |                 &FnArgs::Join(ref h1, ref h2) => {
[INFO] [stderr] 147 | |                     hs.insert(h1.handle.clone());
[INFO] [stderr] 148 | |                     hs.insert(h2.handle.clone())
[INFO] [stderr] 149 | |                 },
[INFO] [stderr] 150 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 144 |             match *fna {
[INFO] [stderr] 145 |                 FnArgs::Single(ref h) => hs.insert(h.handle.clone()),
[INFO] [stderr] 146 |                 FnArgs::Join(ref h1, ref h2) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scheduler.rs:292:47
[INFO] [stderr]     |
[INFO] [stderr] 292 |             let e = outbound.entry(d.clone()).or_insert(Vec::new());
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scheduler::GreedyScheduler`
[INFO] [stderr]    --> src/scheduler.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     pub fn new() -> Self {
[INFO] [stderr] 424 | |         GreedyScheduler(num_cpus::get())
[INFO] [stderr] 425 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 418 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 34
[INFO] [stderr]    --> src/scheduler.rs:435:5
[INFO] [stderr]     |
[INFO] [stderr] 435 | /     fn compute(
[INFO] [stderr] 436 | |         &self, 
[INFO] [stderr] 437 | |         graph: Arc<Graph>
[INFO] [stderr] 438 | |     ) -> Option<Arc<BASS>> {
[INFO] [stderr] ...   |
[INFO] [stderr] 563 | |         ret
[INFO] [stderr] 564 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scheduler.rs:459:16
[INFO] [stderr]     |
[INFO] [stderr] 459 |             if deps.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `deps.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/deferred.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 ab.downcast_ref::<A>().map(|x| x.clone())
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ab.downcast_ref::<A>().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deferred.rs:198:8
[INFO] [stderr]     |
[INFO] [stderr] 198 |     if defs.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `defs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/deferred.rs:201:14
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Some(defs.clone().to_vec())
[INFO] [stderr]     |              ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Some(&(*defs).clone().to_vec())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Some(&[deferred::Deferred<A>]::clone(defs).to_vec())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/scheduler.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             self.data.get(handle).map(|x| x.clone())
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.data.get(handle).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scheduler.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 | /     match fa {
[INFO] [stderr] 119 | |         &FnArgs::Single(ref g) => {
[INFO] [stderr] 120 | |             ds.get(&g.handle).map(|args| {
[INFO] [stderr] 121 | |                 Limbo::One(args)
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |         }
[INFO] [stderr] 131 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 118 |     match *fa {
[INFO] [stderr] 119 |         FnArgs::Single(ref g) => {
[INFO] [stderr] 120 |             ds.get(&g.handle).map(|args| {
[INFO] [stderr] 121 |                 Limbo::One(args)
[INFO] [stderr] 122 |             })
[INFO] [stderr] 123 |         },
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tange`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scheduler.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 | /             match fna {
[INFO] [stderr] 145 | |                 &FnArgs::Single(ref h) => hs.insert(h.handle.clone()),
[INFO] [stderr] 146 | |                 &FnArgs::Join(ref h1, ref h2) => {
[INFO] [stderr] 147 | |                     hs.insert(h1.handle.clone());
[INFO] [stderr] 148 | |                     hs.insert(h2.handle.clone())
[INFO] [stderr] 149 | |                 },
[INFO] [stderr] 150 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 144 |             match *fna {
[INFO] [stderr] 145 |                 FnArgs::Single(ref h) => hs.insert(h.handle.clone()),
[INFO] [stderr] 146 |                 FnArgs::Join(ref h1, ref h2) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scheduler.rs:292:47
[INFO] [stderr]     |
[INFO] [stderr] 292 |             let e = outbound.entry(d.clone()).or_insert(Vec::new());
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scheduler::GreedyScheduler`
[INFO] [stderr]    --> src/scheduler.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     pub fn new() -> Self {
[INFO] [stderr] 424 | |         GreedyScheduler(num_cpus::get())
[INFO] [stderr] 425 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 418 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 34
[INFO] [stderr]    --> src/scheduler.rs:435:5
[INFO] [stderr]     |
[INFO] [stderr] 435 | /     fn compute(
[INFO] [stderr] 436 | |         &self, 
[INFO] [stderr] 437 | |         graph: Arc<Graph>
[INFO] [stderr] 438 | |     ) -> Option<Arc<BASS>> {
[INFO] [stderr] ...   |
[INFO] [stderr] 563 | |         ret
[INFO] [stderr] 564 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scheduler.rs:459:16
[INFO] [stderr]     |
[INFO] [stderr] 459 |             if deps.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `deps.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tange`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "05f08e87e84d329360cb1da89f73acb71c29d090317db155b6ccffdd58133f69"`
[INFO] running `"docker" "rm" "-f" "05f08e87e84d329360cb1da89f73acb71c29d090317db155b6ccffdd58133f69"`
[INFO] [stdout] 05f08e87e84d329360cb1da89f73acb71c29d090317db155b6ccffdd58133f69