[INFO] crate tail-reader 3.0.0 is already in cache [INFO] extracting crate tail-reader 3.0.0 into work/ex/clippy-test-run/sources/stable/reg/tail-reader/3.0.0 [INFO] extracting crate tail-reader 3.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tail-reader/3.0.0 [INFO] validating manifest of tail-reader-3.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tail-reader-3.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tail-reader-3.0.0 [INFO] finished frobbing tail-reader-3.0.0 [INFO] frobbed toml for tail-reader-3.0.0 written to work/ex/clippy-test-run/sources/stable/reg/tail-reader/3.0.0/Cargo.toml [INFO] started frobbing tail-reader-3.0.0 [INFO] finished frobbing tail-reader-3.0.0 [INFO] frobbed toml for tail-reader-3.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tail-reader/3.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tail-reader-3.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tail-reader/3.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd5fe5cb6669e585e852d539d83c0c0406628a3d95456d5a9ce65550333ec622 [INFO] running `"docker" "start" "-a" "dd5fe5cb6669e585e852d539d83c0c0406628a3d95456d5a9ce65550333ec622"` [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking notify v4.0.7 [INFO] [stderr] Checking tail-reader v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tail_reader.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / match file.seek(SeekFrom::Start(tail_info.offset)) { [INFO] [stderr] 129 | | Err(e) => { [INFO] [stderr] 130 | | error!("{}", e); [INFO] [stderr] 131 | | return; [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | _ => {} [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Err(e) = file.seek(SeekFrom::Start(tail_info.offset)) { [INFO] [stderr] 129 | error!("{}", e); [INFO] [stderr] 130 | return; [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tail_reader.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / match file.read_to_end(&mut bytes) { [INFO] [stderr] 138 | | Err(e) => { [INFO] [stderr] 139 | | error!("{}", e); [INFO] [stderr] 140 | | return; [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | _ => {} [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let Err(e) = file.read_to_end(&mut bytes) { [INFO] [stderr] 138 | error!("{}", e); [INFO] [stderr] 139 | return; [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tail_reader.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | .unwrap_or(String::from("error parsing line")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("error parsing line"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tail_reader.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / match file.seek(SeekFrom::Start(tail_info.offset)) { [INFO] [stderr] 129 | | Err(e) => { [INFO] [stderr] 130 | | error!("{}", e); [INFO] [stderr] 131 | | return; [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | _ => {} [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Err(e) = file.seek(SeekFrom::Start(tail_info.offset)) { [INFO] [stderr] 129 | error!("{}", e); [INFO] [stderr] 130 | return; [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tail_reader.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / match file.read_to_end(&mut bytes) { [INFO] [stderr] 138 | | Err(e) => { [INFO] [stderr] 139 | | error!("{}", e); [INFO] [stderr] 140 | | return; [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | _ => {} [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let Err(e) = file.read_to_end(&mut bytes) { [INFO] [stderr] 138 | error!("{}", e); [INFO] [stderr] 139 | return; [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tail_reader.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | .unwrap_or(String::from("error parsing line")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("error parsing line"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.96s [INFO] running `"docker" "inspect" "dd5fe5cb6669e585e852d539d83c0c0406628a3d95456d5a9ce65550333ec622"` [INFO] running `"docker" "rm" "-f" "dd5fe5cb6669e585e852d539d83c0c0406628a3d95456d5a9ce65550333ec622"` [INFO] [stdout] dd5fe5cb6669e585e852d539d83c0c0406628a3d95456d5a9ce65550333ec622