[INFO] crate tabular 0.1.2 is already in cache [INFO] extracting crate tabular 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/tabular/0.1.2 [INFO] extracting crate tabular 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tabular/0.1.2 [INFO] validating manifest of tabular-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tabular-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tabular-0.1.2 [INFO] finished frobbing tabular-0.1.2 [INFO] frobbed toml for tabular-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/tabular/0.1.2/Cargo.toml [INFO] started frobbing tabular-0.1.2 [INFO] finished frobbing tabular-0.1.2 [INFO] frobbed toml for tabular-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tabular/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tabular-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tabular/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e81b6bb9c27745951f8deec1b72908009a62a398dfbce149420b2f1f4d7cd27 [INFO] running `"docker" "start" "-a" "8e81b6bb9c27745951f8deec1b72908009a62a398dfbce149420b2f1f4d7cd27"` [INFO] [stderr] Checking tabular v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/table.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | const DEFAULT_LINE_END: &'static str = "\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/width_string.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return WidthString { string: String::new(), width: 0, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WidthString { string: String::new(), width: 0, }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/table.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | const DEFAULT_LINE_END: &'static str = "\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/width_string.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return WidthString { string: String::new(), width: 0, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WidthString { string: String::new(), width: 0, }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: item `row::Row` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/row.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Row { [INFO] [stderr] 44 | | /// Makes a new, empty table row. [INFO] [stderr] 45 | | pub fn new() -> Self { [INFO] [stderr] 46 | | Row(Vec::new()) [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `row::Row` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/row.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Row { [INFO] [stderr] 44 | | /// Makes a new, empty table row. [INFO] [stderr] 45 | | pub fn new() -> Self { [INFO] [stderr] 46 | | Row(Vec::new()) [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "8e81b6bb9c27745951f8deec1b72908009a62a398dfbce149420b2f1f4d7cd27"` [INFO] running `"docker" "rm" "-f" "8e81b6bb9c27745951f8deec1b72908009a62a398dfbce149420b2f1f4d7cd27"` [INFO] [stdout] 8e81b6bb9c27745951f8deec1b72908009a62a398dfbce149420b2f1f4d7cd27