[INFO] crate tabin-plugins 0.3.1 is already in cache [INFO] extracting crate tabin-plugins 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/tabin-plugins/0.3.1 [INFO] extracting crate tabin-plugins 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tabin-plugins/0.3.1 [INFO] validating manifest of tabin-plugins-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tabin-plugins-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tabin-plugins-0.3.1 [INFO] finished frobbing tabin-plugins-0.3.1 [INFO] frobbed toml for tabin-plugins-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/tabin-plugins/0.3.1/Cargo.toml [INFO] started frobbing tabin-plugins-0.3.1 [INFO] finished frobbing tabin-plugins-0.3.1 [INFO] frobbed toml for tabin-plugins-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tabin-plugins/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tabin-plugins-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tabin-plugins/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4db85e6948a969676dbaeaa6a88f1aca0112884939450bbf99747eab1b61b18f [INFO] running `"docker" "start" "-a" "4db85e6948a969676dbaeaa6a88f1aca0112884939450bbf99747eab1b61b18f"` [INFO] [stderr] Checking wrapped_enum v0.1.3 [INFO] [stderr] Compiling syn v0.12.15 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking scan_fmt v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Compiling derive_more v0.8.0 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking tabin-plugins v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/procfs/mod.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / write!( [INFO] [stderr] 71 | | f, [INFO] [stderr] 72 | | "loaded {} processes correctly, but got {} errors:\n", [INFO] [stderr] 73 | | self.procs.len(), [INFO] [stderr] 74 | | self.errors.len() [INFO] [stderr] 75 | | )?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/procfs/mod.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/procfs/mod.rs:825:5 [INFO] [stderr] | [INFO] [stderr] 825 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/procfs/mod.rs:850:5 [INFO] [stderr] | [INFO] [stderr] 850 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/procfs/mod.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / write!( [INFO] [stderr] 71 | | f, [INFO] [stderr] 72 | | "loaded {} processes correctly, but got {} errors:\n", [INFO] [stderr] 73 | | self.procs.len(), [INFO] [stderr] 74 | | self.errors.len() [INFO] [stderr] 75 | | )?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/procfs/mod.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/procfs/mod.rs:825:5 [INFO] [stderr] | [INFO] [stderr] 825 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/procfs/mod.rs:850:5 [INFO] [stderr] | [INFO] [stderr] 850 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/procfs/pid/stat.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / return Err(ParseStatError { [INFO] [stderr] 91 | | line: row, [INFO] [stderr] 92 | | field_name, [INFO] [stderr] 93 | | position, [INFO] [stderr] 94 | | }.into()); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 90 | Err(ParseStatError { [INFO] [stderr] 91 | line: row, [INFO] [stderr] 92 | field_name, [INFO] [stderr] 93 | position, [INFO] [stderr] 94 | }.into()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/procfs/pid/stat.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / return Err(ParseStatError { [INFO] [stderr] 91 | | line: row, [INFO] [stderr] 92 | | field_name, [INFO] [stderr] 93 | | position, [INFO] [stderr] 94 | | }.into()); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 90 | Err(ParseStatError { [INFO] [stderr] 91 | line: row, [INFO] [stderr] 92 | field_name, [INFO] [stderr] 93 | position, [INFO] [stderr] 94 | }.into()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/linux.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | bytes = bytes / 1024.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes /= 1024.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/linux.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn duration(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/linux.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn duration(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/linux.rs:170:57 [INFO] [stderr] | [INFO] [stderr] 170 | let my_nanos = self.as_secs() * 1_000_000_000 + self.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/linux.rs:171:57 [INFO] [stderr] | [INFO] [stderr] 171 | let rhs_nanos = rhs.as_secs() * 1_000_000_000 + rhs.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rhs.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/procfs/mod.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &Io(ref e) => write!(f, "{}", e), [INFO] [stderr] 50 | | &InsufficientData(ref e) => write!(f, "{}", e), [INFO] [stderr] 51 | | &InvalidFloat(ref e) => write!(f, "{}", e), [INFO] [stderr] ... | [INFO] [stderr] 55 | | &ParseStateError(ref e) => write!(f, "{}", e), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Io(ref e) => write!(f, "{}", e), [INFO] [stderr] 50 | InsufficientData(ref e) => write!(f, "{}", e), [INFO] [stderr] 51 | InvalidFloat(ref e) => write!(f, "{}", e), [INFO] [stderr] 52 | InvalidInt(ref e) => write!(f, "{}", e), [INFO] [stderr] 53 | LoadProcsError(ref e) => write!(f, "{}", e), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: item `procfs::ProcessCpuUsages<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/procfs/mod.rs:129:1 [INFO] [stderr] | [INFO] [stderr] 129 | / impl<'a> ProcessCpuUsages<'a> { [INFO] [stderr] 130 | | /// Sort the processes by the field [INFO] [stderr] 131 | | /// [INFO] [stderr] 132 | | /// See the `ProcField` docs for details [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `procfs::RunningProcs` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/procfs/mod.rs:158:1 [INFO] [stderr] | [INFO] [stderr] 158 | / impl RunningProcs { [INFO] [stderr] 159 | | /// Load the currently running processes from /proc/[pid]/* [INFO] [stderr] 160 | | pub fn currently_running() -> Result { [INFO] [stderr] 161 | | let mut procs = ProcMap::new(); [INFO] [stderr] ... | [INFO] [stderr] 227 | | } [INFO] [stderr] 228 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/procfs/mod.rs:376:32 [INFO] [stderr] | [INFO] [stderr] 376 | .filter(|part| part.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!part.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | cache: *fields.get("cache").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["cache"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:137:31 [INFO] [stderr] | [INFO] [stderr] 137 | rss: *fields.get("rss").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["rss"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:138:36 [INFO] [stderr] | [INFO] [stderr] 138 | rss_huge: *fields.get("rss_huge").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["rss_huge"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | swap: *fields.get("swap").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["swap"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match self { [INFO] [stderr] 51 | | &TabinError::UnknownValue(ref msg) => write!(f, "Unknown Value: {}", msg), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *self { [INFO] [stderr] 51 | TabinError::UnknownValue(ref msg) => write!(f, "Unknown Value: {}", msg), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn exit(&self) -> ! { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/linux.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | bytes = bytes / 1024.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes /= 1024.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/linux.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / reprs [INFO] [stderr] 54 | | .iter() [INFO] [stderr] 55 | | .map(|&(raw, repr): &(u64, &str)| assert_eq!(bytes_to_human_size(raw), repr)) [INFO] [stderr] 56 | | .collect::>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/linux.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / reprs [INFO] [stderr] 54 | | .iter() [INFO] [stderr] 55 | | .map(|&(raw, repr): &(u64, &str)| assert_eq!(bytes_to_human_size(raw), repr)) [INFO] [stderr] 56 | | .collect::>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/linux.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn duration(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/linux.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn duration(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/linux.rs:170:57 [INFO] [stderr] | [INFO] [stderr] 170 | let my_nanos = self.as_secs() * 1_000_000_000 + self.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/linux.rs:171:57 [INFO] [stderr] | [INFO] [stderr] 171 | let rhs_nanos = rhs.as_secs() * 1_000_000_000 + rhs.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rhs.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/procfs/mod.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &Io(ref e) => write!(f, "{}", e), [INFO] [stderr] 50 | | &InsufficientData(ref e) => write!(f, "{}", e), [INFO] [stderr] 51 | | &InvalidFloat(ref e) => write!(f, "{}", e), [INFO] [stderr] ... | [INFO] [stderr] 55 | | &ParseStateError(ref e) => write!(f, "{}", e), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Io(ref e) => write!(f, "{}", e), [INFO] [stderr] 50 | InsufficientData(ref e) => write!(f, "{}", e), [INFO] [stderr] 51 | InvalidFloat(ref e) => write!(f, "{}", e), [INFO] [stderr] 52 | InvalidInt(ref e) => write!(f, "{}", e), [INFO] [stderr] 53 | LoadProcsError(ref e) => write!(f, "{}", e), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: item `procfs::ProcessCpuUsages<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/procfs/mod.rs:129:1 [INFO] [stderr] | [INFO] [stderr] 129 | / impl<'a> ProcessCpuUsages<'a> { [INFO] [stderr] 130 | | /// Sort the processes by the field [INFO] [stderr] 131 | | /// [INFO] [stderr] 132 | | /// See the `ProcField` docs for details [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `procfs::RunningProcs` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/procfs/mod.rs:158:1 [INFO] [stderr] | [INFO] [stderr] 158 | / impl RunningProcs { [INFO] [stderr] 159 | | /// Load the currently running processes from /proc/[pid]/* [INFO] [stderr] 160 | | pub fn currently_running() -> Result { [INFO] [stderr] 161 | | let mut procs = ProcMap::new(); [INFO] [stderr] ... | [INFO] [stderr] 227 | | } [INFO] [stderr] 228 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/procfs/mod.rs:376:32 [INFO] [stderr] | [INFO] [stderr] 376 | .filter(|part| part.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!part.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/procfs/mod.rs:936:9 [INFO] [stderr] | [INFO] [stderr] 936 | assert_eq!(mem.percent_free().unwrap(), 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/procfs/mod.rs:936:9 [INFO] [stderr] | [INFO] [stderr] 936 | assert_eq!(mem.percent_free().unwrap(), 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/procfs/mod.rs:944:9 [INFO] [stderr] | [INFO] [stderr] 944 | assert_eq!(mem.percent_free().unwrap(), 45.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/procfs/mod.rs:944:9 [INFO] [stderr] | [INFO] [stderr] 944 | assert_eq!(mem.percent_free().unwrap(), 45.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/procfs/mod.rs:1086:17 [INFO] [stderr] | [INFO] [stderr] 1086 | assert!(procs.0.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!procs.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/procfs/mod.rs:1092:9 [INFO] [stderr] | [INFO] [stderr] 1092 | / assert_eq!( [INFO] [stderr] 1093 | | info.percent_free().unwrap() + info.percent_used().unwrap(), [INFO] [stderr] 1094 | | 100.0 [INFO] [stderr] 1095 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/procfs/mod.rs:1092:9 [INFO] [stderr] | [INFO] [stderr] 1092 | / assert_eq!( [INFO] [stderr] 1093 | | info.percent_free().unwrap() + info.percent_used().unwrap(), [INFO] [stderr] 1094 | | 100.0 [INFO] [stderr] 1095 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | cache: *fields.get("cache").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["cache"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:137:31 [INFO] [stderr] | [INFO] [stderr] 137 | rss: *fields.get("rss").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["rss"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:138:36 [INFO] [stderr] | [INFO] [stderr] 138 | rss_huge: *fields.get("rss_huge").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["rss_huge"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sys.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | swap: *fields.get("swap").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fields["swap"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match self { [INFO] [stderr] 51 | | &TabinError::UnknownValue(ref msg) => write!(f, "Unknown Value: {}", msg), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *self { [INFO] [stderr] 51 | TabinError::UnknownValue(ref msg) => write!(f, "Unknown Value: {}", msg), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn exit(&self) -> ! { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tabin-plugins`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/check-graphite/args.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | assertions: assertions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assertions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/check-graphite/assertions.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | series_ratio: series_ratio, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `series_ratio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/check-fs-writeable.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/check-fs-writeable.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | return join_result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `join_result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/check-fs-writeable.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / return Err(format!( [INFO] [stderr] 92 | | "UNKNOWN: unexpected status receiving info about file writing." [INFO] [stderr] 93 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 91 | Err(format!( [INFO] [stderr] 92 | "UNKNOWN: unexpected status receiving info about file writing." [INFO] [stderr] 93 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/check-fs-writeable.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | let dir = path.parent().unwrap_or(Path::new("/")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/check-fs-writeable.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | return Err(format!( [INFO] [stderr] | ________________________^ [INFO] [stderr] 92 | | "UNKNOWN: unexpected status receiving info about file writing." [INFO] [stderr] 93 | | )); [INFO] [stderr] | |_____________^ help: consider using .to_string(): `"UNKNOWN: unexpected status receiving info about file writing.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/check-load.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/check-container-cpu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/check-container-cpu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/check-container-cpu.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | let available_cpus = shares().unwrap() as f64 / shares_per_cpu as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(shares().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/check-container-cpu.rs:92:57 [INFO] [stderr] | [INFO] [stderr] 92 | let available_cpus = shares().unwrap() as f64 / shares_per_cpu as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(shares_per_cpu)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/check-container-cpu.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | let available_cpus = shares().unwrap() as f64 / shares_per_cpu as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(shares().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/check-container-cpu.rs:92:57 [INFO] [stderr] | [INFO] [stderr] 92 | let available_cpus = shares().unwrap() as f64 / shares_per_cpu as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(shares_per_cpu)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-container-cpu.rs:199:84 [INFO] [stderr] | [INFO] [stderr] 199 | let args: Args = Args::from_iter(["arg0", "--crit", "480", "--warn", "20"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/check-container-cpu.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(args.crit, 480.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/check-container-cpu.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(args.crit, 480.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-container-cpu.rs:204:82 [INFO] [stderr] | [INFO] [stderr] 204 | Args::from_iter(["arg0", "--crit", "480", "--shares-per-cpu", "100"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/check-container-cpu.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(args.crit, 480.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/check-container-cpu.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(args.crit, 480.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tabin-plugins`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/check-ram.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/check-procs.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/bin/check-procs.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | let should_die = if let Some(_) = args.crit_over { [INFO] [stderr] | ______________________- ^^^^^^^ [INFO] [stderr] 135 | | !args.allow_unparseable_procs [INFO] [stderr] 136 | | } else { [INFO] [stderr] 137 | | false [INFO] [stderr] 138 | | }; [INFO] [stderr] | |_____- help: try this: `if args.crit_over.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/check-procs.rs:189:8 [INFO] [stderr] | [INFO] [stderr] 189 | if matches.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-procs.rs:302:76 [INFO] [stderr] | [INFO] [stderr] 302 | let args = Args::from_iter(["c-p", "some.*proc", "--crit-under=1"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-procs.rs:308:76 [INFO] [stderr] | [INFO] [stderr] 308 | let args = Args::from_iter(["c-p", "some.*proc", "--state=zombie"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-procs.rs:311:85 [INFO] [stderr] | [INFO] [stderr] 311 | Args::from_iter(["c-p", "some.*proc", "--state=zombie", "--state", "S"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-procs.rs:317:85 [INFO] [stderr] | [INFO] [stderr] 317 | let args = Args::from_iter(["c-p", "--state", "zombie", "--", "some.*proc"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-procs.rs:319:76 [INFO] [stderr] | [INFO] [stderr] 319 | let args = Args::from_iter(["c-p", "--state=zombie", "some.*proc"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/check-procs.rs:321:88 [INFO] [stderr] | [INFO] [stderr] 321 | let args = Args::from_iter(["c-p", "so.*proc", "--state", "zombie", "waiting"].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tabin-plugins`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/check-graphite/assertions.rs:330:20 [INFO] [stderr] | [INFO] [stderr] 330 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 331 | | if let Some(word) = ["<", "<=", ">", ">=", "==", "!="] [INFO] [stderr] 332 | | .iter() [INFO] [stderr] 333 | | .find(|&&op| op == word) [INFO] [stderr] ... | [INFO] [stderr] 344 | | } [INFO] [stderr] 345 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 330 | } else if let Some(word) = ["<", "<=", ">", ">=", "==", "!="] [INFO] [stderr] 331 | .iter() [INFO] [stderr] 332 | .find(|&&op| op == word) [INFO] [stderr] 333 | { [INFO] [stderr] 334 | operator = Some(word); [INFO] [stderr] 335 | state = AssertionState::Threshold; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/check-graphite/assertions.rs:504:40 [INFO] [stderr] | [INFO] [stderr] 504 | "==" => Box::new(move |i: f64| i == val), [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(i - val).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/check-graphite/assertions.rs:504:40 [INFO] [stderr] | [INFO] [stderr] 504 | "==" => Box::new(move |i: f64| i == val), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/check-graphite/assertions.rs:505:40 [INFO] [stderr] | [INFO] [stderr] 505 | "!=" => Box::new(move |i: f64| i != val), [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(i - val).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/check-graphite/assertions.rs:505:40 [INFO] [stderr] | [INFO] [stderr] 505 | "!=" => Box::new(move |i: f64| i != val), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | .filter(|point| !point.val.is_none()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `point.val.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:53:53 [INFO] [stderr] | [INFO] [stderr] 53 | pub(crate) fn invalid_points(&self, comparator: &Box bool>) -> Vec<&DataPoint> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn(f64) -> bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | .filter(|p| p.val.map_or(false, |v| comparator(v))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `comparator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | comparator: &Box bool>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn(f64) -> bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | .filter(|p| p.val.map_or(false, |v| comparator(v))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `comparator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | if v.round() == v { 0 } else { 2 }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(v.round() - v).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | if v.round() == v { 0 } else { 2 }, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | graphite_error: &Status, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/check-graphite/graphite.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | graphite_error: &Status, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/check-graphite/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / let mut bail = false; [INFO] [stderr] 58 | | if response.result.is_empty() { [INFO] [stderr] 59 | | println!( [INFO] [stderr] 60 | | "{}: Graphite returned no matching series for pattern '{}'", [INFO] [stderr] ... | [INFO] [stderr] 63 | | bail = true; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let bail = if response.result.is_empty() { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tabin-plugins`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4db85e6948a969676dbaeaa6a88f1aca0112884939450bbf99747eab1b61b18f"` [INFO] running `"docker" "rm" "-f" "4db85e6948a969676dbaeaa6a88f1aca0112884939450bbf99747eab1b61b18f"` [INFO] [stdout] 4db85e6948a969676dbaeaa6a88f1aca0112884939450bbf99747eab1b61b18f