[INFO] crate systemstat 0.1.3 is already in cache [INFO] extracting crate systemstat 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/systemstat/0.1.3 [INFO] extracting crate systemstat 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemstat/0.1.3 [INFO] validating manifest of systemstat-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of systemstat-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing systemstat-0.1.3 [INFO] finished frobbing systemstat-0.1.3 [INFO] frobbed toml for systemstat-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/systemstat/0.1.3/Cargo.toml [INFO] started frobbing systemstat-0.1.3 [INFO] finished frobbing systemstat-0.1.3 [INFO] frobbed toml for systemstat-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemstat/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting systemstat-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/systemstat/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8032f25576771f3ca2b6f52a9b7f8a052d8770edfd5185e1f812a30acbabc274 [INFO] running `"docker" "start" "-a" "8032f25576771f3ca2b6f52a9b7f8a052d8770edfd5185e1f812a30acbabc274"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking systemstat v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/unix.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/unix.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux.rs:377:55 [INFO] [stderr] | [INFO] [stderr] 377 | platform_memory: PlatformMemory { meminfo: meminfo }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `meminfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/unix.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/unix.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux.rs:377:55 [INFO] [stderr] | [INFO] [stderr] 377 | platform_memory: PlatformMemory { meminfo: meminfo }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `meminfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/platform/linux.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / if f.len() > 3 { [INFO] [stderr] 399 | | if f.split_at(3).0 == "BAT" { [INFO] [stderr] 400 | | full += try!( [INFO] [stderr] 401 | | value_from_file::(&(s.to_string() + "/energy_full")) [INFO] [stderr] ... | [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 398 | if f.len() > 3 && f.split_at(3).0 == "BAT" { [INFO] [stderr] 399 | full += try!( [INFO] [stderr] 400 | value_from_file::(&(s.to_string() + "/energy_full")) [INFO] [stderr] 401 | .or_else(|_| value_from_file::(&(s.to_string() + "/charge_full"))) [INFO] [stderr] 402 | ); [INFO] [stderr] 403 | now += try!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/platform/linux.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / if f.len() > 3 { [INFO] [stderr] 399 | | if f.split_at(3).0 == "BAT" { [INFO] [stderr] 400 | | full += try!( [INFO] [stderr] 401 | | value_from_file::(&(s.to_string() + "/energy_full")) [INFO] [stderr] ... | [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 398 | if f.len() > 3 && f.split_at(3).0 == "BAT" { [INFO] [stderr] 399 | full += try!( [INFO] [stderr] 400 | value_from_file::(&(s.to_string() + "/energy_full")) [INFO] [stderr] 401 | .or_else(|_| value_from_file::(&(s.to_string() + "/charge_full"))) [INFO] [stderr] 402 | ); [INFO] [stderr] 403 | now += try!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/platform/common.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | .map_err(|e| io::Error::new(io::ErrorKind::Other, "Could not process time")) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/platform/common.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | .map_err(|e| io::Error::new(io::ErrorKind::Other, "Could not process time")))) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/platform/unix.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let mut entry = result.entry(name.clone()).or_insert(Network { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/platform/common.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | .map_err(|e| io::Error::new(io::ErrorKind::Other, "Could not process time")) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/platform/common.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | .map_err(|e| io::Error::new(io::ErrorKind::Other, "Could not process time")))) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/platform/unix.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let mut entry = result.entry(name.clone()).or_insert(Network { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/platform/unix.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | while ifap != ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/platform/unix.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | if aptr == ptr::null() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/platform/unix.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | match addr.sa_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(addr.sa_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/platform/unix.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | let addr6: *const sockaddr_in6 = unsafe { mem::transmute(aptr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `aptr as *const libc::sockaddr_in6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/platform/unix.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | &mut a[..].reverse(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a[..].reverse();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platform/linux.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | .and_then(|n| Ok(n)) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/platform/linux.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | .trim_right_matches("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platform/linux.rs:151:1 [INFO] [stderr] | [INFO] [stderr] 151 | / named!(word_s, flat_map!( [INFO] [stderr] 152 | | map_res!(take_till!(is_space), str::from_utf8), [INFO] [stderr] 153 | | parse_to!(String) [INFO] [stderr] 154 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:359:71 [INFO] [stderr] | [INFO] [stderr] 359 | total: meminfo.get("MemTotal").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 360 | | ByteSize::b(0), [INFO] [stderr] 361 | | ), [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:359:28 [INFO] [stderr] | [INFO] [stderr] 359 | total: meminfo.get("MemTotal").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("MemTotal").cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:359:60 [INFO] [stderr] | [INFO] [stderr] 359 | total: meminfo.get("MemTotal").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:362:69 [INFO] [stderr] | [INFO] [stderr] 362 | free: meminfo.get("MemFree").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 363 | | ByteSize::b(0), [INFO] [stderr] 364 | | ) + [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:362:27 [INFO] [stderr] | [INFO] [stderr] 362 | free: meminfo.get("MemFree").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("MemFree").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:362:58 [INFO] [stderr] | [INFO] [stderr] 362 | free: meminfo.get("MemFree").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:365:67 [INFO] [stderr] | [INFO] [stderr] 365 | meminfo.get("Buffers").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 366 | | ByteSize::b(0), [INFO] [stderr] 367 | | ) + [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:365:25 [INFO] [stderr] | [INFO] [stderr] 365 | meminfo.get("Buffers").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("Buffers").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:365:56 [INFO] [stderr] | [INFO] [stderr] 365 | meminfo.get("Buffers").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:368:66 [INFO] [stderr] | [INFO] [stderr] 368 | meminfo.get("Cached").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 369 | | ByteSize::b(0), [INFO] [stderr] 370 | | ) + [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | meminfo.get("Cached").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("Cached").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:368:55 [INFO] [stderr] | [INFO] [stderr] 368 | meminfo.get("Cached").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:371:72 [INFO] [stderr] | [INFO] [stderr] 371 | meminfo.get("SReclaimable").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 372 | | ByteSize::b(0), [INFO] [stderr] 373 | | ) - [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:371:25 [INFO] [stderr] | [INFO] [stderr] 371 | meminfo.get("SReclaimable").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("SReclaimable").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:371:61 [INFO] [stderr] | [INFO] [stderr] 371 | meminfo.get("SReclaimable").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:374:65 [INFO] [stderr] | [INFO] [stderr] 374 | meminfo.get("Shmem").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 375 | | ByteSize::b(0), [INFO] [stderr] 376 | | ), [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:374:25 [INFO] [stderr] | [INFO] [stderr] 374 | meminfo.get("Shmem").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("Shmem").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:374:54 [INFO] [stderr] | [INFO] [stderr] 374 | meminfo.get("Shmem").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/platform/unix.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | while ifap != ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/platform/unix.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | if aptr == ptr::null() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/platform/unix.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | match addr.sa_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(addr.sa_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/platform/unix.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | let addr6: *const sockaddr_in6 = unsafe { mem::transmute(aptr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `aptr as *const libc::sockaddr_in6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/platform/unix.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | &mut a[..].reverse(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a[..].reverse();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platform/linux.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | .and_then(|n| Ok(n)) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/platform/linux.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | .trim_right_matches("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platform/linux.rs:151:1 [INFO] [stderr] | [INFO] [stderr] 151 | / named!(word_s, flat_map!( [INFO] [stderr] 152 | | map_res!(take_till!(is_space), str::from_utf8), [INFO] [stderr] 153 | | parse_to!(String) [INFO] [stderr] 154 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:359:71 [INFO] [stderr] | [INFO] [stderr] 359 | total: meminfo.get("MemTotal").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 360 | | ByteSize::b(0), [INFO] [stderr] 361 | | ), [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:359:28 [INFO] [stderr] | [INFO] [stderr] 359 | total: meminfo.get("MemTotal").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("MemTotal").cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:359:60 [INFO] [stderr] | [INFO] [stderr] 359 | total: meminfo.get("MemTotal").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:362:69 [INFO] [stderr] | [INFO] [stderr] 362 | free: meminfo.get("MemFree").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 363 | | ByteSize::b(0), [INFO] [stderr] 364 | | ) + [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:362:27 [INFO] [stderr] | [INFO] [stderr] 362 | free: meminfo.get("MemFree").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("MemFree").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:362:58 [INFO] [stderr] | [INFO] [stderr] 362 | free: meminfo.get("MemFree").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:365:67 [INFO] [stderr] | [INFO] [stderr] 365 | meminfo.get("Buffers").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 366 | | ByteSize::b(0), [INFO] [stderr] 367 | | ) + [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:365:25 [INFO] [stderr] | [INFO] [stderr] 365 | meminfo.get("Buffers").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("Buffers").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:365:56 [INFO] [stderr] | [INFO] [stderr] 365 | meminfo.get("Buffers").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:368:66 [INFO] [stderr] | [INFO] [stderr] 368 | meminfo.get("Cached").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 369 | | ByteSize::b(0), [INFO] [stderr] 370 | | ) + [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | meminfo.get("Cached").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("Cached").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:368:55 [INFO] [stderr] | [INFO] [stderr] 368 | meminfo.get("Cached").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:371:72 [INFO] [stderr] | [INFO] [stderr] 371 | meminfo.get("SReclaimable").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 372 | | ByteSize::b(0), [INFO] [stderr] 373 | | ) - [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:371:25 [INFO] [stderr] | [INFO] [stderr] 371 | meminfo.get("SReclaimable").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("SReclaimable").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:371:61 [INFO] [stderr] | [INFO] [stderr] 371 | meminfo.get("SReclaimable").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:374:65 [INFO] [stderr] | [INFO] [stderr] 374 | meminfo.get("Shmem").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 375 | | ByteSize::b(0), [INFO] [stderr] 376 | | ), [INFO] [stderr] | |_________________________^ help: try this: `unwrap_or_else(|| ByteSize::b(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/platform/linux.rs:374:25 [INFO] [stderr] | [INFO] [stderr] 374 | meminfo.get("Shmem").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `meminfo.get("Shmem").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux.rs:374:54 [INFO] [stderr] | [INFO] [stderr] 374 | meminfo.get("Shmem").map(|x| x.clone()).unwrap_or( [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/platform/mod.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | assert!(load.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!load.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/platform/mod.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | assert!(mounts.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mounts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/platform/mod.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | assert!(networks.values().find(|n| n.name == "lo0").unwrap().addrs.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!networks.values().find(|n| n.name == "lo0").unwrap().addrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.71s [INFO] running `"docker" "inspect" "8032f25576771f3ca2b6f52a9b7f8a052d8770edfd5185e1f812a30acbabc274"` [INFO] running `"docker" "rm" "-f" "8032f25576771f3ca2b6f52a9b7f8a052d8770edfd5185e1f812a30acbabc274"` [INFO] [stdout] 8032f25576771f3ca2b6f52a9b7f8a052d8770edfd5185e1f812a30acbabc274