[INFO] crate systemd-linter 0.1.3 is already in cache [INFO] extracting crate systemd-linter 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/systemd-linter/0.1.3 [INFO] extracting crate systemd-linter 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemd-linter/0.1.3 [INFO] validating manifest of systemd-linter-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of systemd-linter-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing systemd-linter-0.1.3 [INFO] removed path dependency systemd-parser from systemd-linter-0.1.3 [INFO] finished frobbing systemd-linter-0.1.3 [INFO] frobbed toml for systemd-linter-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/systemd-linter/0.1.3/Cargo.toml [INFO] started frobbing systemd-linter-0.1.3 [INFO] removed path dependency systemd-parser from systemd-linter-0.1.3 [INFO] finished frobbing systemd-linter-0.1.3 [INFO] frobbed toml for systemd-linter-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemd-linter/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting systemd-linter-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/systemd-linter/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8517799f552da96b541daa98822ded6a74b6fef00f1cc913a9c0da013564e98a [INFO] running `"docker" "start" "-a" "8517799f552da96b541daa98822ded6a74b6fef00f1cc913a9c0da013564e98a"` [INFO] [stderr] Checking systemd-parser v0.1.3 [INFO] [stderr] Checking systemd-linter v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `systemd_parser` [INFO] [stderr] --> src/lint/lint_missing_description.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use systemd_parser; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lint/lint_missing_description.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | None => return error, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lint/lint_missing_description.rs:16:78 [INFO] [stderr] | [INFO] [stderr] 16 | Some(&DirectiveEntry::Solo(ref entry)) if entry.value().is_none() => return error, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `systemd_parser` [INFO] [stderr] --> src/lint/service_type_always_explicit.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use systemd_parser; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `systemd_parser` [INFO] [stderr] --> src/lint/service_execstart_not_set.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use systemd_parser; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | unreachable!() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ignore` [INFO] [stderr] --> src/lint/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | Ignore, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lint/service_type_always_explicit.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if let None = unit.lookup_by_key("Type") { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | return Err(LintResult { [INFO] [stderr] 16 | | severity: LintSeverity::Warning, [INFO] [stderr] ... | [INFO] [stderr] 19 | | }) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____- help: try this: `if unit.lookup_by_key("Type").is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lint/service_execstart_not_set.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | if let None = unit.lookup_by_key("ExecStart") { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 17 | | return Err(LintResult { [INFO] [stderr] 18 | | severity: LintSeverity::Error, [INFO] [stderr] 19 | | message: "Service with Type==Simple MUST set ExecStart= field", [INFO] [stderr] 20 | | code: LintCode::ErrorServiceSimpleMustHaveExecstart, [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________- help: try this: `if unit.lookup_by_key("ExecStart").is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lint/mod.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | pub const ALL_LINTS : [fn(&SystemdUnit) -> Result<(), LintResult>; 3] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | writeln!(stderr(), "{}: {}", "Error".red().bold(), msg.red()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lint/lint_missing_description.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | None => return error, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lint/lint_missing_description.rs:16:78 [INFO] [stderr] | [INFO] [stderr] 16 | Some(&DirectiveEntry::Solo(ref entry)) if entry.value().is_none() => return error, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | unreachable!() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ignore` [INFO] [stderr] --> src/lint/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | Ignore, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lint/service_type_always_explicit.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if let None = unit.lookup_by_key("Type") { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | return Err(LintResult { [INFO] [stderr] 16 | | severity: LintSeverity::Warning, [INFO] [stderr] ... | [INFO] [stderr] 19 | | }) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____- help: try this: `if unit.lookup_by_key("Type").is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lint/service_execstart_not_set.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | if let None = unit.lookup_by_key("ExecStart") { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 17 | | return Err(LintResult { [INFO] [stderr] 18 | | severity: LintSeverity::Error, [INFO] [stderr] 19 | | message: "Service with Type==Simple MUST set ExecStart= field", [INFO] [stderr] 20 | | code: LintCode::ErrorServiceSimpleMustHaveExecstart, [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________- help: try this: `if unit.lookup_by_key("ExecStart").is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lint/mod.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | pub const ALL_LINTS : [fn(&SystemdUnit) -> Result<(), LintResult>; 3] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | writeln!(stderr(), "{}: {}", "Error".red().bold(), msg.red()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "8517799f552da96b541daa98822ded6a74b6fef00f1cc913a9c0da013564e98a"` [INFO] running `"docker" "rm" "-f" "8517799f552da96b541daa98822ded6a74b6fef00f1cc913a9c0da013564e98a"` [INFO] [stdout] 8517799f552da96b541daa98822ded6a74b6fef00f1cc913a9c0da013564e98a