[INFO] crate system_dns 1.0.0 is already in cache [INFO] extracting crate system_dns 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/system_dns/1.0.0 [INFO] extracting crate system_dns 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/system_dns/1.0.0 [INFO] validating manifest of system_dns-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of system_dns-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing system_dns-1.0.0 [INFO] finished frobbing system_dns-1.0.0 [INFO] frobbed toml for system_dns-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/system_dns/1.0.0/Cargo.toml [INFO] started frobbing system_dns-1.0.0 [INFO] finished frobbing system_dns-1.0.0 [INFO] frobbed toml for system_dns-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/system_dns/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting system_dns-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/system_dns/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f141cc08ecf8bce53e8e0f0855fad2412fe85ef5532ee41e82bb25d7fe17abf [INFO] running `"docker" "start" "-a" "0f141cc08ecf8bce53e8e0f0855fad2412fe85ef5532ee41e82bb25d7fe17abf"` [INFO] [stderr] Checking system_dns v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match x { [INFO] [stderr] 52 | | &IpAddr::V4(_) => AF_INET, [INFO] [stderr] 53 | | &IpAddr::V6(_) => AF_INET6, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *x { [INFO] [stderr] 52 | IpAddr::V4(_) => AF_INET, [INFO] [stderr] 53 | IpAddr::V6(_) => AF_INET6, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:105:35 [INFO] [stderr] | [INFO] [stderr] 105 | let host: *const c_char = transmute(host.as_bytes().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `host.as_bytes().as_ptr() as *const i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | forget(hints); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type libc::addrinfo [INFO] [stderr] --> src/lib.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | forget(hints); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | forget(host); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *const i8 [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | forget(host); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | forget(list); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *mut libc::addrinfo [INFO] [stderr] --> src/lib.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | forget(list); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | let tptr: *const sockaddr = transmute(ptr.ai_addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.ai_addr as *const libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | forget(mutptr); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *mut i8 [INFO] [stderr] --> src/lib.rs:143:16 [INFO] [stderr] | [INFO] [stderr] 143 | forget(mutptr); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | forget(tptr); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *const libc::sockaddr [INFO] [stderr] --> src/lib.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | forget(tptr); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing. [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | forget(ptr); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_ref)] on by default [INFO] [stderr] note: argument has type &mut libc::addrinfo [INFO] [stderr] --> src/lib.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | forget(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / match to_ip(&data) { [INFO] [stderr] 153 | | Option::Some(ip) => vec.push(ip), [INFO] [stderr] 154 | | _ => {} [INFO] [stderr] 155 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Option::Some(ip) = to_ip(&data) { vec.push(ip) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::addrinfo`) to a reference type (`&mut libc::addrinfo`) [INFO] [stderr] --> src/lib.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | ptr = transmute(ptr.ai_next); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *ptr.ai_next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | forget(list); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *mut libc::addrinfo [INFO] [stderr] --> src/lib.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | forget(list); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `system_dns`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match x { [INFO] [stderr] 52 | | &IpAddr::V4(_) => AF_INET, [INFO] [stderr] 53 | | &IpAddr::V6(_) => AF_INET6, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *x { [INFO] [stderr] 52 | IpAddr::V4(_) => AF_INET, [INFO] [stderr] 53 | IpAddr::V6(_) => AF_INET6, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:105:35 [INFO] [stderr] | [INFO] [stderr] 105 | let host: *const c_char = transmute(host.as_bytes().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `host.as_bytes().as_ptr() as *const i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | forget(hints); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type libc::addrinfo [INFO] [stderr] --> src/lib.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | forget(hints); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | forget(host); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *const i8 [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | forget(host); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | forget(list); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *mut libc::addrinfo [INFO] [stderr] --> src/lib.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | forget(list); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | let tptr: *const sockaddr = transmute(ptr.ai_addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.ai_addr as *const libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | forget(mutptr); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *mut i8 [INFO] [stderr] --> src/lib.rs:143:16 [INFO] [stderr] | [INFO] [stderr] 143 | forget(mutptr); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | forget(tptr); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *const libc::sockaddr [INFO] [stderr] --> src/lib.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | forget(tptr); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a reference instead of an owned value. Forgetting a reference does nothing. [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | forget(ptr); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_ref)] on by default [INFO] [stderr] note: argument has type &mut libc::addrinfo [INFO] [stderr] --> src/lib.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | forget(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / match to_ip(&data) { [INFO] [stderr] 153 | | Option::Some(ip) => vec.push(ip), [INFO] [stderr] 154 | | _ => {} [INFO] [stderr] 155 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Option::Some(ip) = to_ip(&data) { vec.push(ip) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::addrinfo`) to a reference type (`&mut libc::addrinfo`) [INFO] [stderr] --> src/lib.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | ptr = transmute(ptr.ai_next); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *ptr.ai_next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | forget(list); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type *mut libc::addrinfo [INFO] [stderr] --> src/lib.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | forget(list); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:173:16 [INFO] [stderr] | [INFO] [stderr] 173 | if x.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `system_dns`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0f141cc08ecf8bce53e8e0f0855fad2412fe85ef5532ee41e82bb25d7fe17abf"` [INFO] running `"docker" "rm" "-f" "0f141cc08ecf8bce53e8e0f0855fad2412fe85ef5532ee41e82bb25d7fe17abf"` [INFO] [stdout] 0f141cc08ecf8bce53e8e0f0855fad2412fe85ef5532ee41e82bb25d7fe17abf