[INFO] crate syslog_rfc5424 0.6.0 is already in cache [INFO] extracting crate syslog_rfc5424 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/syslog_rfc5424/0.6.0 [INFO] extracting crate syslog_rfc5424 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syslog_rfc5424/0.6.0 [INFO] validating manifest of syslog_rfc5424-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syslog_rfc5424-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syslog_rfc5424-0.6.0 [INFO] finished frobbing syslog_rfc5424-0.6.0 [INFO] frobbed toml for syslog_rfc5424-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/syslog_rfc5424/0.6.0/Cargo.toml [INFO] started frobbing syslog_rfc5424-0.6.0 [INFO] finished frobbing syslog_rfc5424-0.6.0 [INFO] frobbed toml for syslog_rfc5424-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syslog_rfc5424/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syslog_rfc5424-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/syslog_rfc5424/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ba4da53c9ade324a097eb2752cb39c30548a0f212932e73d8d566c1cfb4606a [INFO] running `"docker" "start" "-a" "5ba4da53c9ade324a097eb2752cb39c30548a0f212932e73d8d566c1cfb4606a"` [INFO] [stderr] Checking timeit v0.1.2 [INFO] [stderr] Checking syslog_rfc5424 v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/message.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/message.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:245:40 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(msg.timestamp, Some(482196050)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `482_196_050` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:412:40 [INFO] [stderr] | [INFO] [stderr] 412 | assert_eq!(msg.timestamp, Some(1420070400)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_420_070_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:418:40 [INFO] [stderr] | [INFO] [stderr] 418 | assert_eq!(msg.timestamp, Some(1420070400)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_420_070_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:424:40 [INFO] [stderr] | [INFO] [stderr] 424 | assert_eq!(msg.timestamp, Some(1420106400)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_420_106_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:436:40 [INFO] [stderr] | [INFO] [stderr] 436 | assert_eq!(msg.timestamp, Some(1452816241)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_452_816_241` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:451:40 [INFO] [stderr] | [INFO] [stderr] 451 | assert_eq!(msg.timestamp, Some(1452816241)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_452_816_241` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:493:40 [INFO] [stderr] | [INFO] [stderr] 493 | assert_eq!(msg.timestamp, Some(482196050)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `482_196_050` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:494:46 [INFO] [stderr] | [INFO] [stderr] 494 | assert_eq!(msg.timestamp_nanos, Some(520000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `520_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:498:40 [INFO] [stderr] | [INFO] [stderr] 498 | assert_eq!(msg.timestamp, Some(482167250)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `482_167_250` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:499:46 [INFO] [stderr] | [INFO] [stderr] 499 | assert_eq!(msg.timestamp_nanos, Some(520000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `520_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:503:40 [INFO] [stderr] | [INFO] [stderr] 503 | assert_eq!(msg.timestamp, Some(482167250)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `482_167_250` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:508:40 [INFO] [stderr] | [INFO] [stderr] 508 | assert_eq!(msg.timestamp, Some(1061676855)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_061_676_855` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:524:40 [INFO] [stderr] | [INFO] [stderr] 524 | assert_eq!(msg.timestamp, Some(1526286181)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_526_286_181` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:525:46 [INFO] [stderr] | [INFO] [stderr] 525 | assert_eq!(msg.timestamp_nanos, Some(520000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `520_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/message.rs:237:50 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!("baz", s.get("foo").and_then(|foo| foo.get("bar")).unwrap()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/message.rs:238:50 [INFO] [stderr] | [INFO] [stderr] 238 | assert_eq!("bar", s.get("foo").and_then(|foo| foo.get("baz")).unwrap()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/message.rs:239:50 [INFO] [stderr] | [INFO] [stderr] 239 | assert_eq!("baz", s.get("faa").and_then(|foo| foo.get("bar")).unwrap()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> examples/bench.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn main() { [INFO] [stderr] 29 | | println!("Parsing the smallest possible message:"); [INFO] [stderr] 30 | | let simple_message = "<1>1 - - - - - -"; [INFO] [stderr] 31 | | timeit!({ [INFO] [stderr] ... | [INFO] [stderr] 50 | | bench_serde(); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | assert!(msg.sd.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.sd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.96s [INFO] running `"docker" "inspect" "5ba4da53c9ade324a097eb2752cb39c30548a0f212932e73d8d566c1cfb4606a"` [INFO] running `"docker" "rm" "-f" "5ba4da53c9ade324a097eb2752cb39c30548a0f212932e73d8d566c1cfb4606a"` [INFO] [stdout] 5ba4da53c9ade324a097eb2752cb39c30548a0f212932e73d8d566c1cfb4606a