[INFO] crate sysfs-class 0.1.1 is already in cache [INFO] extracting crate sysfs-class 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/sysfs-class/0.1.1 [INFO] extracting crate sysfs-class 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sysfs-class/0.1.1 [INFO] validating manifest of sysfs-class-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sysfs-class-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sysfs-class-0.1.1 [INFO] finished frobbing sysfs-class-0.1.1 [INFO] frobbed toml for sysfs-class-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/sysfs-class/0.1.1/Cargo.toml [INFO] started frobbing sysfs-class-0.1.1 [INFO] finished frobbing sysfs-class-0.1.1 [INFO] frobbed toml for sysfs-class-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sysfs-class/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sysfs-class-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sysfs-class/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eba9bf074929db43b8969bc63be02e691483a02f18b19d15b18bfc3f75f18ebf [INFO] running `"docker" "start" "-a" "eba9bf074929db43b8969bc63be02e691483a02f18b19d15b18bfc3f75f18ebf"` [INFO] [stderr] Checking sysfs-class v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/sys_class.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | let parent = path.parent().ok_or(Error::new( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 41 | | ErrorKind::InvalidInput, [INFO] [stderr] 42 | | format!("{}: does not have parent", path.display()) [INFO] [stderr] 43 | | ))?; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | let parent = path.parent().ok_or_else(|| Error::new( [INFO] [stderr] 41 | ErrorKind::InvalidInput, [INFO] [stderr] 42 | format!("{}: does not have parent", path.display()) [INFO] [stderr] 43 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/sys_class.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | let parent = path.parent().ok_or(Error::new( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 41 | | ErrorKind::InvalidInput, [INFO] [stderr] 42 | | format!("{}: does not have parent", path.display()) [INFO] [stderr] 43 | | ))?; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | let parent = path.parent().ok_or_else(|| Error::new( [INFO] [stderr] 41 | ErrorKind::InvalidInput, [INFO] [stderr] 42 | format!("{}: does not have parent", path.display()) [INFO] [stderr] 43 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "eba9bf074929db43b8969bc63be02e691483a02f18b19d15b18bfc3f75f18ebf"` [INFO] running `"docker" "rm" "-f" "eba9bf074929db43b8969bc63be02e691483a02f18b19d15b18bfc3f75f18ebf"` [INFO] [stdout] eba9bf074929db43b8969bc63be02e691483a02f18b19d15b18bfc3f75f18ebf