[INFO] crate sys-info 0.5.6 is already in cache [INFO] extracting crate sys-info 0.5.6 into work/ex/clippy-test-run/sources/stable/reg/sys-info/0.5.6 [INFO] extracting crate sys-info 0.5.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sys-info/0.5.6 [INFO] validating manifest of sys-info-0.5.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sys-info-0.5.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sys-info-0.5.6 [INFO] finished frobbing sys-info-0.5.6 [INFO] frobbed toml for sys-info-0.5.6 written to work/ex/clippy-test-run/sources/stable/reg/sys-info/0.5.6/Cargo.toml [INFO] started frobbing sys-info-0.5.6 [INFO] finished frobbing sys-info-0.5.6 [INFO] frobbed toml for sys-info-0.5.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sys-info/0.5.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sys-info-0.5.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sys-info/0.5.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f796aa5e6343a4cba36f7548edc26962b6c317bb5415ee0325c30d678e231f9 [INFO] running `"docker" "start" "-a" "0f796aa5e6343a4cba36f7548edc26962b6c317bb5415ee0325c30d678e231f9"` [INFO] [stderr] Compiling sys-info v0.5.6 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::mem::size_of_val` [INFO] [stderr] --> lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use std::mem::size_of_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ptr::null_mut` [INFO] [stderr] --> lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use std::ptr::null_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `MAC_CTL_KERN` [INFO] [stderr] --> lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | static MAC_CTL_KERN: libc::c_int = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `MAC_KERN_BOOTTIME` [INFO] [stderr] --> lib.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | static MAC_KERN_BOOTTIME: libc::c_int = 21; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem::size_of_val` [INFO] [stderr] --> lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use std::mem::size_of_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ptr::null_mut` [INFO] [stderr] --> lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use std::ptr::null_mut; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / match find_cpu_mhz { [INFO] [stderr] 184 | | None => find_cpu_mhz = s.split('\n').find(|line| line.starts_with("BogoMIPS")), [INFO] [stderr] 185 | | _ => {} [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ help: try this: `if let None = find_cpu_mhz { find_cpu_mhz = s.split('\n').find(|line| line.starts_with("BogoMIPS")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `MAC_CTL_KERN` [INFO] [stderr] --> lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | static MAC_CTL_KERN: libc::c_int = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `MAC_KERN_BOOTTIME` [INFO] [stderr] --> lib.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | static MAC_KERN_BOOTTIME: libc::c_int = 21; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / match find_cpu_mhz { [INFO] [stderr] 184 | | None => find_cpu_mhz = s.split('\n').find(|line| line.starts_with("BogoMIPS")), [INFO] [stderr] 185 | | _ => {} [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ help: try this: `if let None = find_cpu_mhz { find_cpu_mhz = s.split('\n').find(|line| line.starts_with("BogoMIPS")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib.rs:346:17 [INFO] [stderr] | [INFO] [stderr] 346 | assert!(typ.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!typ.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | assert!(release.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!release.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | assert!(host.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!host.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.97s [INFO] running `"docker" "inspect" "0f796aa5e6343a4cba36f7548edc26962b6c317bb5415ee0325c30d678e231f9"` [INFO] running `"docker" "rm" "-f" "0f796aa5e6343a4cba36f7548edc26962b6c317bb5415ee0325c30d678e231f9"` [INFO] [stdout] 0f796aa5e6343a4cba36f7548edc26962b6c317bb5415ee0325c30d678e231f9