[INFO] crate syntex_fmt_macros 0.5.0 is already in cache [INFO] extracting crate syntex_fmt_macros 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/syntex_fmt_macros/0.5.0 [INFO] extracting crate syntex_fmt_macros 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syntex_fmt_macros/0.5.0 [INFO] validating manifest of syntex_fmt_macros-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syntex_fmt_macros-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syntex_fmt_macros-0.5.0 [INFO] finished frobbing syntex_fmt_macros-0.5.0 [INFO] frobbed toml for syntex_fmt_macros-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/syntex_fmt_macros/0.5.0/Cargo.toml [INFO] started frobbing syntex_fmt_macros-0.5.0 [INFO] finished frobbing syntex_fmt_macros-0.5.0 [INFO] frobbed toml for syntex_fmt_macros-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syntex_fmt_macros/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syntex_fmt_macros-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/syntex_fmt_macros/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 99c28a6013fcdfe8078fc5dababcc47521b09dcf7fd10e9678b697ad42740939 [INFO] running `"docker" "start" "-a" "99c28a6013fcdfe8078fc5dababcc47521b09dcf7fd10e9678b697ad42740939"` [INFO] [stderr] Checking syntex_fmt_macros v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:351:9 [INFO] [stderr] | [INFO] [stderr] 351 | return spec; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `spec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | return Some(cur); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(cur)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | let mut end; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:351:9 [INFO] [stderr] | [INFO] [stderr] 351 | return spec; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `spec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | return Some(cur); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(cur)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:448:9 [INFO] [stderr] | [INFO] [stderr] 448 | / return FormatSpec { [INFO] [stderr] 449 | | fill: None, [INFO] [stderr] 450 | | align: AlignUnknown, [INFO] [stderr] 451 | | flags: 0, [INFO] [stderr] ... | [INFO] [stderr] 454 | | ty: "", [INFO] [stderr] 455 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 448 | FormatSpec { [INFO] [stderr] 449 | fill: None, [INFO] [stderr] 450 | align: AlignUnknown, [INFO] [stderr] 451 | flags: 0, [INFO] [stderr] 452 | precision: CountImplied, [INFO] [stderr] 453 | width: CountImplied, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | / match self.cur.clone().next() { [INFO] [stderr] 292 | | Some((_, c)) => { [INFO] [stderr] 293 | | match self.cur.clone().skip(1).next() { [INFO] [stderr] 294 | | Some((_, '>')) | Some((_, '<')) | Some((_, '^')) => { [INFO] [stderr] ... | [INFO] [stderr] 301 | | None => {} [INFO] [stderr] 302 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 291 | if let Some((_, c)) = self.cur.clone().next() { [INFO] [stderr] 292 | match self.cur.clone().skip(1).next() { [INFO] [stderr] 293 | Some((_, '>')) | Some((_, '<')) | Some((_, '^')) => { [INFO] [stderr] 294 | spec.fill = Some(c); [INFO] [stderr] 295 | self.cur.next(); [INFO] [stderr] 296 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:293:23 [INFO] [stderr] | [INFO] [stderr] 293 | match self.cur.clone().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:415:9 [INFO] [stderr] | [INFO] [stderr] 415 | / loop { [INFO] [stderr] 416 | | match self.cur.clone().next() { [INFO] [stderr] 417 | | Some((_, c)) => { [INFO] [stderr] 418 | | match c.to_digit(10) { [INFO] [stderr] ... | [INFO] [stderr] 428 | | } [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((_, c)) = self.cur.clone().next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | let mut end; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | / match self.cur.clone().next() { [INFO] [stderr] 292 | | Some((_, c)) => { [INFO] [stderr] 293 | | match self.cur.clone().skip(1).next() { [INFO] [stderr] 294 | | Some((_, '>')) | Some((_, '<')) | Some((_, '^')) => { [INFO] [stderr] ... | [INFO] [stderr] 301 | | None => {} [INFO] [stderr] 302 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 291 | if let Some((_, c)) = self.cur.clone().next() { [INFO] [stderr] 292 | match self.cur.clone().skip(1).next() { [INFO] [stderr] 293 | Some((_, '>')) | Some((_, '<')) | Some((_, '^')) => { [INFO] [stderr] 294 | spec.fill = Some(c); [INFO] [stderr] 295 | self.cur.next(); [INFO] [stderr] 296 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:293:23 [INFO] [stderr] | [INFO] [stderr] 293 | match self.cur.clone().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:415:9 [INFO] [stderr] | [INFO] [stderr] 415 | / loop { [INFO] [stderr] 416 | | match self.cur.clone().next() { [INFO] [stderr] 417 | | Some((_, c)) => { [INFO] [stderr] 418 | | match c.to_digit(10) { [INFO] [stderr] ... | [INFO] [stderr] 428 | | } [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((_, c)) = self.cur.clone().next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "99c28a6013fcdfe8078fc5dababcc47521b09dcf7fd10e9678b697ad42740939"` [INFO] running `"docker" "rm" "-f" "99c28a6013fcdfe8078fc5dababcc47521b09dcf7fd10e9678b697ad42740939"` [INFO] [stdout] 99c28a6013fcdfe8078fc5dababcc47521b09dcf7fd10e9678b697ad42740939