[INFO] crate syntex 0.58.1 is already in cache [INFO] extracting crate syntex 0.58.1 into work/ex/clippy-test-run/sources/stable/reg/syntex/0.58.1 [INFO] extracting crate syntex 0.58.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syntex/0.58.1 [INFO] validating manifest of syntex-0.58.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syntex-0.58.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syntex-0.58.1 [INFO] removed path dependency syntex_errors from syntex-0.58.1 [INFO] removed path dependency syntex_syntax from syntex-0.58.1 [INFO] finished frobbing syntex-0.58.1 [INFO] frobbed toml for syntex-0.58.1 written to work/ex/clippy-test-run/sources/stable/reg/syntex/0.58.1/Cargo.toml [INFO] started frobbing syntex-0.58.1 [INFO] removed path dependency syntex_errors from syntex-0.58.1 [INFO] removed path dependency syntex_syntax from syntex-0.58.1 [INFO] finished frobbing syntex-0.58.1 [INFO] frobbed toml for syntex-0.58.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syntex/0.58.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syntex-0.58.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/syntex/0.58.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c105e681c4980ab8d9899e5e22506369fb42a76b17154518af98c2f917da9cfa [INFO] running `"docker" "start" "-a" "c105e681c4980ab8d9899e5e22506369fb42a76b17154518af98c2f917da9cfa"` [INFO] [stderr] Checking syntex v0.58.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolver.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolver.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stack.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | const STACK_ENV_VAR: &'static str = "RUST_MIN_STACK"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stack.rs:7:21 [INFO] [stderr] | [INFO] [stderr] 7 | const EXTRA_STACK: &'static str = "16777216"; // 16 MB [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `registry::Registry` [INFO] [stderr] --> src/registry.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Registry { [INFO] [stderr] 40 | | Registry { [INFO] [stderr] 41 | | syntax_exts: Vec::new(), [INFO] [stderr] 42 | | pre_expansion_passes: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/resolver.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | self.extensions.get(&name).map(|ext| ext.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.extensions.get(&name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stack.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | const STACK_ENV_VAR: &'static str = "RUST_MIN_STACK"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stack.rs:7:21 [INFO] [stderr] | [INFO] [stderr] 7 | const EXTRA_STACK: &'static str = "16777216"; // 16 MB [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `registry::Registry` [INFO] [stderr] --> src/registry.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Registry { [INFO] [stderr] 40 | | Registry { [INFO] [stderr] 41 | | syntax_exts: Vec::new(), [INFO] [stderr] 42 | | pre_expansion_passes: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/resolver.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | self.extensions.get(&name).map(|ext| ext.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.extensions.get(&name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.61s [INFO] running `"docker" "inspect" "c105e681c4980ab8d9899e5e22506369fb42a76b17154518af98c2f917da9cfa"` [INFO] running `"docker" "rm" "-f" "c105e681c4980ab8d9899e5e22506369fb42a76b17154518af98c2f917da9cfa"` [INFO] [stdout] c105e681c4980ab8d9899e5e22506369fb42a76b17154518af98c2f917da9cfa