[INFO] crate synstructure 0.10.1 is already in cache [INFO] extracting crate synstructure 0.10.1 into work/ex/clippy-test-run/sources/stable/reg/synstructure/0.10.1 [INFO] extracting crate synstructure 0.10.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/synstructure/0.10.1 [INFO] validating manifest of synstructure-0.10.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of synstructure-0.10.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing synstructure-0.10.1 [INFO] finished frobbing synstructure-0.10.1 [INFO] frobbed toml for synstructure-0.10.1 written to work/ex/clippy-test-run/sources/stable/reg/synstructure/0.10.1/Cargo.toml [INFO] started frobbing synstructure-0.10.1 [INFO] finished frobbing synstructure-0.10.1 [INFO] frobbed toml for synstructure-0.10.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/synstructure/0.10.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting synstructure-0.10.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/synstructure/0.10.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d897240f6cfb9043a759fe14a38c350f3987ab35f16f52a231f7dfe433d76734 [INFO] running `"docker" "start" "-a" "d897240f6cfb9043a759fe14a38c350f3987ab35f16f52a231f7dfe433d76734"` [INFO] [stderr] Checking synstructure_test_traits v0.1.0 [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking synstructure v0.10.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | generics: generics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `generics` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:494:29 [INFO] [stderr] | [INFO] [stderr] 494 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:495:29 [INFO] [stderr] | [INFO] [stderr] 495 | generics: generics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `generics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:505:13 [INFO] [stderr] | [INFO] [stderr] 505 | bindings: bindings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bindings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:507:13 [INFO] [stderr] | [INFO] [stderr] 507 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | generics: generics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `generics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1028:13 [INFO] [stderr] | [INFO] [stderr] 1028 | variants: variants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1030:13 [INFO] [stderr] | [INFO] [stderr] 1030 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/lib.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | generics: generics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `generics` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:494:29 [INFO] [stderr] | [INFO] [stderr] 494 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:495:29 [INFO] [stderr] | [INFO] [stderr] 495 | generics: generics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `generics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:505:13 [INFO] [stderr] | [INFO] [stderr] 505 | bindings: bindings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bindings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:507:13 [INFO] [stderr] | [INFO] [stderr] 507 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | generics: generics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `generics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1028:13 [INFO] [stderr] | [INFO] [stderr] 1028 | variants: variants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1030:13 [INFO] [stderr] | [INFO] [stderr] 1030 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | / match *param { [INFO] [stderr] 253 | | GenericParam::Type(ref tparam) => tys.push(&tparam.ident), [INFO] [stderr] 254 | | _ => {} [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____________^ help: try this: `if let GenericParam::Type(ref tparam) = *param { tys.push(&tparam.ident) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/lib.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / 'outer: for p in &from.params { [INFO] [stderr] 277 | | for op in &into.params { [INFO] [stderr] 278 | | match (op, p) { [INFO] [stderr] 279 | | (&GenericParam::Type(ref otp), &GenericParam::Type(ref tp)) => { [INFO] [stderr] ... | [INFO] [stderr] 295 | | into.params.push(p.clone()); [INFO] [stderr] 296 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:436:18 [INFO] [stderr] | [INFO] [stderr] 436 | fn get_ty_params<'a>(field: &Field, generics: &Generics) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:567:25 [INFO] [stderr] | [INFO] [stderr] 567 | assert!(self.bindings.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.bindings.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:1928:47 [INFO] [stderr] | [INFO] [stderr] 1928 | let bound = syn::parse2::(path.into()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2147:24 [INFO] [stderr] | [INFO] [stderr] 2147 | if let Ok(_) = parse_prefix(&input.fork()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2148 | | break; [INFO] [stderr] 2149 | | } [INFO] [stderr] | |_________________- help: try this: `if parse_prefix(&input.fork()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:2269:18 [INFO] [stderr] | [INFO] [stderr] 2269 | match &s[i..i + 1] { [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:2274:25 [INFO] [stderr] | [INFO] [stderr] 2274 | res.push_str(&s[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | / match *param { [INFO] [stderr] 253 | | GenericParam::Type(ref tparam) => tys.push(&tparam.ident), [INFO] [stderr] 254 | | _ => {} [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____________^ help: try this: `if let GenericParam::Type(ref tparam) = *param { tys.push(&tparam.ident) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/lib.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / 'outer: for p in &from.params { [INFO] [stderr] 277 | | for op in &into.params { [INFO] [stderr] 278 | | match (op, p) { [INFO] [stderr] 279 | | (&GenericParam::Type(ref otp), &GenericParam::Type(ref tp)) => { [INFO] [stderr] ... | [INFO] [stderr] 295 | | into.params.push(p.clone()); [INFO] [stderr] 296 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:436:18 [INFO] [stderr] | [INFO] [stderr] 436 | fn get_ty_params<'a>(field: &Field, generics: &Generics) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:567:25 [INFO] [stderr] | [INFO] [stderr] 567 | assert!(self.bindings.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.bindings.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:1928:47 [INFO] [stderr] | [INFO] [stderr] 1928 | let bound = syn::parse2::(path.into()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2147:24 [INFO] [stderr] | [INFO] [stderr] 2147 | if let Ok(_) = parse_prefix(&input.fork()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2148 | | break; [INFO] [stderr] 2149 | | } [INFO] [stderr] | |_________________- help: try this: `if parse_prefix(&input.fork()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:2269:18 [INFO] [stderr] | [INFO] [stderr] 2269 | match &s[i..i + 1] { [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:2274:25 [INFO] [stderr] | [INFO] [stderr] 2274 | res.push_str(&s[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.51s [INFO] running `"docker" "inspect" "d897240f6cfb9043a759fe14a38c350f3987ab35f16f52a231f7dfe433d76734"` [INFO] running `"docker" "rm" "-f" "d897240f6cfb9043a759fe14a38c350f3987ab35f16f52a231f7dfe433d76734"` [INFO] [stdout] d897240f6cfb9043a759fe14a38c350f3987ab35f16f52a231f7dfe433d76734