[INFO] crate syndication 0.4.0 is already in cache [INFO] extracting crate syndication 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/syndication/0.4.0 [INFO] extracting crate syndication 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syndication/0.4.0 [INFO] validating manifest of syndication-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syndication-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syndication-0.4.0 [INFO] finished frobbing syndication-0.4.0 [INFO] frobbed toml for syndication-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/syndication/0.4.0/Cargo.toml [INFO] started frobbing syndication-0.4.0 [INFO] finished frobbing syndication-0.4.0 [INFO] frobbed toml for syndication-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syndication/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syndication-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/syndication/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2dfc68cf4e66b514f8f8726c2a3758ac04d60d79346b07e5a4dbfb34cc27b09 [INFO] running `"docker" "start" "-a" "f2dfc68cf4e66b514f8f8726c2a3758ac04d60d79346b07e5a4dbfb34cc27b09"` [INFO] [stderr] Checking RustyXML v0.1.1 [INFO] [stderr] Checking rss v0.3.1 [INFO] [stderr] Checking atom_syndication v0.3.0 [INFO] [stderr] Checking syndication v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | RSS(rss::Channel), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 8 | RSS(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match self { [INFO] [stderr] 28 | | &Feed::Atom(ref atom_feed) => atom_feed.to_string(), [INFO] [stderr] 29 | | &Feed::RSS(ref rss_channel) => rss::Rss(rss_channel.clone()).to_string(), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | Feed::Atom(ref atom_feed) => atom_feed.to_string(), [INFO] [stderr] 29 | Feed::RSS(ref rss_channel) => rss::Rss(rss_channel.clone()).to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | RSS(rss::Channel), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 8 | RSS(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match self { [INFO] [stderr] 28 | | &Feed::Atom(ref atom_feed) => atom_feed.to_string(), [INFO] [stderr] 29 | | &Feed::RSS(ref rss_channel) => rss::Rss(rss_channel.clone()).to_string(), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | Feed::Atom(ref atom_feed) => atom_feed.to_string(), [INFO] [stderr] 29 | Feed::RSS(ref rss_channel) => rss::Rss(rss_channel.clone()).to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | assert!(feed.to_string().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!feed.to_string().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | assert!(rss.to_string().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rss.to_string().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/read.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match atom_str.parse::().unwrap() { [INFO] [stderr] 21 | | Feed::Atom(atom_feed) => println!("Atom feed first entry: {:?}", atom_feed.entries[0].title), [INFO] [stderr] 22 | | _ => {} [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Feed::Atom(atom_feed) = atom_str.parse::().unwrap() { println!("Atom feed first entry: {:?}", atom_feed.entries[0].title) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/read.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / match rss_str.parse::().unwrap() { [INFO] [stderr] 42 | | Feed::RSS(rss_feed) => println!("RSS feed first entry: {:?}", [INFO] [stderr] 43 | | rss_feed.items[0].title), [INFO] [stderr] 44 | | _ => {} [INFO] [stderr] 45 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Feed::RSS(rss_feed) = rss_str.parse::().unwrap() { println!("RSS feed first entry: {:?}", [INFO] [stderr] 42 | rss_feed.items[0].title) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.50s [INFO] running `"docker" "inspect" "f2dfc68cf4e66b514f8f8726c2a3758ac04d60d79346b07e5a4dbfb34cc27b09"` [INFO] running `"docker" "rm" "-f" "f2dfc68cf4e66b514f8f8726c2a3758ac04d60d79346b07e5a4dbfb34cc27b09"` [INFO] [stdout] f2dfc68cf4e66b514f8f8726c2a3758ac04d60d79346b07e5a4dbfb34cc27b09