[INFO] crate synctree 0.1.3 is already in cache [INFO] extracting crate synctree 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/synctree/0.1.3 [INFO] extracting crate synctree 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/synctree/0.1.3 [INFO] validating manifest of synctree-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of synctree-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing synctree-0.1.3 [INFO] finished frobbing synctree-0.1.3 [INFO] frobbed toml for synctree-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/synctree/0.1.3/Cargo.toml [INFO] started frobbing synctree-0.1.3 [INFO] finished frobbing synctree-0.1.3 [INFO] frobbed toml for synctree-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/synctree/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting synctree-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/synctree/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f461c70588a26a5567f0470d0651ffba05a9213d12ff92d137f6e94e90ce412 [INFO] running `"docker" "start" "-a" "1f461c70588a26a5567f0470d0651ffba05a9213d12ff92d137f6e94e90ce412"` [INFO] [stderr] Checking onevec v0.1.0 [INFO] [stderr] Checking synctree v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `arena::Arena` [INFO] [stderr] --> src/arena.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Arena { [INFO] [stderr] 46 | | Arena { [INFO] [stderr] 47 | | elements: OneVec::new(), [INFO] [stderr] 48 | | vacant: FnvHashSet::default(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | impl Default for arena::Arena { [INFO] [stderr] 42 | fn default() -> Self { [INFO] [stderr] 43 | Self::new() [INFO] [stderr] 44 | } [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/arena.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn iter<'a>(&'a self) -> Iter<'a, T> { [INFO] [stderr] 140 | | Iter { [INFO] [stderr] 141 | | arena: &self, [INFO] [stderr] 142 | | first: Id(unsafe { NonZeroUsize::new_unchecked(1) }), [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/arena.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn iter_mut<'a>(&'a mut self) -> IterMut<'a, T> { [INFO] [stderr] 150 | | let last = Id(unsafe { NonZeroUsize::new_unchecked(self.elements.len() + 1) }); [INFO] [stderr] 151 | | let len = self.len(); [INFO] [stderr] 152 | | [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/arena.rs:216:76 [INFO] [stderr] | [INFO] [stderr] 216 | if let Some(id) = NonZeroUsize::new(self.last.0.get() - 1).map(|v| Id(v)) { [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/arena.rs:275:76 [INFO] [stderr] | [INFO] [stderr] 275 | if let Some(id) = NonZeroUsize::new(self.last.0.get() - 1).map(|v| Id(v)) { [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `node_arena::NodeArena` [INFO] [stderr] --> src/node_arena.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> NodeArena { [INFO] [stderr] 20 | | NodeArena { [INFO] [stderr] 21 | | inner: Arc::new(RwLock::new(Arena::new())), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for node_arena::NodeArena { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | parent [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 99 | let root = tree!(arena, 1 => [,]); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | let parent = $crate::Node::new($key, $arena); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 99 | let root = tree!(arena, 1 => [,]); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/macros.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `arena::Arena` [INFO] [stderr] --> src/arena.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Arena { [INFO] [stderr] 46 | | Arena { [INFO] [stderr] 47 | | elements: OneVec::new(), [INFO] [stderr] 48 | | vacant: FnvHashSet::default(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | impl Default for arena::Arena { [INFO] [stderr] 42 | fn default() -> Self { [INFO] [stderr] 43 | Self::new() [INFO] [stderr] 44 | } [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/arena.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn iter<'a>(&'a self) -> Iter<'a, T> { [INFO] [stderr] 140 | | Iter { [INFO] [stderr] 141 | | arena: &self, [INFO] [stderr] 142 | | first: Id(unsafe { NonZeroUsize::new_unchecked(1) }), [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/arena.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn iter_mut<'a>(&'a mut self) -> IterMut<'a, T> { [INFO] [stderr] 150 | | let last = Id(unsafe { NonZeroUsize::new_unchecked(self.elements.len() + 1) }); [INFO] [stderr] 151 | | let len = self.len(); [INFO] [stderr] 152 | | [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/arena.rs:216:76 [INFO] [stderr] | [INFO] [stderr] 216 | if let Some(id) = NonZeroUsize::new(self.last.0.get() - 1).map(|v| Id(v)) { [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/arena.rs:275:76 [INFO] [stderr] | [INFO] [stderr] 275 | if let Some(id) = NonZeroUsize::new(self.last.0.get() - 1).map(|v| Id(v)) { [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `node_arena::NodeArena` [INFO] [stderr] --> src/node_arena.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> NodeArena { [INFO] [stderr] 20 | | NodeArena { [INFO] [stderr] 21 | | inner: Arc::new(RwLock::new(Arena::new())), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for node_arena::NodeArena { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:592:13 [INFO] [stderr] | [INFO] [stderr] 592 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | let ref arena = NodeArena::new(); [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let arena = &NodeArena::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.65s [INFO] running `"docker" "inspect" "1f461c70588a26a5567f0470d0651ffba05a9213d12ff92d137f6e94e90ce412"` [INFO] running `"docker" "rm" "-f" "1f461c70588a26a5567f0470d0651ffba05a9213d12ff92d137f6e94e90ce412"` [INFO] [stdout] 1f461c70588a26a5567f0470d0651ffba05a9213d12ff92d137f6e94e90ce412