[INFO] crate syncterm 0.0.1 is already in cache
[INFO] extracting crate syncterm 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/syncterm/0.0.1
[INFO] extracting crate syncterm 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syncterm/0.0.1
[INFO] validating manifest of syncterm-0.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of syncterm-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing syncterm-0.0.1
[INFO] finished frobbing syncterm-0.0.1
[INFO] frobbed toml for syncterm-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/syncterm/0.0.1/Cargo.toml
[INFO] started frobbing syncterm-0.0.1
[INFO] finished frobbing syncterm-0.0.1
[INFO] frobbed toml for syncterm-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syncterm/0.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting syncterm-0.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/syncterm/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fd357ec0253e093d70c0be4b6e2d65636a44650d2c0638812d402f7aa8b8b70b
[INFO] running `"docker" "start" "-a" "fd357ec0253e093d70c0be4b6e2d65636a44650d2c0638812d402f7aa8b8b70b"`
[INFO] [stderr]     Checking tui v0.2.3
[INFO] [stderr]     Checking syncterm v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/client.rs:136:27
[INFO] [stderr]     |
[INFO] [stderr] 136 |       thread::spawn(move || loop {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 137 | |         match read_connection.read_response() {
[INFO] [stderr] 138 | |             Ok(resp) => response_tx.send(resp),
[INFO] [stderr] 139 | |             Err(_) => break,
[INFO] [stderr] 140 | |         };
[INFO] [stderr] 141 | |     });
[INFO] [stderr]     | |_____^ help: try: `while let Ok(resp) = read_connection.read_response() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/server.rs:128:26
[INFO] [stderr]     |
[INFO] [stderr] 128 |     let alive = Arc::new(Mutex::new(true));
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/server.rs:173:34
[INFO] [stderr]     |
[INFO] [stderr] 173 |     while let Some(maybe_line) = lines.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^ help: try: `for maybe_line in lines { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/server.rs:220:9
[INFO] [stderr]     |
[INFO] [stderr] 220 | /         match stream.write(&ser) {
[INFO] [stderr] 221 | |             Err(e) => {
[INFO] [stderr] 222 | |                 panic!(
[INFO] [stderr] 223 | |                     "Stream in {:?} failed to write with error {}",
[INFO] [stderr] ...   |
[INFO] [stderr] 228 | |             Ok(_) => {}
[INFO] [stderr] 229 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 220 |         if let Err(e) = stream.write(&ser) {
[INFO] [stderr] 221 |     panic!(
[INFO] [stderr] 222 |         "Stream in {:?} failed to write with error {}",
[INFO] [stderr] 223 |         thread::current().id(),
[INFO] [stderr] 224 |         e
[INFO] [stderr] 225 |     );
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/client.rs:136:27
[INFO] [stderr]     |
[INFO] [stderr] 136 |       thread::spawn(move || loop {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 137 | |         match read_connection.read_response() {
[INFO] [stderr] 138 | |             Ok(resp) => response_tx.send(resp),
[INFO] [stderr] 139 | |             Err(_) => break,
[INFO] [stderr] 140 | |         };
[INFO] [stderr] 141 | |     });
[INFO] [stderr]     | |_____^ help: try: `while let Ok(resp) = read_connection.read_response() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/server.rs:128:26
[INFO] [stderr]     |
[INFO] [stderr] 128 |     let alive = Arc::new(Mutex::new(true));
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/server.rs:173:34
[INFO] [stderr]     |
[INFO] [stderr] 173 |     while let Some(maybe_line) = lines.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^ help: try: `for maybe_line in lines { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/server.rs:220:9
[INFO] [stderr]     |
[INFO] [stderr] 220 | /         match stream.write(&ser) {
[INFO] [stderr] 221 | |             Err(e) => {
[INFO] [stderr] 222 | |                 panic!(
[INFO] [stderr] 223 | |                     "Stream in {:?} failed to write with error {}",
[INFO] [stderr] ...   |
[INFO] [stderr] 228 | |             Ok(_) => {}
[INFO] [stderr] 229 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 220 |         if let Err(e) = stream.write(&ser) {
[INFO] [stderr] 221 |     panic!(
[INFO] [stderr] 222 |         "Stream in {:?} failed to write with error {}",
[INFO] [stderr] 223 |         thread::current().id(),
[INFO] [stderr] 224 |         e
[INFO] [stderr] 225 |     );
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> examples/git_helper/client.rs:4:21
[INFO] [stderr]   |
[INFO] [stderr] 4 | const TIME_FORMAT: &'static str = "%H:%M:%S";
[INFO] [stderr]   |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> examples/git_helper/client.rs:172:52
[INFO] [stderr]     |
[INFO] [stderr] 172 |                                     if m.ends_with("\n") { "" } else { "\n" }
[INFO] [stderr]     |                                                    ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> examples/git_helper/server.rs:47:31
[INFO] [stderr]    |
[INFO] [stderr] 47 |         while let Some(arg) = words.next() {
[INFO] [stderr]    |                               ^^^^^^^^^^^^ help: try: `for arg in words { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.53s
[INFO] running `"docker" "inspect" "fd357ec0253e093d70c0be4b6e2d65636a44650d2c0638812d402f7aa8b8b70b"`
[INFO] running `"docker" "rm" "-f" "fd357ec0253e093d70c0be4b6e2d65636a44650d2c0638812d402f7aa8b8b70b"`
[INFO] [stdout] fd357ec0253e093d70c0be4b6e2d65636a44650d2c0638812d402f7aa8b8b70b