[INFO] crate syn_query 0.2.0 is already in cache [INFO] extracting crate syn_query 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/syn_query/0.2.0 [INFO] extracting crate syn_query 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syn_query/0.2.0 [INFO] validating manifest of syn_query-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syn_query-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syn_query-0.2.0 [INFO] finished frobbing syn_query-0.2.0 [INFO] frobbed toml for syn_query-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/syn_query/0.2.0/Cargo.toml [INFO] started frobbing syn_query-0.2.0 [INFO] finished frobbing syn_query-0.2.0 [INFO] frobbed toml for syn_query-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/syn_query/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syn_query-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/syn_query/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb77e96a3dbdfa6528fe6d4ae4037a5bea0b3271f9a5bc349e07decd3425615e [INFO] running `"docker" "start" "-a" "fb77e96a3dbdfa6528fe6d4ae4037a5bea0b3271f9a5bc349e07decd3425615e"` [INFO] [stderr] Checking quote v0.6.11 [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking syn_query v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | deep: deep, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | deep: deep, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `QueryResult` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | / impl QueryResult { [INFO] [stderr] 108 | | pub fn query(&self) -> QueryResult { [INFO] [stderr] 109 | | use std::collections::BTreeSet; [INFO] [stderr] 110 | | let mut result = BTreeSet::new(); [INFO] [stderr] ... | [INFO] [stderr] 373 | | } [INFO] [stderr] 374 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `QueryResult` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | / impl QueryResult { [INFO] [stderr] 108 | | pub fn query(&self) -> QueryResult { [INFO] [stderr] 109 | | use std::collections::BTreeSet; [INFO] [stderr] 110 | | let mut result = BTreeSet::new(); [INFO] [stderr] ... | [INFO] [stderr] 373 | | } [INFO] [stderr] 374 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:314:23 [INFO] [stderr] | [INFO] [stderr] 314 | match map.get(&path).map(|item| *item) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `map.get(&path).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:314:23 [INFO] [stderr] | [INFO] [stderr] 314 | match map.get(&path).map(|item| *item) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `map.get(&path).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.25s [INFO] running `"docker" "inspect" "fb77e96a3dbdfa6528fe6d4ae4037a5bea0b3271f9a5bc349e07decd3425615e"` [INFO] running `"docker" "rm" "-f" "fb77e96a3dbdfa6528fe6d4ae4037a5bea0b3271f9a5bc349e07decd3425615e"` [INFO] [stdout] fb77e96a3dbdfa6528fe6d4ae4037a5bea0b3271f9a5bc349e07decd3425615e