[INFO] crate symmetric-interaction-calculus 0.1.8 is already in cache [INFO] extracting crate symmetric-interaction-calculus 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/symmetric-interaction-calculus/0.1.8 [INFO] extracting crate symmetric-interaction-calculus 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/symmetric-interaction-calculus/0.1.8 [INFO] validating manifest of symmetric-interaction-calculus-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of symmetric-interaction-calculus-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing symmetric-interaction-calculus-0.1.8 [INFO] finished frobbing symmetric-interaction-calculus-0.1.8 [INFO] frobbed toml for symmetric-interaction-calculus-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/symmetric-interaction-calculus/0.1.8/Cargo.toml [INFO] started frobbing symmetric-interaction-calculus-0.1.8 [INFO] finished frobbing symmetric-interaction-calculus-0.1.8 [INFO] frobbed toml for symmetric-interaction-calculus-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/symmetric-interaction-calculus/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting symmetric-interaction-calculus-0.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/symmetric-interaction-calculus/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65afd8d6bbb0b64c19c2d1d0d9cff24e35b3b61437cf28ab8ae26feda307fb37 [INFO] running `"docker" "start" "-a" "65afd8d6bbb0b64c19c2d1d0d9cff24e35b3b61437cf28ab8ae26feda307fb37"` [INFO] [stderr] Checking symmetric-interaction-calculus v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/term.rs:452:39 [INFO] [stderr] | [INFO] [stderr] 452 | let mut lam = Lam{nam: nam, bod: Box::new(bod)}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/net.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let b = new_node(net, t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | nam: nam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | nam: nam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | nam: nam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/term.rs:452:39 [INFO] [stderr] | [INFO] [stderr] 452 | let mut lam = Lam{nam: nam, bod: Box::new(bod)}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/net.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let b = new_node(net, t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | nam: nam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | nam: nam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | nam: nam, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `nam` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/term.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return name; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/term.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/term.rs:281:5 [INFO] [stderr] | [INFO] [stderr] 281 | return code; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/term.rs:453:21 [INFO] [stderr] | [INFO] [stderr] 453 | lam [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/term.rs:452:35 [INFO] [stderr] | [INFO] [stderr] 452 | let mut lam = Lam{nam: nam, bod: Box::new(bod)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extra.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | o_lam [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extra.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | let o_lam = Term::Lam{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 130 | | nam: nam, [INFO] [stderr] 131 | | bod: Box::new(i_lam) [INFO] [stderr] 132 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extra.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | o_lam [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extra.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let o_lam = Term::Lam{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 150 | | nam: b"-".to_vec(), [INFO] [stderr] 151 | | bod: Box::new(i_lam) [INFO] [stderr] 152 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extra.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | o_lam [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extra.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | let o_lam = Term::Lam{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 167 | | nam: b"-".to_vec(), [INFO] [stderr] 168 | | bod: Box::new(i_lam) [INFO] [stderr] 169 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/extra.rs:183:39 [INFO] [stderr] | [INFO] [stderr] 183 | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Lam { bod: ref e_bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/term.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return name; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/term.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/term.rs:281:5 [INFO] [stderr] | [INFO] [stderr] 281 | return code; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/term.rs:453:21 [INFO] [stderr] | [INFO] [stderr] 453 | lam [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/term.rs:452:35 [INFO] [stderr] | [INFO] [stderr] 452 | let mut lam = Lam{nam: nam, bod: Box::new(bod)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extra.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | o_lam [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extra.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | let o_lam = Term::Lam{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 130 | | nam: nam, [INFO] [stderr] 131 | | bod: Box::new(i_lam) [INFO] [stderr] 132 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extra.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | o_lam [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extra.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let o_lam = Term::Lam{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 150 | | nam: b"-".to_vec(), [INFO] [stderr] 151 | | bod: Box::new(i_lam) [INFO] [stderr] 152 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extra.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | o_lam [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extra.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | let o_lam = Term::Lam{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 167 | | nam: b"-".to_vec(), [INFO] [stderr] 168 | | bod: Box::new(i_lam) [INFO] [stderr] 169 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/extra.rs:183:39 [INFO] [stderr] | [INFO] [stderr] 183 | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Lam { bod: ref e_bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/term.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | idx = idx - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/term.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | idx = idx / 26; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `idx /= 26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn name_idx(name : &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Chr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/term.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | idx = (idx * 26) + (*byte as u32 - 97) + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:79:26 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &Vec, idx : u32, var : &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &[u8], idx : u32, var : &Vec) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `space.clone()` to [INFO] [stderr] | [INFO] [stderr] 81 | let mut nam = space.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:79:53 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &Vec, idx : u32, var : &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &Vec, idx : u32, var : &[u8]) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `var.clone()` to [INFO] [stderr] | [INFO] [stderr] 88 | var.to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn copy(space : &Vec, idx : u32, term : &Term) -> Term { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/term.rs:210:48 [INFO] [stderr] | [INFO] [stderr] 210 | let mut name = nam.clone().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 210 | let mut name = &(*nam).clone().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 210 | let mut name = &[u8]::clone(nam).to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/term.rs:229:1 [INFO] [stderr] | [INFO] [stderr] 229 | / pub fn from_string<'a>(code : &'a Str) -> Term { [INFO] [stderr] 230 | | let mut ctx = Vec::new(); [INFO] [stderr] 231 | | let mut idx = 0; [INFO] [stderr] 232 | | parse_term(code, &mut ctx, &mut idx, 0).1 [INFO] [stderr] 233 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/term.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match term { [INFO] [stderr] 239 | | &Lam{ref nam, ref bod} => { [INFO] [stderr] 240 | | code.extend_from_slice(b"#"); [INFO] [stderr] 241 | | code.append(&mut nam.clone()); [INFO] [stderr] ... | [INFO] [stderr] 276 | | }, [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | match *term { [INFO] [stderr] 239 | Lam{ref nam, ref bod} => { [INFO] [stderr] 240 | code.extend_from_slice(b"#"); [INFO] [stderr] 241 | code.append(&mut nam.clone()); [INFO] [stderr] 242 | code.extend_from_slice(b" "); [INFO] [stderr] 243 | stringify_term(code, &bod); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/term.rs:389:14 [INFO] [stderr] | [INFO] [stderr] 389 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 389 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/term.rs:427:9 [INFO] [stderr] | [INFO] [stderr] 427 | / if !var_name.contains_key(&var_port) { [INFO] [stderr] 428 | | let nam = new_name(var_name.len() as u32 + 1); [INFO] [stderr] 429 | | var_name.insert(var_port, nam.clone()); [INFO] [stderr] 430 | | } [INFO] [stderr] | |_________^ help: consider using: `var_name.entry(var_port)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/term.rs:507:11 [INFO] [stderr] | [INFO] [stderr] 507 | while lets_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lets_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/net.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | while next > 0 || warp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!warp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/extra.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match term { [INFO] [stderr] 14 | | &App{ref fun, ref arg} => { [INFO] [stderr] 15 | | let app = new_node(net, CON); [INFO] [stderr] 16 | | let fun = encode(net, label, scope, fun); [INFO] [stderr] ... | [INFO] [stderr] 55 | | _ => panic!("Invalid λ-term.") [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *term { [INFO] [stderr] 14 | App{ref fun, ref arg} => { [INFO] [stderr] 15 | let app = new_node(net, CON); [INFO] [stderr] 16 | let fun = encode(net, label, scope, fun); [INFO] [stderr] 17 | link(net, port(app, 0), fun); [INFO] [stderr] 18 | let arg = encode(net, label, scope, arg); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `scope`. [INFO] [stderr] --> src/extra.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | for i in 0..scope.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 35 | for in &scope { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/extra.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | match if s.len() > 0 { s[0] } else { b' ' } { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match t { [INFO] [stderr] 179 | | Term::Lam{nam: ref o_nam, bod: ref o_bod} => { [INFO] [stderr] 180 | | match **o_bod { [INFO] [stderr] 181 | | Term::Lam{nam: ref i_nam, bod: ref i_bod} => { [INFO] [stderr] ... | [INFO] [stderr] 208 | | _ => {} [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let Term::Lam{nam: ref o_nam, bod: ref o_bod} = t { [INFO] [stderr] 179 | match **o_bod { [INFO] [stderr] 180 | Term::Lam{nam: ref i_nam, bod: ref i_bod} => { [INFO] [stderr] 181 | match **i_bod { [INFO] [stderr] 182 | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] 183 | match **e_bod { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | / match **o_bod { [INFO] [stderr] 181 | | Term::Lam{nam: ref i_nam, bod: ref i_bod} => { [INFO] [stderr] 182 | | match **i_bod { [INFO] [stderr] 183 | | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] ... | [INFO] [stderr] 205 | | _ => {} [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | if let Term::Lam{nam: ref i_nam, bod: ref i_bod} = **o_bod { [INFO] [stderr] 181 | match **i_bod { [INFO] [stderr] 182 | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] 183 | match **e_bod { [INFO] [stderr] 184 | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] 185 | match **app_fun { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | / match **i_bod { [INFO] [stderr] 183 | | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] 184 | | match **e_bod { [INFO] [stderr] 185 | | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => {} [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Term::Lam{nam: _, bod: ref e_bod} = **i_bod { [INFO] [stderr] 183 | match **e_bod { [INFO] [stderr] 184 | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] 185 | match **app_fun { [INFO] [stderr] 186 | Term::Var{nam: ref var_nam} => { [INFO] [stderr] 187 | if var_nam == o_nam { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:184:33 [INFO] [stderr] | [INFO] [stderr] 184 | / match **e_bod { [INFO] [stderr] 185 | | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] 186 | | match **app_fun { [INFO] [stderr] 187 | | Term::Var{nam: ref var_nam} => { [INFO] [stderr] ... | [INFO] [stderr] 199 | | _ => {} [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | if let Term::App{fun: ref app_fun, arg: ref app_arg} = **e_bod { [INFO] [stderr] 185 | match **app_fun { [INFO] [stderr] 186 | Term::Var{nam: ref var_nam} => { [INFO] [stderr] 187 | if var_nam == o_nam { [INFO] [stderr] 188 | v.extend_from_slice(b"0"); [INFO] [stderr] 189 | format_binary_output(app_arg, v); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:186:41 [INFO] [stderr] | [INFO] [stderr] 186 | / match **app_fun { [INFO] [stderr] 187 | | Term::Var{nam: ref var_nam} => { [INFO] [stderr] 188 | | if var_nam == o_nam { [INFO] [stderr] 189 | | v.extend_from_slice(b"0"); [INFO] [stderr] ... | [INFO] [stderr] 196 | | _ => {} [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 186 | if let Term::Var{nam: ref var_nam} = **app_fun { [INFO] [stderr] 187 | if var_nam == o_nam { [INFO] [stderr] 188 | v.extend_from_slice(b"0"); [INFO] [stderr] 189 | format_binary_output(app_arg, v); [INFO] [stderr] 190 | } else if var_nam == i_nam { [INFO] [stderr] 191 | v.extend_from_slice(b"1"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s`. [INFO] [stderr] --> src/extra.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 219 | for in s.iter().take(8) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/extra.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | c = c / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `c /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/extra.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0..a.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 249 | for in &a { [INFO] [stderr] | ^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `symmetric-interaction-calculus`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/term.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | idx = idx - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/term.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | idx = idx / 26; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `idx /= 26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn name_idx(name : &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Chr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/term.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | idx = (idx * 26) + (*byte as u32 - 97) + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:79:26 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &Vec, idx : u32, var : &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &[u8], idx : u32, var : &Vec) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `space.clone()` to [INFO] [stderr] | [INFO] [stderr] 81 | let mut nam = space.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:79:53 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &Vec, idx : u32, var : &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 79 | pub fn namespace(space : &Vec, idx : u32, var : &[u8]) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `var.clone()` to [INFO] [stderr] | [INFO] [stderr] 88 | var.to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/term.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn copy(space : &Vec, idx : u32, term : &Term) -> Term { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/term.rs:210:48 [INFO] [stderr] | [INFO] [stderr] 210 | let mut name = nam.clone().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 210 | let mut name = &(*nam).clone().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 210 | let mut name = &[u8]::clone(nam).to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/term.rs:229:1 [INFO] [stderr] | [INFO] [stderr] 229 | / pub fn from_string<'a>(code : &'a Str) -> Term { [INFO] [stderr] 230 | | let mut ctx = Vec::new(); [INFO] [stderr] 231 | | let mut idx = 0; [INFO] [stderr] 232 | | parse_term(code, &mut ctx, &mut idx, 0).1 [INFO] [stderr] 233 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/term.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match term { [INFO] [stderr] 239 | | &Lam{ref nam, ref bod} => { [INFO] [stderr] 240 | | code.extend_from_slice(b"#"); [INFO] [stderr] 241 | | code.append(&mut nam.clone()); [INFO] [stderr] ... | [INFO] [stderr] 276 | | }, [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | match *term { [INFO] [stderr] 239 | Lam{ref nam, ref bod} => { [INFO] [stderr] 240 | code.extend_from_slice(b"#"); [INFO] [stderr] 241 | code.append(&mut nam.clone()); [INFO] [stderr] 242 | code.extend_from_slice(b" "); [INFO] [stderr] 243 | stringify_term(code, &bod); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/term.rs:389:14 [INFO] [stderr] | [INFO] [stderr] 389 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 389 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/term.rs:427:9 [INFO] [stderr] | [INFO] [stderr] 427 | / if !var_name.contains_key(&var_port) { [INFO] [stderr] 428 | | let nam = new_name(var_name.len() as u32 + 1); [INFO] [stderr] 429 | | var_name.insert(var_port, nam.clone()); [INFO] [stderr] 430 | | } [INFO] [stderr] | |_________^ help: consider using: `var_name.entry(var_port)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/term.rs:507:11 [INFO] [stderr] | [INFO] [stderr] 507 | while lets_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lets_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/net.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | while next > 0 || warp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!warp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/extra.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match term { [INFO] [stderr] 14 | | &App{ref fun, ref arg} => { [INFO] [stderr] 15 | | let app = new_node(net, CON); [INFO] [stderr] 16 | | let fun = encode(net, label, scope, fun); [INFO] [stderr] ... | [INFO] [stderr] 55 | | _ => panic!("Invalid λ-term.") [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *term { [INFO] [stderr] 14 | App{ref fun, ref arg} => { [INFO] [stderr] 15 | let app = new_node(net, CON); [INFO] [stderr] 16 | let fun = encode(net, label, scope, fun); [INFO] [stderr] 17 | link(net, port(app, 0), fun); [INFO] [stderr] 18 | let arg = encode(net, label, scope, arg); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `scope`. [INFO] [stderr] --> src/extra.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | for i in 0..scope.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 35 | for in &scope { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/extra.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | match if s.len() > 0 { s[0] } else { b' ' } { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match t { [INFO] [stderr] 179 | | Term::Lam{nam: ref o_nam, bod: ref o_bod} => { [INFO] [stderr] 180 | | match **o_bod { [INFO] [stderr] 181 | | Term::Lam{nam: ref i_nam, bod: ref i_bod} => { [INFO] [stderr] ... | [INFO] [stderr] 208 | | _ => {} [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let Term::Lam{nam: ref o_nam, bod: ref o_bod} = t { [INFO] [stderr] 179 | match **o_bod { [INFO] [stderr] 180 | Term::Lam{nam: ref i_nam, bod: ref i_bod} => { [INFO] [stderr] 181 | match **i_bod { [INFO] [stderr] 182 | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] 183 | match **e_bod { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | / match **o_bod { [INFO] [stderr] 181 | | Term::Lam{nam: ref i_nam, bod: ref i_bod} => { [INFO] [stderr] 182 | | match **i_bod { [INFO] [stderr] 183 | | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] ... | [INFO] [stderr] 205 | | _ => {} [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | if let Term::Lam{nam: ref i_nam, bod: ref i_bod} = **o_bod { [INFO] [stderr] 181 | match **i_bod { [INFO] [stderr] 182 | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] 183 | match **e_bod { [INFO] [stderr] 184 | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] 185 | match **app_fun { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | / match **i_bod { [INFO] [stderr] 183 | | Term::Lam{nam: _, bod: ref e_bod} => { [INFO] [stderr] 184 | | match **e_bod { [INFO] [stderr] 185 | | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => {} [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Term::Lam{nam: _, bod: ref e_bod} = **i_bod { [INFO] [stderr] 183 | match **e_bod { [INFO] [stderr] 184 | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] 185 | match **app_fun { [INFO] [stderr] 186 | Term::Var{nam: ref var_nam} => { [INFO] [stderr] 187 | if var_nam == o_nam { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:184:33 [INFO] [stderr] | [INFO] [stderr] 184 | / match **e_bod { [INFO] [stderr] 185 | | Term::App{fun: ref app_fun, arg: ref app_arg} => { [INFO] [stderr] 186 | | match **app_fun { [INFO] [stderr] 187 | | Term::Var{nam: ref var_nam} => { [INFO] [stderr] ... | [INFO] [stderr] 199 | | _ => {} [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | if let Term::App{fun: ref app_fun, arg: ref app_arg} = **e_bod { [INFO] [stderr] 185 | match **app_fun { [INFO] [stderr] 186 | Term::Var{nam: ref var_nam} => { [INFO] [stderr] 187 | if var_nam == o_nam { [INFO] [stderr] 188 | v.extend_from_slice(b"0"); [INFO] [stderr] 189 | format_binary_output(app_arg, v); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/extra.rs:186:41 [INFO] [stderr] | [INFO] [stderr] 186 | / match **app_fun { [INFO] [stderr] 187 | | Term::Var{nam: ref var_nam} => { [INFO] [stderr] 188 | | if var_nam == o_nam { [INFO] [stderr] 189 | | v.extend_from_slice(b"0"); [INFO] [stderr] ... | [INFO] [stderr] 196 | | _ => {} [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 186 | if let Term::Var{nam: ref var_nam} = **app_fun { [INFO] [stderr] 187 | if var_nam == o_nam { [INFO] [stderr] 188 | v.extend_from_slice(b"0"); [INFO] [stderr] 189 | format_binary_output(app_arg, v); [INFO] [stderr] 190 | } else if var_nam == i_nam { [INFO] [stderr] 191 | v.extend_from_slice(b"1"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s`. [INFO] [stderr] --> src/extra.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 219 | for in s.iter().take(8) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/extra.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | c = c / 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `c /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/extra.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0..a.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 249 | for in &a { [INFO] [stderr] | ^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `symmetric-interaction-calculus`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "65afd8d6bbb0b64c19c2d1d0d9cff24e35b3b61437cf28ab8ae26feda307fb37"` [INFO] running `"docker" "rm" "-f" "65afd8d6bbb0b64c19c2d1d0d9cff24e35b3b61437cf28ab8ae26feda307fb37"` [INFO] [stdout] 65afd8d6bbb0b64c19c2d1d0d9cff24e35b3b61437cf28ab8ae26feda307fb37