[INFO] crate symbolic_polynomials 0.1.0 is already in cache [INFO] extracting crate symbolic_polynomials 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/symbolic_polynomials/0.1.0 [INFO] extracting crate symbolic_polynomials 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/symbolic_polynomials/0.1.0 [INFO] validating manifest of symbolic_polynomials-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of symbolic_polynomials-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing symbolic_polynomials-0.1.0 [INFO] finished frobbing symbolic_polynomials-0.1.0 [INFO] frobbed toml for symbolic_polynomials-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/symbolic_polynomials/0.1.0/Cargo.toml [INFO] started frobbing symbolic_polynomials-0.1.0 [INFO] finished frobbing symbolic_polynomials-0.1.0 [INFO] frobbed toml for symbolic_polynomials-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/symbolic_polynomials/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting symbolic_polynomials-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/symbolic_polynomials/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa904d06903e4572687ac9706446a360ebcf77e2d830a318db6c4138d4deaadd [INFO] running `"docker" "start" "-a" "aa904d06903e4572687ac9706446a360ebcf77e2d830a318db6c4138d4deaadd"` [INFO] [stderr] Checking symbolic_polynomials v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/functions.rs:253:25 [INFO] [stderr] | [INFO] [stderr] 253 | let a = &p.monomials[0].coefficient; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/functions.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | let n = &p.monomials[0].powers[0].1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/functions.rs:253:25 [INFO] [stderr] | [INFO] [stderr] 253 | let a = &p.monomials[0].coefficient; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/functions.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | let n = &p.monomials[0].powers[0].1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/functions.rs:111:72 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn reduce_monomial(monomial: &Monomial, values: &HashMap) -> Monomial [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 111 | pub fn reduce_monomial(monomial: &Monomial, values: &HashMap) -> Monomial [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/functions.rs:218:67 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn reduce(polynomial: &Polynomial, values: &HashMap) -> Polynomial [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 218 | pub fn reduce(polynomial: &Polynomial, values: &HashMap) -> Polynomial [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/functions.rs:229:48 [INFO] [stderr] | [INFO] [stderr] 229 | pub fn deduce_values(original_values: &Vec<(Polynomial, C)>) -> Result, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 229 | pub fn deduce_values(original_values: &[(Polynomial, C)]) -> Result, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `original_values.clone()` to [INFO] [stderr] | [INFO] [stderr] 231 | let mut implicit_values = original_values.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/monomial.rs:157:43 [INFO] [stderr] | [INFO] [stderr] 157 | self.coefficient.partial_cmp(&other.clone().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `other.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `MulAssign` impl [INFO] [stderr] --> src/monomial.rs:236:93 [INFO] [stderr] | [INFO] [stderr] 236 | self.powers[i1] = (self.powers[i1].0.clone(), self.powers[i1].1.clone() + rhs.powers[i2].1.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/functions.rs:111:72 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn reduce_monomial(monomial: &Monomial, values: &HashMap) -> Monomial [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 111 | pub fn reduce_monomial(monomial: &Monomial, values: &HashMap) -> Monomial [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/functions.rs:218:67 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn reduce(polynomial: &Polynomial, values: &HashMap) -> Polynomial [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 218 | pub fn reduce(polynomial: &Polynomial, values: &HashMap) -> Polynomial [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/functions.rs:229:48 [INFO] [stderr] | [INFO] [stderr] 229 | pub fn deduce_values(original_values: &Vec<(Polynomial, C)>) -> Result, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 229 | pub fn deduce_values(original_values: &[(Polynomial, C)]) -> Result, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `original_values.clone()` to [INFO] [stderr] | [INFO] [stderr] 231 | let mut implicit_values = original_values.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/monomial.rs:157:43 [INFO] [stderr] | [INFO] [stderr] 157 | self.coefficient.partial_cmp(&other.clone().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `other.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `MulAssign` impl [INFO] [stderr] --> src/monomial.rs:236:93 [INFO] [stderr] | [INFO] [stderr] 236 | self.powers[i1] = (self.powers[i1].0.clone(), self.powers[i1].1.clone() + rhs.powers[i2].1.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `symbolic_polynomials`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `symbolic_polynomials`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "aa904d06903e4572687ac9706446a360ebcf77e2d830a318db6c4138d4deaadd"` [INFO] running `"docker" "rm" "-f" "aa904d06903e4572687ac9706446a360ebcf77e2d830a318db6c4138d4deaadd"` [INFO] [stdout] aa904d06903e4572687ac9706446a360ebcf77e2d830a318db6c4138d4deaadd