[INFO] crate sx1509 0.2.0 is already in cache [INFO] extracting crate sx1509 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/sx1509/0.2.0 [INFO] extracting crate sx1509 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sx1509/0.2.0 [INFO] validating manifest of sx1509-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sx1509-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sx1509-0.2.0 [INFO] finished frobbing sx1509-0.2.0 [INFO] frobbed toml for sx1509-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sx1509/0.2.0/Cargo.toml [INFO] started frobbing sx1509-0.2.0 [INFO] finished frobbing sx1509-0.2.0 [INFO] frobbed toml for sx1509-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sx1509/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sx1509-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sx1509/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 04bec133bcf7b7902300c881165abda767efc0326eb801b903f5090d985253f7 [INFO] running `"docker" "start" "-a" "04bec133bcf7b7902300c881165abda767efc0326eb801b903f5090d985253f7"` [INFO] [stderr] Checking nb v0.1.1 [INFO] [stderr] Checking embedded-hal v0.2.2 [INFO] [stderr] Checking sx1509 v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | i2c: i2c, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `i2c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | i2c: i2c, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `i2c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | / pub fn borrow<'a>(&'a mut self) -> Borrowed<'a, I2C> { [INFO] [stderr] 396 | | Borrowed { [INFO] [stderr] 397 | | state: &mut self.state, [INFO] [stderr] 398 | | i2c: &mut self.i2c, [INFO] [stderr] 399 | | } [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:417:12 [INFO] [stderr] | [INFO] [stderr] 417 | Ok((buf[0] as u16) << 8 | buf[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:417:35 [INFO] [stderr] | [INFO] [stderr] 417 | Ok((buf[0] as u16) << 8 | buf[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | / pub fn borrow<'a>(&'a mut self) -> Borrowed<'a, I2C> { [INFO] [stderr] 396 | | Borrowed { [INFO] [stderr] 397 | | state: &mut self.state, [INFO] [stderr] 398 | | i2c: &mut self.i2c, [INFO] [stderr] 399 | | } [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:417:12 [INFO] [stderr] | [INFO] [stderr] 417 | Ok((buf[0] as u16) << 8 | buf[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:417:35 [INFO] [stderr] | [INFO] [stderr] 417 | Ok((buf[0] as u16) << 8 | buf[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "04bec133bcf7b7902300c881165abda767efc0326eb801b903f5090d985253f7"` [INFO] running `"docker" "rm" "-f" "04bec133bcf7b7902300c881165abda767efc0326eb801b903f5090d985253f7"` [INFO] [stdout] 04bec133bcf7b7902300c881165abda767efc0326eb801b903f5090d985253f7