[INFO] crate swf-parser 0.0.8 is already in cache [INFO] extracting crate swf-parser 0.0.8 into work/ex/clippy-test-run/sources/stable/reg/swf-parser/0.0.8 [INFO] extracting crate swf-parser 0.0.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/swf-parser/0.0.8 [INFO] validating manifest of swf-parser-0.0.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of swf-parser-0.0.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing swf-parser-0.0.8 [INFO] finished frobbing swf-parser-0.0.8 [INFO] frobbed toml for swf-parser-0.0.8 written to work/ex/clippy-test-run/sources/stable/reg/swf-parser/0.0.8/Cargo.toml [INFO] started frobbing swf-parser-0.0.8 [INFO] finished frobbing swf-parser-0.0.8 [INFO] frobbed toml for swf-parser-0.0.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/swf-parser/0.0.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting swf-parser-0.0.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/swf-parser/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb15404aa9572dd5884d9513aba0a0c51fe06d080cff6b152f6569341f5ab78f [INFO] running `"docker" "start" "-a" "fb15404aa9572dd5884d9513aba0a0c51fe06d080cff6b152f6569341f5ab78f"` [INFO] [stderr] Compiling rust-lzma v0.3.0 [INFO] [stderr] Checking swf-fixed v0.1.0 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking avm1-tree v0.0.15 [INFO] [stderr] Checking swf-tree v0.0.18 [INFO] [stderr] Checking swf-parser v0.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/display.rs:274:48 [INFO] [stderr] | [INFO] [stderr] 274 | result.push(ast::ColorStop { ratio: 0, color: color }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/tags.rs:617:5 [INFO] [stderr] | [INFO] [stderr] 617 | sprite_id: sprite_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sprite_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/display.rs:274:48 [INFO] [stderr] | [INFO] [stderr] 274 | result.push(ast::ColorStop { ratio: 0, color: color }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/tags.rs:617:5 [INFO] [stderr] | [INFO] [stderr] 617 | sprite_id: sprite_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sprite_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/image.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | const PNG_IHDR_CHUNK_TYPE: u32 = 0x49484452; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4948_4452` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parsers/image.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return image_data[..start_bytes.len()] == *start_bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `image_data[..start_bytes.len()] == *start_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parsers/tags.rs:711:5 [INFO] [stderr] | [INFO] [stderr] 711 | return Ok((input, input.len() > 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((input, input.len() > 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/state.rs:21:73 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn set_glyph_count(&mut self, font_id: usize, glyph_count: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:431:24 [INFO] [stderr] | [INFO] [stderr] 431 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:431:36 [INFO] [stderr] | [INFO] [stderr] 431 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:435:24 [INFO] [stderr] | [INFO] [stderr] 435 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:435:36 [INFO] [stderr] | [INFO] [stderr] 435 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:439:24 [INFO] [stderr] | [INFO] [stderr] 439 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:439:36 [INFO] [stderr] | [INFO] [stderr] 439 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:443:24 [INFO] [stderr] | [INFO] [stderr] 443 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:443:36 [INFO] [stderr] | [INFO] [stderr] 443 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:447:24 [INFO] [stderr] | [INFO] [stderr] 447 | let input = vec![0b01000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:447:36 [INFO] [stderr] | [INFO] [stderr] 447 | let input = vec![0b01000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:451:24 [INFO] [stderr] | [INFO] [stderr] 451 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:451:36 [INFO] [stderr] | [INFO] [stderr] 451 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:455:24 [INFO] [stderr] | [INFO] [stderr] 455 | let input = vec![0b11000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:455:36 [INFO] [stderr] | [INFO] [stderr] 455 | let input = vec![0b11000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:459:24 [INFO] [stderr] | [INFO] [stderr] 459 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:459:36 [INFO] [stderr] | [INFO] [stderr] 459 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:463:24 [INFO] [stderr] | [INFO] [stderr] 463 | let input = vec![0b01111111, 0b11111110]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:463:36 [INFO] [stderr] | [INFO] [stderr] 463 | let input = vec![0b01111111, 0b11111110]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:467:24 [INFO] [stderr] | [INFO] [stderr] 467 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:467:36 [INFO] [stderr] | [INFO] [stderr] 467 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:471:24 [INFO] [stderr] | [INFO] [stderr] 471 | let input = vec![0b11111111, 0b11111110]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:471:36 [INFO] [stderr] | [INFO] [stderr] 471 | let input = vec![0b11111111, 0b11111110]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:475:24 [INFO] [stderr] | [INFO] [stderr] 475 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:475:36 [INFO] [stderr] | [INFO] [stderr] 475 | let input = vec![0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:479:24 [INFO] [stderr] | [INFO] [stderr] 479 | let input = vec![0b01111111, 0b11111111]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:479:36 [INFO] [stderr] | [INFO] [stderr] 479 | let input = vec![0b01111111, 0b11111111]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:483:24 [INFO] [stderr] | [INFO] [stderr] 483 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:483:36 [INFO] [stderr] | [INFO] [stderr] 483 | let input = vec![0b10000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:487:24 [INFO] [stderr] | [INFO] [stderr] 487 | let input = vec![0b11111111, 0b11111111]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:487:36 [INFO] [stderr] | [INFO] [stderr] 487 | let input = vec![0b11111111, 0b11111111]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:494:22 [INFO] [stderr] | [INFO] [stderr] 494 | let input = vec![0b10101010, 0b11110000, 0b00110011]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:494:34 [INFO] [stderr] | [INFO] [stderr] 494 | let input = vec![0b10101010, 0b11110000, 0b00110011]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:494:46 [INFO] [stderr] | [INFO] [stderr] 494 | let input = vec![0b10101010, 0b11110000, 0b00110011]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:500:22 [INFO] [stderr] | [INFO] [stderr] 500 | let input = vec![0b00000000, 0b00000000, 0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:500:34 [INFO] [stderr] | [INFO] [stderr] 500 | let input = vec![0b00000000, 0b00000000, 0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:500:46 [INFO] [stderr] | [INFO] [stderr] 500 | let input = vec![0b00000000, 0b00000000, 0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:500:58 [INFO] [stderr] | [INFO] [stderr] 500 | let input = vec![0b00000000, 0b00000000, 0b00000000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:24 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:36 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:48 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:60 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:72 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:84 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:511:96 [INFO] [stderr] | [INFO] [stderr] 511 | let input = vec![0b01011000, 0b01111111, 0b00100000, 0b10000000, 0b00111101, 0b00000001, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:515:24 [INFO] [stderr] | [INFO] [stderr] 515 | let input = vec![0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:519:24 [INFO] [stderr] | [INFO] [stderr] 519 | let input = vec![0b00001000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:519:36 [INFO] [stderr] | [INFO] [stderr] 519 | let input = vec![0b00001000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:523:24 [INFO] [stderr] | [INFO] [stderr] 523 | let input = vec![0b00010000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:523:36 [INFO] [stderr] | [INFO] [stderr] 523 | let input = vec![0b00010000, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:527:24 [INFO] [stderr] | [INFO] [stderr] 527 | let input = vec![0b00010010, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:527:36 [INFO] [stderr] | [INFO] [stderr] 527 | let input = vec![0b00010010, 0b00000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:531:24 [INFO] [stderr] | [INFO] [stderr] 531 | let input = vec![0b00010000, 0b10000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:531:36 [INFO] [stderr] | [INFO] [stderr] 531 | let input = vec![0b00010000, 0b10000000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:535:24 [INFO] [stderr] | [INFO] [stderr] 535 | let input = vec![0b00010000, 0b00100000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:535:36 [INFO] [stderr] | [INFO] [stderr] 535 | let input = vec![0b00010000, 0b00100000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:539:24 [INFO] [stderr] | [INFO] [stderr] 539 | let input = vec![0b00010000, 0b00001000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/basic_data_types.rs:539:36 [INFO] [stderr] | [INFO] [stderr] 539 | let input = vec![0b00010000, 0b00001000]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers/image.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | const PNG_IHDR_CHUNK_TYPE: u32 = 0x49484452; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4948_4452` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parsers/image.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return image_data[..start_bytes.len()] == *start_bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `image_data[..start_bytes.len()] == *start_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parsers/tags.rs:711:5 [INFO] [stderr] | [INFO] [stderr] 711 | return Ok((input, input.len() > 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((input, input.len() > 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/state.rs:21:73 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn set_glyph_count(&mut self, font_id: usize, glyph_count: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers/basic_data_types.rs:21:6 [INFO] [stderr] | [INFO] [stderr] 21 | if input_slice.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/basic_data_types.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | result |= ((next_byte as u32) & 0x7f) << (7 * i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | |x| Sfixed16P16::from_epsilons(x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed16P16::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | |x| Sfixed8P8::from_epsilons(x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed8P8::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/basic_data_types.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | let exponent: i32 = ((base & 0x7c00) >> 10) as i32; // 0x7c00: bits 10 to 14 (inclusive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((base & 0x7c00) >> 10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/basic_data_types.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | let fraction: f32 = (base & 0x03ff) as f32; // 0x03ff: bits 0 to 9 (inclusive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base & 0x03ff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | map!(input, parse_le_u16, |x| Ufixed8P8::from_epsilons(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Ufixed8P8::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | map!(input, parse_le_i16, |x| Sfixed8P8::from_epsilons(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed8P8::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | map!(input, parse_le_i32, |x| Sfixed16P16::from_epsilons(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed16P16::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/button.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if current_input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/button.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | state_up: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/button.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | k @ 1..=6 | k @ 13..=19 | k @ 32..=126 => Some(k as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `flags` [INFO] [stderr] --> src/parsers/button.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | key_press: map!(value!((flags >> 0) & 0x7f), key_press_from_id) >> [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/display.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | map!(current_input, parse_be_u16, |x| x as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/display.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | false => map!(parse_be_u16, |x| (x as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:116:41 [INFO] [stderr] | [INFO] [stderr] 116 | 0 => map!(parse_drop_shadow_filter, |f| ast::Filter::DropShadow(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::DropShadow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | 1 => map!(parse_blur_filter, |f| ast::Filter::Blur(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Blur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:118:34 [INFO] [stderr] | [INFO] [stderr] 118 | 2 => map!(parse_glow_filter, |f| ast::Filter::Glow(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Glow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:119:35 [INFO] [stderr] | [INFO] [stderr] 119 | 3 => map!(parse_bevel_filter, |f| ast::Filter::Bevel(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Bevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:120:43 [INFO] [stderr] | [INFO] [stderr] 120 | 4 => map!(parse_gradient_glow_filter, |f| ast::Filter::GradientGlow(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::GradientGlow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | 5 => map!(parse_convolution_filter, |f| ast::Filter::Convolution(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Convolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | 6 => map!(parse_color_matrix_filter, |f| ast::Filter::ColorMatrix(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::ColorMatrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:123:44 [INFO] [stderr] | [INFO] [stderr] 123 | 7 => map!(parse_gradient_bevel_filter, |f| ast::Filter::GradientBevel(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::GradientBevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/display.rs:197:37 [INFO] [stderr] | [INFO] [stderr] 197 | preserve_alpha: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | let frame_height: u16 = ((chunk[5] as u16) << 8) + (chunk[6] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:41:58 [INFO] [stderr] | [INFO] [stderr] 41 | let frame_height: u16 = ((chunk[5] as u16) << 8) + (chunk[6] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | let frame_width: u16 = ((chunk[7] as u16) << 8) + (chunk[8] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:42:57 [INFO] [stderr] | [INFO] [stderr] 42 | let frame_width: u16 = ((chunk[7] as u16) << 8) + (chunk[8] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/morph_shape.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / do_parse!( [INFO] [stderr] 31 | | input, [INFO] [stderr] 32 | | styles: apply!(parse_morph_shape_styles_bits, version) >> [INFO] [stderr] 33 | | start_records: apply!(parse_morph_shape_start_record_string_bits, styles.fill_bits, styles.line_bits, version) >> [INFO] [stderr] ... | [INFO] [stderr] 42 | | }) [INFO] [stderr] 43 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/morph_shape.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / do_parse!( [INFO] [stderr] 64 | | input, [INFO] [stderr] 65 | | fill: bytes!(parse_morph_fill_style_list) >> [INFO] [stderr] 66 | | line: bytes!(apply!(parse_morph_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 74 | | }) [INFO] [stderr] 75 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/morph_shape.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / do_parse!( [INFO] [stderr] 64 | | input, [INFO] [stderr] 65 | | fill: bytes!(parse_morph_fill_style_list) >> [INFO] [stderr] 66 | | line: bytes!(apply!(parse_morph_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 74 | | }) [INFO] [stderr] 75 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parsers/morph_shape.rs:264:128 [INFO] [stderr] | [INFO] [stderr] 264 | pub fn parse_morph_style_change_bits(input: (&[u8], usize), fill_bits: usize, line_bits: usize, version: MorphShapeVersion) -> NomResult<(&[u8], usize), (ast::shape_records::MorphStyleChange, (usize, usize))> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:314:42 [INFO] [stderr] | [INFO] [stderr] 314 | 0x00 => map!(parse_morph_solid_fill, |fill| ast::MorphFillStyle::Solid(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:315:52 [INFO] [stderr] | [INFO] [stderr] 315 | 0x10 => map!(parse_morph_linear_gradient_fill, |fill| ast::MorphFillStyle::LinearGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::LinearGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:316:52 [INFO] [stderr] | [INFO] [stderr] 316 | 0x12 => map!(parse_morph_radial_gradient_fill, |fill| ast::MorphFillStyle::RadialGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::RadialGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:317:51 [INFO] [stderr] | [INFO] [stderr] 317 | 0x13 => map!(parse_morph_focal_gradient_fill, |fill| ast::MorphFillStyle::FocalGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::FocalGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:318:63 [INFO] [stderr] | [INFO] [stderr] 318 | 0x40 => map!(apply!(parse_morph_bitmap_fill, true, true), |fill| ast::MorphFillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:319:64 [INFO] [stderr] | [INFO] [stderr] 319 | 0x41 => map!(apply!(parse_morph_bitmap_fill, false, true), |fill| ast::MorphFillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:320:64 [INFO] [stderr] | [INFO] [stderr] 320 | 0x42 => map!(apply!(parse_morph_bitmap_fill, true, false), |fill| ast::MorphFillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:321:65 [INFO] [stderr] | [INFO] [stderr] 321 | 0x43 => map!(apply!(parse_morph_bitmap_fill, false, false), |fill| ast::MorphFillStyle::Bitmap(fill)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/parsers/morph_shape.rs:430:1 [INFO] [stderr] | [INFO] [stderr] 430 | / pub fn parse_morph_line_style2(input: &[u8]) -> NomResult<&[u8], ast::MorphLineStyle> { [INFO] [stderr] 431 | | fn cap_style_from_id(cap_style_id: u16) -> ast::CapStyle { [INFO] [stderr] 432 | | match cap_style_id { [INFO] [stderr] 433 | | 0 => ast::CapStyle::Round, [INFO] [stderr] ... | [INFO] [stderr] 484 | | ) [INFO] [stderr] 485 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/morph_shape.rs:445:36 [INFO] [stderr] | [INFO] [stderr] 445 | pixel_hinting: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/movie.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | while current_input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/shape.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | / do_parse!( [INFO] [stderr] 70 | | input, [INFO] [stderr] 71 | | fill: bytes!(apply!(parse_fill_style_list, version)) >> [INFO] [stderr] 72 | | line: bytes!(apply!(parse_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 80 | | }) [INFO] [stderr] 81 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/shape.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | / do_parse!( [INFO] [stderr] 70 | | input, [INFO] [stderr] 71 | | fill: bytes!(apply!(parse_fill_style_list, version)) >> [INFO] [stderr] 72 | | line: bytes!(apply!(parse_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 80 | | }) [INFO] [stderr] 81 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parsers/shape.rs:166:117 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn parse_style_change_bits(input: (&[u8], usize), fill_bits: usize, line_bits: usize, version: ShapeVersion) -> NomResult<(&[u8], usize), (ast::shape_records::StyleChange, (usize, usize))> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:224:56 [INFO] [stderr] | [INFO] [stderr] 224 | 0x00 => map!(apply!(parse_solid_fill, with_alpha), |fill| ast::FillStyle::Solid(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:225:66 [INFO] [stderr] | [INFO] [stderr] 225 | 0x10 => map!(apply!(parse_linear_gradient_fill, with_alpha), |fill| ast::FillStyle::LinearGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::LinearGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:226:66 [INFO] [stderr] | [INFO] [stderr] 226 | 0x12 => map!(apply!(parse_radial_gradient_fill, with_alpha), |fill| ast::FillStyle::RadialGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::RadialGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:227:65 [INFO] [stderr] | [INFO] [stderr] 227 | 0x13 => map!(apply!(parse_focal_gradient_fill, with_alpha), |fill| ast::FillStyle::FocalGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::FocalGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:228:57 [INFO] [stderr] | [INFO] [stderr] 228 | 0x40 => map!(apply!(parse_bitmap_fill, true, true), |fill| ast::FillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:229:58 [INFO] [stderr] | [INFO] [stderr] 229 | 0x41 => map!(apply!(parse_bitmap_fill, false, true), |fill| ast::FillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:230:58 [INFO] [stderr] | [INFO] [stderr] 230 | 0x42 => map!(apply!(parse_bitmap_fill, true, false), |fill| ast::FillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:231:59 [INFO] [stderr] | [INFO] [stderr] 231 | 0x43 => map!(apply!(parse_bitmap_fill, false, false), |fill| ast::FillStyle::Bitmap(fill)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/shape.rs:346:36 [INFO] [stderr] | [INFO] [stderr] 346 | pixel_hinting: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:63:54 [INFO] [stderr] | [INFO] [stderr] 63 | 2 => map!(record_data, parse_define_shape, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:64:54 [INFO] [stderr] | [INFO] [stderr] 64 | 4 => map!(record_data, parse_place_object, |t| ast::Tag::PlaceObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::PlaceObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:65:55 [INFO] [stderr] | [INFO] [stderr] 65 | 5 => map!(record_data, parse_remove_object, |t| ast::Tag::RemoveObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::RemoveObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:66:86 [INFO] [stderr] | [INFO] [stderr] 66 | 6 => map!(record_data, apply!(parse_define_bits, state.get_swf_version()), |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:67:93 [INFO] [stderr] | [INFO] [stderr] 67 | 8 => map!(record_data, apply!(parse_define_jpeg_tables, state.get_swf_version()), |t| ast::Tag::DefineJpegTables(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineJpegTables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:68:66 [INFO] [stderr] | [INFO] [stderr] 68 | 9 => map!(record_data, parse_set_background_color_tag, |t| ast::Tag::SetBackgroundColor(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::SetBackgroundColor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:69:54 [INFO] [stderr] | [INFO] [stderr] 69 | 11 => map!(record_data, parse_define_text, |t| ast::Tag::DefineText(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineText` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:71:52 [INFO] [stderr] | [INFO] [stderr] 71 | 12 => map!(record_data, parse_do_action, |t| ast::Tag::DoAction(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DoAction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:72:55 [INFO] [stderr] | [INFO] [stderr] 72 | 14 => map!(record_data, parse_define_sound, |t| ast::Tag::DefineSound(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineSound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:73:63 [INFO] [stderr] | [INFO] [stderr] 73 | 20 => map!(record_data, parse_define_bits_lossless, |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:74:93 [INFO] [stderr] | [INFO] [stderr] 74 | 21 => map!(record_data, apply!(parse_define_bits_jpeg2, state.get_swf_version()), |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:75:56 [INFO] [stderr] | [INFO] [stderr] 75 | 22 => map!(record_data, parse_define_shape2, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:76:94 [INFO] [stderr] | [INFO] [stderr] 76 | 26 => map!(record_data, apply!(parse_place_object2, state.get_swf_version() >= 6), |t| ast::Tag::PlaceObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::PlaceObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:77:57 [INFO] [stderr] | [INFO] [stderr] 77 | 28 => map!(record_data, parse_remove_object2, |t| ast::Tag::RemoveObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::RemoveObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:78:56 [INFO] [stderr] | [INFO] [stderr] 78 | 32 => map!(record_data, parse_define_shape3, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:79:57 [INFO] [stderr] | [INFO] [stderr] 79 | 34 => map!(record_data, parse_define_button2, |t| ast::Tag::DefineButton(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineButton` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:80:93 [INFO] [stderr] | [INFO] [stderr] 80 | 35 => map!(record_data, apply!(parse_define_bits_jpeg3, state.get_swf_version()), |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:81:64 [INFO] [stderr] | [INFO] [stderr] 81 | 36 => map!(record_data, parse_define_bits_lossless2, |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:82:59 [INFO] [stderr] | [INFO] [stderr] 82 | 37 => map!(record_data, parse_define_edit_text, |t| ast::Tag::DefineDynamicText(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineDynamicText` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:83:71 [INFO] [stderr] | [INFO] [stderr] 83 | 39 => map!(record_data, apply!(parse_define_sprite, state), |t| ast::Tag::DefineSprite(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineSprite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:84:54 [INFO] [stderr] | [INFO] [stderr] 84 | 43 => map!(record_data, parse_frame_label, |t| ast::Tag::FrameLabel(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::FrameLabel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:85:61 [INFO] [stderr] | [INFO] [stderr] 85 | 46 => map!(record_data, parse_define_morph_shape, |t| ast::Tag::DefineMorphShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineMorphShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | 56 => map!(record_data, parse_export_assets, |t| ast::Tag::ExportAssets(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::ExportAssets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:87:56 [INFO] [stderr] | [INFO] [stderr] 87 | 57 => map!(record_data, parse_import_assets, |t| ast::Tag::ImportAssets(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::ImportAssets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:88:57 [INFO] [stderr] | [INFO] [stderr] 88 | 59 => map!(record_data, parse_do_init_action, |t| ast::Tag::DoInitAction(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DoInitAction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:89:62 [INFO] [stderr] | [INFO] [stderr] 89 | 69 => map!(record_data, parse_file_attributes_tag, |t| ast::Tag::FileAttributes(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::FileAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:90:94 [INFO] [stderr] | [INFO] [stderr] 90 | 70 => map!(record_data, apply!(parse_place_object3, state.get_swf_version() >= 6), |t| ast::Tag::PlaceObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::PlaceObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:91:57 [INFO] [stderr] | [INFO] [stderr] 91 | 71 => map!(record_data, parse_import_assets2, |t| ast::Tag::ImportAssets(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::ImportAssets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:92:116 [INFO] [stderr] | [INFO] [stderr] 92 | 73 => map!(record_data, apply!(parse_define_font_align_zones, |font_id| state.get_glyph_count(font_id)), |t| ast::Tag::DefineFontAlignZones(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineFontAlignZones` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:93:60 [INFO] [stderr] | [INFO] [stderr] 93 | 74 => map!(record_data, parse_csm_text_settings, |t| ast::Tag::CsmTextSettings(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::CsmTextSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:94:55 [INFO] [stderr] | [INFO] [stderr] 94 | 75 => map!(record_data, parse_define_font3, |t| ast::Tag::DefineFont(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineFont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:95:51 [INFO] [stderr] | [INFO] [stderr] 95 | 77 => map!(record_data, parse_metadata, |t| ast::Tag::Metadata(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:96:56 [INFO] [stderr] | [INFO] [stderr] 96 | 83 => map!(record_data, parse_define_shape4, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:97:62 [INFO] [stderr] | [INFO] [stderr] 97 | 84 => map!(record_data, parse_define_morph_shape2, |t| ast::Tag::DefineMorphShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineMorphShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:98:80 [INFO] [stderr] | [INFO] [stderr] 98 | 86 => map!(record_data, parse_define_scene_and_frame_label_data_tag, |t| ast::Tag::DefineSceneAndFrameLabelData(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineSceneAndFrameLabelData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:99:59 [INFO] [stderr] | [INFO] [stderr] 99 | 88 => map!(record_data, parse_define_font_name, |t| ast::Tag::DefineFontName(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineFontName` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parsers/tags.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / match output_tag { [INFO] [stderr] 107 | | ast::Tag::DefineFont(ref tag) => { [INFO] [stderr] 108 | | match tag.glyphs { [INFO] [stderr] 109 | | Some(ref glyphs) => state.set_glyph_count(tag.id as usize, glyphs.len()), [INFO] [stderr] ... | [INFO] [stderr] 113 | | _ => (), [INFO] [stderr] 114 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let ast::Tag::DefineFont(ref tag) = output_tag { [INFO] [stderr] 107 | match tag.glyphs { [INFO] [stderr] 108 | Some(ref glyphs) => state.set_glyph_count(tag.id as usize, glyphs.len()), [INFO] [stderr] 109 | None => state.set_glyph_count(tag.id as usize, 0), [INFO] [stderr] 110 | }; [INFO] [stderr] 111 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:173:36 [INFO] [stderr] | [INFO] [stderr] 173 | track_as_menu: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 54 [INFO] [stderr] --> src/parsers/tags.rs:272:1 [INFO] [stderr] | [INFO] [stderr] 272 | / pub fn parse_define_edit_text(input: &[u8]) -> IResult<&[u8], ast::tags::DefineDynamicText> { [INFO] [stderr] 273 | | do_parse!( [INFO] [stderr] 274 | | input, [INFO] [stderr] 275 | | id: parse_le_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 335 | | ) [INFO] [stderr] 336 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:294:37 [INFO] [stderr] | [INFO] [stderr] 294 | use_glyph_font: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/tags.rs:306:48 [INFO] [stderr] | [INFO] [stderr] 306 | variable_name: map!(parse_c_string, |x| if x.len() > 0 {Option::Some(x)} else {Option::None}) >> [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/parsers/tags.rs:339:1 [INFO] [stderr] | [INFO] [stderr] 339 | / pub fn parse_define_font3(input: &[u8]) -> IResult<&[u8], ast::tags::DefineFont> { [INFO] [stderr] 340 | | do_parse!( [INFO] [stderr] 341 | | input, [INFO] [stderr] 342 | | id: parse_le_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 387 | | ) [INFO] [stderr] 388 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:344:30 [INFO] [stderr] | [INFO] [stderr] 344 | is_bold: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/tags.rs:372:41 [INFO] [stderr] | [INFO] [stderr] 372 | false => map!(parse_u8, |x| x as u16) [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:452:42 [INFO] [stderr] | [INFO] [stderr] 452 | has_scaling_strokes: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:527:42 [INFO] [stderr] | [INFO] [stderr] 527 | has_scaling_strokes: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:553:41 [INFO] [stderr] | [INFO] [stderr] 553 | sound_type: switch!(value!((flags & (1 << 0)) != 0), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/tags.rs:662:31 [INFO] [stderr] | [INFO] [stderr] 662 | let (input, is_anchor) = if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/tags.rs:711:23 [INFO] [stderr] | [INFO] [stderr] 711 | return Ok((input, input.len() > 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/parsers/tags.rs:756:1 [INFO] [stderr] | [INFO] [stderr] 756 | / pub fn parse_place_object2(input: &[u8], extended_events: bool) -> IResult<&[u8], ast::tags::PlaceObject> { [INFO] [stderr] 757 | | do_parse!( [INFO] [stderr] 758 | | input, [INFO] [stderr] 759 | | flags: parse_u8 >> [INFO] [stderr] ... | [INFO] [stderr] 796 | | ) [INFO] [stderr] 797 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:760:30 [INFO] [stderr] | [INFO] [stderr] 760 | is_move: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 65 [INFO] [stderr] --> src/parsers/tags.rs:799:1 [INFO] [stderr] | [INFO] [stderr] 799 | / pub fn parse_place_object3(input: &[u8], extended_events: bool) -> IResult<&[u8], ast::tags::PlaceObject> { [INFO] [stderr] 800 | | do_parse!( [INFO] [stderr] 801 | | input, [INFO] [stderr] 802 | | flags: parse_le_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 863 | | ) [INFO] [stderr] 864 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:803:30 [INFO] [stderr] | [INFO] [stderr] 803 | is_move: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/text.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | has_x: (flags & (1 << 0)) != 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/text.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | while current_input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/parsers/text.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn parse_text_record(input: &[u8], has_alpha: bool, index_bits: usize, advance_bits: usize) -> IResult<&[u8], ast::text::TextRecord> { [INFO] [stderr] 93 | | do_parse!( [INFO] [stderr] 94 | | input, [INFO] [stderr] 95 | | flags: parse_u8 >> [INFO] [stderr] ... | [INFO] [stderr] 121 | | ) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/text.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | has_offset_y: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/state.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | self.glyph_counts.get(&font_id).map(|count| *count) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.glyph_counts.get(&font_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers/basic_data_types.rs:21:6 [INFO] [stderr] | [INFO] [stderr] 21 | if input_slice.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/basic_data_types.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | result |= ((next_byte as u32) & 0x7f) << (7 * i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | |x| Sfixed16P16::from_epsilons(x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed16P16::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | |x| Sfixed8P8::from_epsilons(x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed8P8::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/basic_data_types.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | let exponent: i32 = ((base & 0x7c00) >> 10) as i32; // 0x7c00: bits 10 to 14 (inclusive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((base & 0x7c00) >> 10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/basic_data_types.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | let fraction: f32 = (base & 0x03ff) as f32; // 0x03ff: bits 0 to 9 (inclusive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base & 0x03ff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | map!(input, parse_le_u16, |x| Ufixed8P8::from_epsilons(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Ufixed8P8::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | map!(input, parse_le_i16, |x| Sfixed8P8::from_epsilons(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed8P8::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/basic_data_types.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | map!(input, parse_le_i32, |x| Sfixed16P16::from_epsilons(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Sfixed16P16::from_epsilons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/button.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if current_input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/button.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | state_up: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/button.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | k @ 1..=6 | k @ 13..=19 | k @ 32..=126 => Some(k as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `flags` [INFO] [stderr] --> src/parsers/button.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | key_press: map!(value!((flags >> 0) & 0x7f), key_press_from_id) >> [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/display.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | map!(current_input, parse_be_u16, |x| x as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/display.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | false => map!(parse_be_u16, |x| (x as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:116:41 [INFO] [stderr] | [INFO] [stderr] 116 | 0 => map!(parse_drop_shadow_filter, |f| ast::Filter::DropShadow(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::DropShadow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | 1 => map!(parse_blur_filter, |f| ast::Filter::Blur(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Blur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:118:34 [INFO] [stderr] | [INFO] [stderr] 118 | 2 => map!(parse_glow_filter, |f| ast::Filter::Glow(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Glow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:119:35 [INFO] [stderr] | [INFO] [stderr] 119 | 3 => map!(parse_bevel_filter, |f| ast::Filter::Bevel(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Bevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:120:43 [INFO] [stderr] | [INFO] [stderr] 120 | 4 => map!(parse_gradient_glow_filter, |f| ast::Filter::GradientGlow(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::GradientGlow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | 5 => map!(parse_convolution_filter, |f| ast::Filter::Convolution(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::Convolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | 6 => map!(parse_color_matrix_filter, |f| ast::Filter::ColorMatrix(f)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::ColorMatrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/display.rs:123:44 [INFO] [stderr] | [INFO] [stderr] 123 | 7 => map!(parse_gradient_bevel_filter, |f| ast::Filter::GradientBevel(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Filter::GradientBevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/display.rs:197:37 [INFO] [stderr] | [INFO] [stderr] 197 | preserve_alpha: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | let frame_height: u16 = ((chunk[5] as u16) << 8) + (chunk[6] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:41:58 [INFO] [stderr] | [INFO] [stderr] 41 | let frame_height: u16 = ((chunk[5] as u16) << 8) + (chunk[6] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | let frame_width: u16 = ((chunk[7] as u16) << 8) + (chunk[8] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/image.rs:42:57 [INFO] [stderr] | [INFO] [stderr] 42 | let frame_width: u16 = ((chunk[7] as u16) << 8) + (chunk[8] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/morph_shape.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / do_parse!( [INFO] [stderr] 31 | | input, [INFO] [stderr] 32 | | styles: apply!(parse_morph_shape_styles_bits, version) >> [INFO] [stderr] 33 | | start_records: apply!(parse_morph_shape_start_record_string_bits, styles.fill_bits, styles.line_bits, version) >> [INFO] [stderr] ... | [INFO] [stderr] 42 | | }) [INFO] [stderr] 43 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/morph_shape.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / do_parse!( [INFO] [stderr] 64 | | input, [INFO] [stderr] 65 | | fill: bytes!(parse_morph_fill_style_list) >> [INFO] [stderr] 66 | | line: bytes!(apply!(parse_morph_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 74 | | }) [INFO] [stderr] 75 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/morph_shape.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / do_parse!( [INFO] [stderr] 64 | | input, [INFO] [stderr] 65 | | fill: bytes!(parse_morph_fill_style_list) >> [INFO] [stderr] 66 | | line: bytes!(apply!(parse_morph_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 74 | | }) [INFO] [stderr] 75 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parsers/morph_shape.rs:264:128 [INFO] [stderr] | [INFO] [stderr] 264 | pub fn parse_morph_style_change_bits(input: (&[u8], usize), fill_bits: usize, line_bits: usize, version: MorphShapeVersion) -> NomResult<(&[u8], usize), (ast::shape_records::MorphStyleChange, (usize, usize))> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:314:42 [INFO] [stderr] | [INFO] [stderr] 314 | 0x00 => map!(parse_morph_solid_fill, |fill| ast::MorphFillStyle::Solid(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:315:52 [INFO] [stderr] | [INFO] [stderr] 315 | 0x10 => map!(parse_morph_linear_gradient_fill, |fill| ast::MorphFillStyle::LinearGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::LinearGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:316:52 [INFO] [stderr] | [INFO] [stderr] 316 | 0x12 => map!(parse_morph_radial_gradient_fill, |fill| ast::MorphFillStyle::RadialGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::RadialGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:317:51 [INFO] [stderr] | [INFO] [stderr] 317 | 0x13 => map!(parse_morph_focal_gradient_fill, |fill| ast::MorphFillStyle::FocalGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::FocalGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:318:63 [INFO] [stderr] | [INFO] [stderr] 318 | 0x40 => map!(apply!(parse_morph_bitmap_fill, true, true), |fill| ast::MorphFillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:319:64 [INFO] [stderr] | [INFO] [stderr] 319 | 0x41 => map!(apply!(parse_morph_bitmap_fill, false, true), |fill| ast::MorphFillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:320:64 [INFO] [stderr] | [INFO] [stderr] 320 | 0x42 => map!(apply!(parse_morph_bitmap_fill, true, false), |fill| ast::MorphFillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/morph_shape.rs:321:65 [INFO] [stderr] | [INFO] [stderr] 321 | 0x43 => map!(apply!(parse_morph_bitmap_fill, false, false), |fill| ast::MorphFillStyle::Bitmap(fill)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::MorphFillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/parsers/morph_shape.rs:430:1 [INFO] [stderr] | [INFO] [stderr] 430 | / pub fn parse_morph_line_style2(input: &[u8]) -> NomResult<&[u8], ast::MorphLineStyle> { [INFO] [stderr] 431 | | fn cap_style_from_id(cap_style_id: u16) -> ast::CapStyle { [INFO] [stderr] 432 | | match cap_style_id { [INFO] [stderr] 433 | | 0 => ast::CapStyle::Round, [INFO] [stderr] ... | [INFO] [stderr] 484 | | ) [INFO] [stderr] 485 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/morph_shape.rs:445:36 [INFO] [stderr] | [INFO] [stderr] 445 | pixel_hinting: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/movie.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | while current_input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/shape.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | / do_parse!( [INFO] [stderr] 70 | | input, [INFO] [stderr] 71 | | fill: bytes!(apply!(parse_fill_style_list, version)) >> [INFO] [stderr] 72 | | line: bytes!(apply!(parse_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 80 | | }) [INFO] [stderr] 81 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsers/shape.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | / do_parse!( [INFO] [stderr] 70 | | input, [INFO] [stderr] 71 | | fill: bytes!(apply!(parse_fill_style_list, version)) >> [INFO] [stderr] 72 | | line: bytes!(apply!(parse_line_style_list, version)) >> [INFO] [stderr] ... | [INFO] [stderr] 80 | | }) [INFO] [stderr] 81 | | ) [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parsers/shape.rs:166:117 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn parse_style_change_bits(input: (&[u8], usize), fill_bits: usize, line_bits: usize, version: ShapeVersion) -> NomResult<(&[u8], usize), (ast::shape_records::StyleChange, (usize, usize))> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:224:56 [INFO] [stderr] | [INFO] [stderr] 224 | 0x00 => map!(apply!(parse_solid_fill, with_alpha), |fill| ast::FillStyle::Solid(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:225:66 [INFO] [stderr] | [INFO] [stderr] 225 | 0x10 => map!(apply!(parse_linear_gradient_fill, with_alpha), |fill| ast::FillStyle::LinearGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::LinearGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:226:66 [INFO] [stderr] | [INFO] [stderr] 226 | 0x12 => map!(apply!(parse_radial_gradient_fill, with_alpha), |fill| ast::FillStyle::RadialGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::RadialGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:227:65 [INFO] [stderr] | [INFO] [stderr] 227 | 0x13 => map!(apply!(parse_focal_gradient_fill, with_alpha), |fill| ast::FillStyle::FocalGradient(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::FocalGradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:228:57 [INFO] [stderr] | [INFO] [stderr] 228 | 0x40 => map!(apply!(parse_bitmap_fill, true, true), |fill| ast::FillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:229:58 [INFO] [stderr] | [INFO] [stderr] 229 | 0x41 => map!(apply!(parse_bitmap_fill, false, true), |fill| ast::FillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:230:58 [INFO] [stderr] | [INFO] [stderr] 230 | 0x42 => map!(apply!(parse_bitmap_fill, true, false), |fill| ast::FillStyle::Bitmap(fill)) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/shape.rs:231:59 [INFO] [stderr] | [INFO] [stderr] 231 | 0x43 => map!(apply!(parse_bitmap_fill, false, false), |fill| ast::FillStyle::Bitmap(fill)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::FillStyle::Bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/shape.rs:346:36 [INFO] [stderr] | [INFO] [stderr] 346 | pixel_hinting: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:63:54 [INFO] [stderr] | [INFO] [stderr] 63 | 2 => map!(record_data, parse_define_shape, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:64:54 [INFO] [stderr] | [INFO] [stderr] 64 | 4 => map!(record_data, parse_place_object, |t| ast::Tag::PlaceObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::PlaceObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:65:55 [INFO] [stderr] | [INFO] [stderr] 65 | 5 => map!(record_data, parse_remove_object, |t| ast::Tag::RemoveObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::RemoveObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:66:86 [INFO] [stderr] | [INFO] [stderr] 66 | 6 => map!(record_data, apply!(parse_define_bits, state.get_swf_version()), |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:67:93 [INFO] [stderr] | [INFO] [stderr] 67 | 8 => map!(record_data, apply!(parse_define_jpeg_tables, state.get_swf_version()), |t| ast::Tag::DefineJpegTables(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineJpegTables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:68:66 [INFO] [stderr] | [INFO] [stderr] 68 | 9 => map!(record_data, parse_set_background_color_tag, |t| ast::Tag::SetBackgroundColor(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::SetBackgroundColor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:69:54 [INFO] [stderr] | [INFO] [stderr] 69 | 11 => map!(record_data, parse_define_text, |t| ast::Tag::DefineText(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineText` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:71:52 [INFO] [stderr] | [INFO] [stderr] 71 | 12 => map!(record_data, parse_do_action, |t| ast::Tag::DoAction(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DoAction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:72:55 [INFO] [stderr] | [INFO] [stderr] 72 | 14 => map!(record_data, parse_define_sound, |t| ast::Tag::DefineSound(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineSound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:73:63 [INFO] [stderr] | [INFO] [stderr] 73 | 20 => map!(record_data, parse_define_bits_lossless, |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:74:93 [INFO] [stderr] | [INFO] [stderr] 74 | 21 => map!(record_data, apply!(parse_define_bits_jpeg2, state.get_swf_version()), |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:75:56 [INFO] [stderr] | [INFO] [stderr] 75 | 22 => map!(record_data, parse_define_shape2, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:76:94 [INFO] [stderr] | [INFO] [stderr] 76 | 26 => map!(record_data, apply!(parse_place_object2, state.get_swf_version() >= 6), |t| ast::Tag::PlaceObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::PlaceObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:77:57 [INFO] [stderr] | [INFO] [stderr] 77 | 28 => map!(record_data, parse_remove_object2, |t| ast::Tag::RemoveObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::RemoveObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:78:56 [INFO] [stderr] | [INFO] [stderr] 78 | 32 => map!(record_data, parse_define_shape3, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:79:57 [INFO] [stderr] | [INFO] [stderr] 79 | 34 => map!(record_data, parse_define_button2, |t| ast::Tag::DefineButton(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineButton` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:80:93 [INFO] [stderr] | [INFO] [stderr] 80 | 35 => map!(record_data, apply!(parse_define_bits_jpeg3, state.get_swf_version()), |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:81:64 [INFO] [stderr] | [INFO] [stderr] 81 | 36 => map!(record_data, parse_define_bits_lossless2, |t| ast::Tag::DefineBitmap(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineBitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:82:59 [INFO] [stderr] | [INFO] [stderr] 82 | 37 => map!(record_data, parse_define_edit_text, |t| ast::Tag::DefineDynamicText(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineDynamicText` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:83:71 [INFO] [stderr] | [INFO] [stderr] 83 | 39 => map!(record_data, apply!(parse_define_sprite, state), |t| ast::Tag::DefineSprite(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineSprite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:84:54 [INFO] [stderr] | [INFO] [stderr] 84 | 43 => map!(record_data, parse_frame_label, |t| ast::Tag::FrameLabel(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::FrameLabel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:85:61 [INFO] [stderr] | [INFO] [stderr] 85 | 46 => map!(record_data, parse_define_morph_shape, |t| ast::Tag::DefineMorphShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineMorphShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | 56 => map!(record_data, parse_export_assets, |t| ast::Tag::ExportAssets(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::ExportAssets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:87:56 [INFO] [stderr] | [INFO] [stderr] 87 | 57 => map!(record_data, parse_import_assets, |t| ast::Tag::ImportAssets(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::ImportAssets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:88:57 [INFO] [stderr] | [INFO] [stderr] 88 | 59 => map!(record_data, parse_do_init_action, |t| ast::Tag::DoInitAction(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DoInitAction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:89:62 [INFO] [stderr] | [INFO] [stderr] 89 | 69 => map!(record_data, parse_file_attributes_tag, |t| ast::Tag::FileAttributes(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::FileAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:90:94 [INFO] [stderr] | [INFO] [stderr] 90 | 70 => map!(record_data, apply!(parse_place_object3, state.get_swf_version() >= 6), |t| ast::Tag::PlaceObject(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::PlaceObject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:91:57 [INFO] [stderr] | [INFO] [stderr] 91 | 71 => map!(record_data, parse_import_assets2, |t| ast::Tag::ImportAssets(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::ImportAssets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:92:116 [INFO] [stderr] | [INFO] [stderr] 92 | 73 => map!(record_data, apply!(parse_define_font_align_zones, |font_id| state.get_glyph_count(font_id)), |t| ast::Tag::DefineFontAlignZones(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineFontAlignZones` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:93:60 [INFO] [stderr] | [INFO] [stderr] 93 | 74 => map!(record_data, parse_csm_text_settings, |t| ast::Tag::CsmTextSettings(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::CsmTextSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:94:55 [INFO] [stderr] | [INFO] [stderr] 94 | 75 => map!(record_data, parse_define_font3, |t| ast::Tag::DefineFont(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineFont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:95:51 [INFO] [stderr] | [INFO] [stderr] 95 | 77 => map!(record_data, parse_metadata, |t| ast::Tag::Metadata(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:96:56 [INFO] [stderr] | [INFO] [stderr] 96 | 83 => map!(record_data, parse_define_shape4, |t| ast::Tag::DefineShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:97:62 [INFO] [stderr] | [INFO] [stderr] 97 | 84 => map!(record_data, parse_define_morph_shape2, |t| ast::Tag::DefineMorphShape(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineMorphShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:98:80 [INFO] [stderr] | [INFO] [stderr] 98 | 86 => map!(record_data, parse_define_scene_and_frame_label_data_tag, |t| ast::Tag::DefineSceneAndFrameLabelData(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineSceneAndFrameLabelData` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers/tags.rs:99:59 [INFO] [stderr] | [INFO] [stderr] 99 | 88 => map!(record_data, parse_define_font_name, |t| ast::Tag::DefineFontName(t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ast::Tag::DefineFontName` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parsers/tags.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / match output_tag { [INFO] [stderr] 107 | | ast::Tag::DefineFont(ref tag) => { [INFO] [stderr] 108 | | match tag.glyphs { [INFO] [stderr] 109 | | Some(ref glyphs) => state.set_glyph_count(tag.id as usize, glyphs.len()), [INFO] [stderr] ... | [INFO] [stderr] 113 | | _ => (), [INFO] [stderr] 114 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let ast::Tag::DefineFont(ref tag) = output_tag { [INFO] [stderr] 107 | match tag.glyphs { [INFO] [stderr] 108 | Some(ref glyphs) => state.set_glyph_count(tag.id as usize, glyphs.len()), [INFO] [stderr] 109 | None => state.set_glyph_count(tag.id as usize, 0), [INFO] [stderr] 110 | }; [INFO] [stderr] 111 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:173:36 [INFO] [stderr] | [INFO] [stderr] 173 | track_as_menu: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 54 [INFO] [stderr] --> src/parsers/tags.rs:272:1 [INFO] [stderr] | [INFO] [stderr] 272 | / pub fn parse_define_edit_text(input: &[u8]) -> IResult<&[u8], ast::tags::DefineDynamicText> { [INFO] [stderr] 273 | | do_parse!( [INFO] [stderr] 274 | | input, [INFO] [stderr] 275 | | id: parse_le_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 335 | | ) [INFO] [stderr] 336 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:294:37 [INFO] [stderr] | [INFO] [stderr] 294 | use_glyph_font: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/tags.rs:306:48 [INFO] [stderr] | [INFO] [stderr] 306 | variable_name: map!(parse_c_string, |x| if x.len() > 0 {Option::Some(x)} else {Option::None}) >> [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/parsers/tags.rs:339:1 [INFO] [stderr] | [INFO] [stderr] 339 | / pub fn parse_define_font3(input: &[u8]) -> IResult<&[u8], ast::tags::DefineFont> { [INFO] [stderr] 340 | | do_parse!( [INFO] [stderr] 341 | | input, [INFO] [stderr] 342 | | id: parse_le_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 387 | | ) [INFO] [stderr] 388 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:344:30 [INFO] [stderr] | [INFO] [stderr] 344 | is_bold: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parsers/tags.rs:372:41 [INFO] [stderr] | [INFO] [stderr] 372 | false => map!(parse_u8, |x| x as u16) [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:452:42 [INFO] [stderr] | [INFO] [stderr] 452 | has_scaling_strokes: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:527:42 [INFO] [stderr] | [INFO] [stderr] 527 | has_scaling_strokes: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:553:41 [INFO] [stderr] | [INFO] [stderr] 553 | sound_type: switch!(value!((flags & (1 << 0)) != 0), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/tags.rs:662:31 [INFO] [stderr] | [INFO] [stderr] 662 | let (input, is_anchor) = if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/tags.rs:711:23 [INFO] [stderr] | [INFO] [stderr] 711 | return Ok((input, input.len() > 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/parsers/tags.rs:756:1 [INFO] [stderr] | [INFO] [stderr] 756 | / pub fn parse_place_object2(input: &[u8], extended_events: bool) -> IResult<&[u8], ast::tags::PlaceObject> { [INFO] [stderr] 757 | | do_parse!( [INFO] [stderr] 758 | | input, [INFO] [stderr] 759 | | flags: parse_u8 >> [INFO] [stderr] ... | [INFO] [stderr] 796 | | ) [INFO] [stderr] 797 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:760:30 [INFO] [stderr] | [INFO] [stderr] 760 | is_move: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 65 [INFO] [stderr] --> src/parsers/tags.rs:799:1 [INFO] [stderr] | [INFO] [stderr] 799 | / pub fn parse_place_object3(input: &[u8], extended_events: bool) -> IResult<&[u8], ast::tags::PlaceObject> { [INFO] [stderr] 800 | | do_parse!( [INFO] [stderr] 801 | | input, [INFO] [stderr] 802 | | flags: parse_le_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 863 | | ) [INFO] [stderr] 864 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/tags.rs:803:30 [INFO] [stderr] | [INFO] [stderr] 803 | is_move: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/text.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | has_x: (flags & (1 << 0)) != 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsers/text.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | while current_input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/parsers/text.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn parse_text_record(input: &[u8], has_alpha: bool, index_bits: usize, advance_bits: usize) -> IResult<&[u8], ast::text::TextRecord> { [INFO] [stderr] 93 | | do_parse!( [INFO] [stderr] 94 | | input, [INFO] [stderr] 95 | | flags: parse_u8 >> [INFO] [stderr] ... | [INFO] [stderr] 121 | | ) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/parsers/text.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | has_offset_y: value!((flags & (1 << 0)) != 0) >> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/state.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | self.glyph_counts.get(&font_id).map(|count| *count) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.glyph_counts.get(&font_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.84s [INFO] running `"docker" "inspect" "fb15404aa9572dd5884d9513aba0a0c51fe06d080cff6b152f6569341f5ab78f"` [INFO] running `"docker" "rm" "-f" "fb15404aa9572dd5884d9513aba0a0c51fe06d080cff6b152f6569341f5ab78f"` [INFO] [stdout] fb15404aa9572dd5884d9513aba0a0c51fe06d080cff6b152f6569341f5ab78f