[INFO] crate swear 0.1.0 is already in cache [INFO] extracting crate swear 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/swear/0.1.0 [INFO] extracting crate swear 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/swear/0.1.0 [INFO] validating manifest of swear-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of swear-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing swear-0.1.0 [INFO] finished frobbing swear-0.1.0 [INFO] frobbed toml for swear-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/swear/0.1.0/Cargo.toml [INFO] started frobbing swear-0.1.0 [INFO] finished frobbing swear-0.1.0 [INFO] frobbed toml for swear-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/swear/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting swear-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/swear/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79ebda9ee56cfac663669469c8678587bff661cc424b232c239a90837bc94612 [INFO] running `"docker" "start" "-a" "79ebda9ee56cfac663669469c8678587bff661cc424b232c239a90837bc94612"` [INFO] [stderr] Checking boxfnonce v0.1.0 [INFO] [stderr] Checking swear v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runqueue.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Sender { [INFO] [stderr] 22 | | buffer: Rc::clone(&self.buffer), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Sender { [INFO] [stderr] 22 | buffer: Rc::clone(&self.buffer), [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runqueue.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return (Queuer { sender: sdr }, Reactor { receiver: rcv }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Queuer { sender: sdr }, Reactor { receiver: rcv })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/swear.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return rs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/swear.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return rs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/swear.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return (Completer { s: sw.clone() }, Swear { s: sw }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Completer { s: sw.clone() }, Swear { s: sw })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runqueue.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Sender { [INFO] [stderr] 22 | | buffer: Rc::clone(&self.buffer), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Sender { [INFO] [stderr] 22 | buffer: Rc::clone(&self.buffer), [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runqueue.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return (Queuer { sender: sdr }, Reactor { receiver: rcv }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Queuer { sender: sdr }, Reactor { receiver: rcv })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/swear.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return rs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/swear.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return rs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/swear.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return (Completer { s: sw.clone() }, Swear { s: sw }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Completer { s: sw.clone() }, Swear { s: sw })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/basic_test.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | return (Runner { q: q }, r); [INFO] [stderr] | ^^^^ help: replace it with: `q` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/runqueue.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / loop { [INFO] [stderr] 125 | | match rcv.recieve() { [INFO] [stderr] 126 | | Some(f) => f.call(), [INFO] [stderr] 127 | | None => break, [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(f) = rcv.recieve() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/basic_test.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return (Runner { q: q }, r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Runner { q: q }, r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/basic_test.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.47s [INFO] running `"docker" "inspect" "79ebda9ee56cfac663669469c8678587bff661cc424b232c239a90837bc94612"` [INFO] running `"docker" "rm" "-f" "79ebda9ee56cfac663669469c8678587bff661cc424b232c239a90837bc94612"` [INFO] [stdout] 79ebda9ee56cfac663669469c8678587bff661cc424b232c239a90837bc94612