[INFO] crate swagger_client 0.1.1 is already in cache [INFO] extracting crate swagger_client 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/swagger_client/0.1.1 [INFO] extracting crate swagger_client 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/swagger_client/0.1.1 [INFO] validating manifest of swagger_client-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of swagger_client-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing swagger_client-0.1.1 [INFO] finished frobbing swagger_client-0.1.1 [INFO] frobbed toml for swagger_client-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/swagger_client/0.1.1/Cargo.toml [INFO] started frobbing swagger_client-0.1.1 [INFO] finished frobbing swagger_client-0.1.1 [INFO] frobbed toml for swagger_client-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/swagger_client/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting swagger_client-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/swagger_client/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44485cfdb3809b9aff01553985946d4af905cbe1293152749865aff1e1b5e3b1 [INFO] running `"docker" "start" "-a" "44485cfdb3809b9aff01553985946d4af905cbe1293152749865aff1e1b5e3b1"` [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking hyper-openssl v0.2.7 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking swagger v0.7.0 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking bodyparser v0.7.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking swagger_client v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | hyper_client: hyper_client [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hyper_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | api_contents: api_contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | hyper_client: hyper_client [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hyper_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | api_contents: api_contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/server.rs:127:63 [INFO] [stderr] | [INFO] [stderr] 127 | let mut response = Response::with((status::Status::from_u16(200))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/server.rs:127:63 [INFO] [stderr] | [INFO] [stderr] 127 | let mut response = Response::with((status::Status::from_u16(200))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/server.rs:127:63 [INFO] [stderr] | [INFO] [stderr] 127 | let mut response = Response::with((status::Status::from_u16(200))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/server.rs:127:63 [INFO] [stderr] | [INFO] [stderr] 127 | let mut response = Response::with((status::Status::from_u16(200))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | ssl.builder_mut().set_ca_file(ca_certificate.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | ssl.builder_mut().set_ca_file(ca_certificate.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | ssl.builder_mut().set_private_key_file(client_key.clone(), openssl::x509::X509_FILETYPE_PEM).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | ssl.builder_mut().set_certificate_chain_file(client_certificate.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | ssl.builder_mut().check_private_key().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | ssl.builder_mut().set_ca_file(ca_certificate.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | ssl.builder_mut().set_ca_file(ca_certificate.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | ssl.builder_mut().set_private_key_file(client_key.clone(), openssl::x509::X509_FILETYPE_PEM).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | ssl.builder_mut().set_certificate_chain_file(client_certificate.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'client::hyper_openssl::openssl::ssl::SslConnectorBuilder::builder_mut': SslConnectorBuilder now implements DerefMut [INFO] [stderr] --> src/client.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | ssl.builder_mut().check_private_key().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/client.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | context.x_span_id.as_ref().map(|header| custom_headers.set(XSpanId(header.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(header) = context.x_span_id.as_ref() { custom_headers.set(XSpanId(header.clone())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | context.x_span_id.as_ref().map(|header| response.headers.set(XSpanId(header.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(header) = context.x_span_id.as_ref() { response.headers.set(XSpanId(header.clone())) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | context.x_span_id.as_ref().map(|header| response.headers.set(XSpanId(header.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(header) = context.x_span_id.as_ref() { response.headers.set(XSpanId(header.clone())) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/client.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | context.x_span_id.as_ref().map(|header| custom_headers.set(XSpanId(header.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(header) = context.x_span_id.as_ref() { custom_headers.set(XSpanId(header.clone())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | context.x_span_id.as_ref().map(|header| response.headers.set(XSpanId(header.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(header) = context.x_span_id.as_ref() { response.headers.set(XSpanId(header.clone())) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | context.x_span_id.as_ref().map(|header| response.headers.set(XSpanId(header.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(header) = context.x_span_id.as_ref() { response.headers.set(XSpanId(header.clone())) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'hyper_openssl::openssl::ssl::SslAcceptorBuilder::builder_mut': SslAcceptorBuilder now implements DerefMut [INFO] [stderr] --> examples/server.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | ssl.builder_mut().set_private_key_file("examples/server-key.pem", X509_FILETYPE_PEM)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'hyper_openssl::openssl::ssl::SslAcceptorBuilder::builder_mut': SslAcceptorBuilder now implements DerefMut [INFO] [stderr] --> examples/server.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | ssl.builder_mut().set_certificate_chain_file("examples/server-chain.pem")?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'hyper_openssl::openssl::ssl::SslAcceptorBuilder::builder_mut': SslAcceptorBuilder now implements DerefMut [INFO] [stderr] --> examples/server.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | ssl.builder_mut().check_private_key()?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/server_lib/server.rs:25:89 [INFO] [stderr] | [INFO] [stderr] 25 | println!("upload_api({:?}) - X-Span-ID: {:?}", api_and_token, context.x_span_id.unwrap_or(String::from("")).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.76s [INFO] running `"docker" "inspect" "44485cfdb3809b9aff01553985946d4af905cbe1293152749865aff1e1b5e3b1"` [INFO] running `"docker" "rm" "-f" "44485cfdb3809b9aff01553985946d4af905cbe1293152749865aff1e1b5e3b1"` [INFO] [stdout] 44485cfdb3809b9aff01553985946d4af905cbe1293152749865aff1e1b5e3b1