[INFO] crate svgtypes 0.2.0 is already in cache [INFO] extracting crate svgtypes 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/svgtypes/0.2.0 [INFO] extracting crate svgtypes 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgtypes/0.2.0 [INFO] validating manifest of svgtypes-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of svgtypes-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing svgtypes-0.2.0 [INFO] finished frobbing svgtypes-0.2.0 [INFO] frobbed toml for svgtypes-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/svgtypes/0.2.0/Cargo.toml [INFO] started frobbing svgtypes-0.2.0 [INFO] finished frobbing svgtypes-0.2.0 [INFO] frobbed toml for svgtypes-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgtypes/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting svgtypes-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/svgtypes/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a539aa97a2d8c8eb32f833618574a56318a99a1f913f99c15d1d84e0ecc71f4 [INFO] running `"docker" "start" "-a" "0a539aa97a2d8c8eb32f833618574a56318a99a1f913f99c15d1d84e0ecc71f4"` [INFO] [stderr] Checking xmlparser v0.6.1 [INFO] [stderr] Checking svgtypes v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform/mod.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn new(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/transform/mod.rs:37:56 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn new(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let d = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/viewbox.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let h = s.parse_list_number()?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform/mod.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn new(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/transform/mod.rs:37:56 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn new(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let d = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/viewbox.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let h = s.parse_list_number()?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attribute_id.rs:290:10 [INFO] [stderr] | [INFO] [stderr] 290 | key: 8958141709656110593, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `8_958_141_709_656_110_593` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color/colors.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | key: 9603444721912725599, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_603_444_721_912_725_599` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/element_id.rs:100:10 [INFO] [stderr] | [INFO] [stderr] 100 | key: 1897749892740154578, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_897_749_892_740_154_578` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/path/writer.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / if pcmd.cmd != PathCommand::MoveTo { [INFO] [stderr] 56 | | if seg.cmd() == pcmd.cmd && seg.is_absolute() == pcmd.absolute { [INFO] [stderr] 57 | | print_cmd = false; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if pcmd.cmd != PathCommand::MoveTo && seg.cmd() == pcmd.cmd && seg.is_absolute() == pcmd.absolute { [INFO] [stderr] 56 | print_cmd = false; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/path/mod.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 150 | | if seg.cmd() == PathCommand::HorizontalLineTo { [INFO] [stderr] 151 | | prev_x += seg.x().unwrap(); [INFO] [stderr] 152 | | } else if seg.cmd() == PathCommand::VerticalLineTo { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | } else if seg.cmd() == PathCommand::HorizontalLineTo { [INFO] [stderr] 150 | prev_x += seg.x().unwrap(); [INFO] [stderr] 151 | } else if seg.cmd() == PathCommand::VerticalLineTo { [INFO] [stderr] 152 | prev_y += seg.y().unwrap(); [INFO] [stderr] 153 | } else { [INFO] [stderr] 154 | prev_x += seg.x().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/attribute_id.rs:290:10 [INFO] [stderr] | [INFO] [stderr] 290 | key: 8958141709656110593, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `8_958_141_709_656_110_593` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color/colors.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | key: 9603444721912725599, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_603_444_721_912_725_599` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/element_id.rs:100:10 [INFO] [stderr] | [INFO] [stderr] 100 | key: 1897749892740154578, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_897_749_892_740_154_578` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | test_p!(parse_11, ".0000000000008", 0.0000000000008); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.000_000_000_000_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:95:40 [INFO] [stderr] | [INFO] [stderr] 95 | test_p!(parse_12, "1000000000000", 1000000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | test_p!(parse_13, "123456.123456", 123456.123456); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `123_456.123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:104:47 [INFO] [stderr] | [INFO] [stderr] 104 | test_p!(parse_21, "12345678901234567890", 12345678901234567000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `12_345_678_901_234_567_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | test_w!(write_5, 12345678.12345678, false, "12345678.123456782"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `12_345_678.123_456_78` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | test_w!(write_12, 29.999999999999996, false, "30"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `29.999_999_999_999_996` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/number.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | test_w!(write_13, 0.49999999999999994, false, "0.5"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.499_999_999_999_999_94` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/path/writer.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / if pcmd.cmd != PathCommand::MoveTo { [INFO] [stderr] 56 | | if seg.cmd() == pcmd.cmd && seg.is_absolute() == pcmd.absolute { [INFO] [stderr] 57 | | print_cmd = false; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if pcmd.cmd != PathCommand::MoveTo && seg.cmd() == pcmd.cmd && seg.is_absolute() == pcmd.absolute { [INFO] [stderr] 56 | print_cmd = false; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/path/mod.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 150 | | if seg.cmd() == PathCommand::HorizontalLineTo { [INFO] [stderr] 151 | | prev_x += seg.x().unwrap(); [INFO] [stderr] 152 | | } else if seg.cmd() == PathCommand::VerticalLineTo { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | } else if seg.cmd() == PathCommand::HorizontalLineTo { [INFO] [stderr] 150 | prev_x += seg.x().unwrap(); [INFO] [stderr] 151 | } else if seg.cmd() == PathCommand::VerticalLineTo { [INFO] [stderr] 152 | prev_y += seg.y().unwrap(); [INFO] [stderr] 153 | } else { [INFO] [stderr] 154 | prev_x += seg.x().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/traits.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | fn write_buf_opt(&self, opt: &WriteOptions, buf: &mut Vec); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/attribute_id.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | / pub fn from_str(text: &str) -> Option { [INFO] [stderr] 624 | | ATTRIBUTES.get(text).cloned() [INFO] [stderr] 625 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/color/parser.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | let mut s = s.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/element_id.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn from_str(text: &str) -> Option { [INFO] [stderr] 206 | | ELEMENTS.get(text).cloned() [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/number.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | fn write_num(num: &f64, rm_leading_zero: bool, buf: &mut Vec) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/options.rs:140:28 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn write_separator(&self, out: &mut Vec) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/paint.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn from_str(s: &'a str) -> Result> { [INFO] [stderr] 80 | | Paint::from_span(StrSpan::from(s)) [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 56 [INFO] [stderr] --> src/path/parser.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / fn next(&mut self) -> Option { [INFO] [stderr] 96 | | let s = &mut self.stream; [INFO] [stderr] 97 | | [INFO] [stderr] 98 | | s.skip_spaces(); [INFO] [stderr] ... | [INFO] [stderr] 276 | | Some(token) [INFO] [stderr] 277 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path/writer.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | opt: &WriteOptions, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path/writer.rs:147:10 [INFO] [stderr] | [INFO] [stderr] 147 | opt: &WriteOptions, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path/writer.rs:215:10 [INFO] [stderr] | [INFO] [stderr] 215 | opt: &WriteOptions, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/path/writer.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | } else if (c as char).is_digit(10) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 231 | | true [INFO] [stderr] 232 | | } else { [INFO] [stderr] 233 | | false [INFO] [stderr] 234 | | }; [INFO] [stderr] | |_____________^ help: you can reduce it to: `(c as char).is_digit(10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `path::builder::PathBuilder` [INFO] [stderr] --> src/path/builder.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> PathBuilder { [INFO] [stderr] 47 | | PathBuilder { path: Path::new() } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | impl Default for path::builder::PathBuilder { [INFO] [stderr] 45 | fn default() -> Self { [INFO] [stderr] 46 | Self::new() [INFO] [stderr] 47 | } [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/path/builder.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn arc_to(mut self, rx: f64, ry: f64, x_axis_rotation: f64, large_arc: bool, sweep: bool, [INFO] [stderr] 167 | | x: f64, y: f64) -> PathBuilder { [INFO] [stderr] 168 | | self.path.push(PathSegment::EllipticalArc { abs: true, rx, ry, x_axis_rotation, [INFO] [stderr] 169 | | large_arc, sweep, x, y }); [INFO] [stderr] 170 | | self [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/path/builder.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / pub fn rel_arc_to(mut self, rx: f64, ry: f64, x_axis_rotation: f64, large_arc: bool, sweep: bool, [INFO] [stderr] 175 | | x: f64, y: f64) -> PathBuilder { [INFO] [stderr] 176 | | self.path.push(PathSegment::EllipticalArc { abs: false, rx, ry, x_axis_rotation, [INFO] [stderr] 177 | | large_arc, sweep, x, y }); [INFO] [stderr] 178 | | self [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `path::Path` [INFO] [stderr] --> src/path/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> Self { [INFO] [stderr] 27 | | Path(Vec::new()) [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/style/parser.rs:141:8 [INFO] [stderr] | [INFO] [stderr] 141 | if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transform/writer.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | fn write_matrix_transform(ts: &Transform, opt: &WriteOptions, out: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transform/writer.rs:42:52 [INFO] [stderr] | [INFO] [stderr] 42 | fn write_simplified_transform(ts: &Transform, opt: &WriteOptions, out: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/transform/mod.rs:219:12 [INFO] [stderr] | [INFO] [stderr] 219 | if self.b < self.c || self.b > self.c { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.b != self.c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/traits.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | fn write_buf_opt(&self, opt: &WriteOptions, buf: &mut Vec); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/attribute_id.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | / pub fn from_str(text: &str) -> Option { [INFO] [stderr] 624 | | ATTRIBUTES.get(text).cloned() [INFO] [stderr] 625 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/color/parser.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | let mut s = s.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/element_id.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn from_str(text: &str) -> Option { [INFO] [stderr] 206 | | ELEMENTS.get(text).cloned() [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/number.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | fn write_num(num: &f64, rm_leading_zero: bool, buf: &mut Vec) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | test_p!(parse_1, "0", 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | test_p!(parse_1, "0", 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | test_p!(parse_2, "1", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | test_p!(parse_2, "1", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | test_p!(parse_3, "-1", -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | test_p!(parse_3, "-1", -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | test_p!(parse_4, " -1 ", -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | test_p!(parse_4, " -1 ", -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | test_p!(parse_5, " 1 ", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | test_p!(parse_5, " 1 ", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | test_p!(parse_6, ".4", 0.4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | test_p!(parse_6, ".4", 0.4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | test_p!(parse_7, "-.4", -0.4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | test_p!(parse_7, "-.4", -0.4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | test_p!(parse_8, "-.4text", -0.4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | test_p!(parse_8, "-.4text", -0.4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | test_p!(parse_9, "-.01 text", -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | test_p!(parse_9, "-.01 text", -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | test_p!(parse_10, "-.01 4", -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | test_p!(parse_10, "-.01 4", -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | test_p!(parse_11, ".0000000000008", 0.0000000000008); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | test_p!(parse_11, ".0000000000008", 0.0000000000008); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | test_p!(parse_12, "1000000000000", 1000000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | test_p!(parse_12, "1000000000000", 1000000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | test_p!(parse_13, "123456.123456", 123456.123456); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | test_p!(parse_13, "123456.123456", 123456.123456); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | test_p!(parse_14, "+10", 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | test_p!(parse_14, "+10", 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | test_p!(parse_15, "1e2", 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | test_p!(parse_15, "1e2", 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | test_p!(parse_16, "1e+2", 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | test_p!(parse_16, "1e+2", 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | test_p!(parse_17, "1E2", 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | test_p!(parse_17, "1E2", 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | test_p!(parse_18, "1e-2", 0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | test_p!(parse_18, "1e-2", 0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | test_p!(parse_19, "1ex", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | test_p!(parse_19, "1ex", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | test_p!(parse_20, "1em", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | test_p!(parse_20, "1em", 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | test_p!(parse_21, "12345678901234567890", 12345678901234567000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | test_p!(parse_21, "12345678901234567890", 12345678901234567000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | test_p!(parse_22, "0.", 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | test_p!(parse_22, "0.", 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/number.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | test_p!(parse_23, "1.3e-2", 0.013); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/number.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | test_p!(parse_23, "1.3e-2", 0.013); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/options.rs:140:28 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn write_separator(&self, out: &mut Vec) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/paint.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn from_str(s: &'a str) -> Result> { [INFO] [stderr] 80 | | Paint::from_span(StrSpan::from(s)) [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 56 [INFO] [stderr] --> src/path/parser.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / fn next(&mut self) -> Option { [INFO] [stderr] 96 | | let s = &mut self.stream; [INFO] [stderr] 97 | | [INFO] [stderr] 98 | | s.skip_spaces(); [INFO] [stderr] ... | [INFO] [stderr] 276 | | Some(token) [INFO] [stderr] 277 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path/writer.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | opt: &WriteOptions, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path/writer.rs:147:10 [INFO] [stderr] | [INFO] [stderr] 147 | opt: &WriteOptions, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path/writer.rs:215:10 [INFO] [stderr] | [INFO] [stderr] 215 | opt: &WriteOptions, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/path/writer.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | } else if (c as char).is_digit(10) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 231 | | true [INFO] [stderr] 232 | | } else { [INFO] [stderr] 233 | | false [INFO] [stderr] 234 | | }; [INFO] [stderr] | |_____________^ help: you can reduce it to: `(c as char).is_digit(10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `path::builder::PathBuilder` [INFO] [stderr] --> src/path/builder.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> PathBuilder { [INFO] [stderr] 47 | | PathBuilder { path: Path::new() } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | impl Default for path::builder::PathBuilder { [INFO] [stderr] 45 | fn default() -> Self { [INFO] [stderr] 46 | Self::new() [INFO] [stderr] 47 | } [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/path/builder.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn arc_to(mut self, rx: f64, ry: f64, x_axis_rotation: f64, large_arc: bool, sweep: bool, [INFO] [stderr] 167 | | x: f64, y: f64) -> PathBuilder { [INFO] [stderr] 168 | | self.path.push(PathSegment::EllipticalArc { abs: true, rx, ry, x_axis_rotation, [INFO] [stderr] 169 | | large_arc, sweep, x, y }); [INFO] [stderr] 170 | | self [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/path/builder.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / pub fn rel_arc_to(mut self, rx: f64, ry: f64, x_axis_rotation: f64, large_arc: bool, sweep: bool, [INFO] [stderr] 175 | | x: f64, y: f64) -> PathBuilder { [INFO] [stderr] 176 | | self.path.push(PathSegment::EllipticalArc { abs: false, rx, ry, x_axis_rotation, [INFO] [stderr] 177 | | large_arc, sweep, x, y }); [INFO] [stderr] 178 | | self [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `path::Path` [INFO] [stderr] --> src/path/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> Self { [INFO] [stderr] 27 | | Path(Vec::new()) [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/style/parser.rs:141:8 [INFO] [stderr] | [INFO] [stderr] 141 | if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transform/writer.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | fn write_matrix_transform(ts: &Transform, opt: &WriteOptions, out: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transform/writer.rs:42:52 [INFO] [stderr] | [INFO] [stderr] 42 | fn write_simplified_transform(ts: &Transform, opt: &WriteOptions, out: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `WriteOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/transform/mod.rs:219:12 [INFO] [stderr] | [INFO] [stderr] 219 | if self.b < self.c || self.b > self.c { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.b != self.c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 23 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `svgtypes`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0a539aa97a2d8c8eb32f833618574a56318a99a1f913f99c15d1d84e0ecc71f4"` [INFO] running `"docker" "rm" "-f" "0a539aa97a2d8c8eb32f833618574a56318a99a1f913f99c15d1d84e0ecc71f4"` [INFO] [stdout] 0a539aa97a2d8c8eb32f833618574a56318a99a1f913f99c15d1d84e0ecc71f4