[INFO] crate svgrep 1.1.0 is already in cache [INFO] extracting crate svgrep 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/svgrep/1.1.0 [INFO] extracting crate svgrep 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgrep/1.1.0 [INFO] validating manifest of svgrep-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of svgrep-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing svgrep-1.1.0 [INFO] finished frobbing svgrep-1.1.0 [INFO] frobbed toml for svgrep-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/svgrep/1.1.0/Cargo.toml [INFO] started frobbing svgrep-1.1.0 [INFO] finished frobbing svgrep-1.1.0 [INFO] frobbed toml for svgrep-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgrep/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting svgrep-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/svgrep/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66179239a1f77099dd1e80e7b6201c32b60d69c169e417eede6141d53d484545 [INFO] running `"docker" "start" "-a" "66179239a1f77099dd1e80e7b6201c32b60d69c169e417eede6141d53d484545"` [INFO] [stderr] Checking svgrep v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | rxs: rxs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rxs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | cell_rxs: cell_rxs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_rxs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | rxs: rxs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rxs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | cell_rxs: cell_rxs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_rxs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:257:24 [INFO] [stderr] | [INFO] [stderr] 257 | const OPT_INPUT_FILE: &'static str = "INPUT_FILE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:258:23 [INFO] [stderr] | [INFO] [stderr] 258 | const OPT_SEPARATOR: &'static str = "separator"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:259:19 [INFO] [stderr] | [INFO] [stderr] 259 | const OPT_MATCH: &'static str = "match"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:260:29 [INFO] [stderr] | [INFO] [stderr] 260 | const OPT_MATCH_CONJ_CHAR: &'static str = "match-conj-char"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:261:30 [INFO] [stderr] | [INFO] [stderr] 261 | const OPT_CELL_SELECT_CHAR: &'static str = "cell-select-char"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:262:26 [INFO] [stderr] | [INFO] [stderr] 262 | const OPT_MATCHES_CHAR: &'static str = "matches-char"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:263:18 [INFO] [stderr] | [INFO] [stderr] 263 | const OPT_TRIM: &'static str = "trim"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:257:24 [INFO] [stderr] | [INFO] [stderr] 257 | const OPT_INPUT_FILE: &'static str = "INPUT_FILE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:258:23 [INFO] [stderr] | [INFO] [stderr] 258 | const OPT_SEPARATOR: &'static str = "separator"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:259:19 [INFO] [stderr] | [INFO] [stderr] 259 | const OPT_MATCH: &'static str = "match"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:260:29 [INFO] [stderr] | [INFO] [stderr] 260 | const OPT_MATCH_CONJ_CHAR: &'static str = "match-conj-char"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:261:30 [INFO] [stderr] | [INFO] [stderr] 261 | const OPT_CELL_SELECT_CHAR: &'static str = "cell-select-char"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:262:26 [INFO] [stderr] | [INFO] [stderr] 262 | const OPT_MATCHES_CHAR: &'static str = "matches-char"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:263:18 [INFO] [stderr] | [INFO] [stderr] 263 | const OPT_TRIM: &'static str = "trim"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | CSVRow { cells: line.split(sep).map(|s| String::from(s)).collect() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match cols { [INFO] [stderr] 103 | | &CellSelect::ALL => { [INFO] [stderr] 104 | | for (i, cell) in self.cells.iter().enumerate() { [INFO] [stderr] 105 | | print!("({}) {}{} ", i, maybe_trim(cell, config.trim), config.separator); [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | match *cols { [INFO] [stderr] 103 | CellSelect::ALL => { [INFO] [stderr] 104 | for (i, cell) in self.cells.iter().enumerate() { [INFO] [stderr] 105 | print!("({}) {}{} ", i, maybe_trim(cell, config.trim), config.separator); [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:110:24 [INFO] [stderr] | [INFO] [stderr] 110 | if i >= &self.cells.len() { [INFO] [stderr] | ^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.cells.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:243:21 [INFO] [stderr] | [INFO] [stderr] 243 | match_exps: opts.values_of(OPT_MATCH) [INFO] [stderr] | _____________________^ [INFO] [stderr] 244 | | .unwrap_or(clap::Values::default()) [INFO] [stderr] | |_______________________________________________^ help: try this: `opts.values_of(OPT_MATCH).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | CSVRow { cells: line.split(sep).map(|s| String::from(s)).collect() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match cols { [INFO] [stderr] 103 | | &CellSelect::ALL => { [INFO] [stderr] 104 | | for (i, cell) in self.cells.iter().enumerate() { [INFO] [stderr] 105 | | print!("({}) {}{} ", i, maybe_trim(cell, config.trim), config.separator); [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | match *cols { [INFO] [stderr] 103 | CellSelect::ALL => { [INFO] [stderr] 104 | for (i, cell) in self.cells.iter().enumerate() { [INFO] [stderr] 105 | print!("({}) {}{} ", i, maybe_trim(cell, config.trim), config.separator); [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:110:24 [INFO] [stderr] | [INFO] [stderr] 110 | if i >= &self.cells.len() { [INFO] [stderr] | ^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.cells.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:243:21 [INFO] [stderr] | [INFO] [stderr] 243 | match_exps: opts.values_of(OPT_MATCH) [INFO] [stderr] | _____________________^ [INFO] [stderr] 244 | | .unwrap_or(clap::Values::default()) [INFO] [stderr] | |_______________________________________________^ help: try this: `opts.values_of(OPT_MATCH).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.13s [INFO] running `"docker" "inspect" "66179239a1f77099dd1e80e7b6201c32b60d69c169e417eede6141d53d484545"` [INFO] running `"docker" "rm" "-f" "66179239a1f77099dd1e80e7b6201c32b60d69c169e417eede6141d53d484545"` [INFO] [stdout] 66179239a1f77099dd1e80e7b6201c32b60d69c169e417eede6141d53d484545