[INFO] crate svgcleaner 0.9.5 is already in cache [INFO] extracting crate svgcleaner 0.9.5 into work/ex/clippy-test-run/sources/stable/reg/svgcleaner/0.9.5 [INFO] extracting crate svgcleaner 0.9.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgcleaner/0.9.5 [INFO] validating manifest of svgcleaner-0.9.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of svgcleaner-0.9.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing svgcleaner-0.9.5 [INFO] finished frobbing svgcleaner-0.9.5 [INFO] frobbed toml for svgcleaner-0.9.5 written to work/ex/clippy-test-run/sources/stable/reg/svgcleaner/0.9.5/Cargo.toml [INFO] started frobbing svgcleaner-0.9.5 [INFO] finished frobbing svgcleaner-0.9.5 [INFO] frobbed toml for svgcleaner-0.9.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgcleaner/0.9.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting svgcleaner-0.9.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/svgcleaner/0.9.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32317aecef1118b164aa4504c67e0a6eb05adf2a0cf0d1f6fe01d2c4ab2d0173 [INFO] running `"docker" "start" "-a" "32317aecef1118b164aa4504c67e0a6eb05adf2a0cf0d1f6fe01d2c4ab2d0173"` [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking simplecss v0.1.0 [INFO] [stderr] Checking float-cmp v0.3.0 [INFO] [stderr] Checking xmlparser v0.1.2 [INFO] [stderr] Checking svgparser v0.6.4 [INFO] [stderr] Checking svgdom v0.10.5 [INFO] [stderr] Checking svgcleaner v0.9.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task/trim_ids.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | let c = (y - (a * x + b)).abs(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | let c = a * x + b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task/trim_ids.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | let c = (y - (a * x + b)).abs(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | let c = a * x + b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/resolve_gradients.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 126 | | if idx == 0 { [INFO] [stderr] 127 | | // Allow first stop to not have an offset. [INFO] [stderr] 128 | | warn!("The 'stop' element must have an 'offset' attribute. \ [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 125 | } else if idx == 0 { [INFO] [stderr] 126 | // Allow first stop to not have an offset. [INFO] [stderr] 127 | warn!("The 'stop' element must have an 'offset' attribute. \ [INFO] [stderr] 128 | Fallback to 'offset=0'."); [INFO] [stderr] 129 | node.set_attribute((AId::Offset, Length::zero())); [INFO] [stderr] 130 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / if tag_name == EId::Text && list.len() == 1 { [INFO] [stderr] 127 | | if list[0] == Length::zero() { [INFO] [stderr] 128 | | return true; [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 126 | if tag_name == EId::Text && list.len() == 1 && list[0] == Length::zero() { [INFO] [stderr] 127 | return true; [INFO] [stderr] 128 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | / if tag_name == EId::Circle || tag_name == EId::Ellipse { [INFO] [stderr] 166 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 167 | | return true; [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 165 | if (tag_name == EId::Circle || tag_name == EId::Ellipse) && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 166 | return true; [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | / if tag_name == EId::Marker { [INFO] [stderr] 173 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 174 | | return true; [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | if tag_name == EId::Marker && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 173 | return true; [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | / if tag_name == EId::Line { [INFO] [stderr] 180 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 181 | | return true; [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | if tag_name == EId::Line && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 180 | return true; [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_dupl_defs/mod.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) { [INFO] [stderr] 108 | | if attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 109 | | return false; [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) && attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 108 | return false; [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_text_attrs.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | / if child.node_type() == NodeType::Text { [INFO] [stderr] 193 | | if is_text_contains_spaces(&child) { [INFO] [stderr] 194 | | has_spaces = true; [INFO] [stderr] 195 | | break; [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if child.node_type() == NodeType::Text && is_text_contains_spaces(&child) { [INFO] [stderr] 193 | has_spaces = true; [INFO] [stderr] 194 | break; [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_unused_coords.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | / if attrs.contains(AId::Rx) { [INFO] [stderr] 51 | | if attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 52 | | rm_list.push(AId::Ry); [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | if attrs.contains(AId::Rx) && attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 51 | rm_list.push(AId::Ry); [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / if node.is_tag_name(EId::G) { [INFO] [stderr] 43 | | if can_ungroup(parent, &node) { [INFO] [stderr] 44 | | ungroup_group(&mut node); [INFO] [stderr] 45 | | node.remove(); [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | if node.is_tag_name(EId::G) && can_ungroup(parent, &node) { [INFO] [stderr] 43 | ungroup_group(&mut node); [INFO] [stderr] 44 | node.remove(); [INFO] [stderr] 45 | [INFO] [stderr] 46 | apply_transforms::prepare_transforms(parent, false, opt); [INFO] [stderr] 47 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / if node.has_children() { [INFO] [stderr] 54 | | if _ungroup_groups(&node, opt) { [INFO] [stderr] 55 | | return true; [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if node.has_children() && _ungroup_groups(&node, opt) { [INFO] [stderr] 54 | return true; [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | / if aid == AId::Opacity { [INFO] [stderr] 139 | | if child.has_attribute(aid) { [INFO] [stderr] 140 | | // We can't just replace 'opacity' attribute, [INFO] [stderr] 141 | | // we should multiply it. [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if aid == AId::Opacity && child.has_attribute(aid) { [INFO] [stderr] 139 | // We can't just replace 'opacity' attribute, [INFO] [stderr] 140 | // we should multiply it. [INFO] [stderr] 141 | [INFO] [stderr] 142 | let op1 = match attr.value { [INFO] [stderr] 143 | AttributeValue::Number(v) => v, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / if aid == AId::Transform { [INFO] [stderr] 159 | | if child.has_attribute(aid) { [INFO] [stderr] 160 | | // We should multiply transform matrices. [INFO] [stderr] 161 | | if let AttributeValue::Transform(mut t1) = attr.value { [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 158 | if aid == AId::Transform && child.has_attribute(aid) { [INFO] [stderr] 159 | // We should multiply transform matrices. [INFO] [stderr] 160 | if let AttributeValue::Transform(mut t1) = attr.value { [INFO] [stderr] 161 | let mut attrs = child.attributes_mut(); [INFO] [stderr] 162 | let av = attrs.get_value_mut(AId::Transform); [INFO] [stderr] 163 | if let Some(&mut AttributeValue::Transform(ref mut ts)) = av { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/conv_segments.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / if prev_cmd == Command::ClosePath { [INFO] [stderr] 63 | | if curr_cmd != Command::MoveTo { [INFO] [stderr] 64 | | path.d.insert(i, Segment::new_move_to(mx, my)); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | if prev_cmd == Command::ClosePath && curr_cmd != Command::MoveTo { [INFO] [stderr] 63 | path.d.insert(i, Segment::new_move_to(mx, my)); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/conv_segments.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / if y.fuzzy_eq(&c) { [INFO] [stderr] 237 | | if ( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 238 | | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less) { [INFO] [stderr] 239 | | return true; [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 236 | if y.fuzzy_eq(&c) && (( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 237 | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less)) { [INFO] [stderr] 238 | return true; [INFO] [stderr] 239 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/mod.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / if opt.apply_transform_to_paths { [INFO] [stderr] 45 | | if node.has_attribute(AId::Transform) { [INFO] [stderr] 46 | | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 47 | | [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if opt.apply_transform_to_paths && node.has_attribute(AId::Transform) { [INFO] [stderr] 45 | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 46 | [INFO] [stderr] 47 | if ts_utils::is_valid_transform(&tsl) [INFO] [stderr] 48 | && ts_utils::is_valid_attrs(&node) { [INFO] [stderr] 49 | ts = Some(tsl); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/utils.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 39 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 40 | | // Defined in the parent node. [INFO] [stderr] 41 | | n.attributes().get_value(aid).cloned().unwrap() [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 39 | // Defined in the parent node. [INFO] [stderr] 40 | n.attributes().get_value(aid).cloned().unwrap() [INFO] [stderr] 41 | } else { [INFO] [stderr] 42 | // Default value. [INFO] [stderr] 43 | AttributeValue::default_value(aid).unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/utils.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 64 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 65 | | // Defined in the parent node. [INFO] [stderr] 66 | | Some(n.attributes().get_value(aid).cloned().unwrap()) [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 64 | // Defined in the parent node. [INFO] [stderr] 65 | Some(n.attributes().get_value(aid).cloned().unwrap()) [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | None [INFO] [stderr] 68 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/resolve_gradients.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 126 | | if idx == 0 { [INFO] [stderr] 127 | | // Allow first stop to not have an offset. [INFO] [stderr] 128 | | warn!("The 'stop' element must have an 'offset' attribute. \ [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 125 | } else if idx == 0 { [INFO] [stderr] 126 | // Allow first stop to not have an offset. [INFO] [stderr] 127 | warn!("The 'stop' element must have an 'offset' attribute. \ [INFO] [stderr] 128 | Fallback to 'offset=0'."); [INFO] [stderr] 129 | node.set_attribute((AId::Offset, Length::zero())); [INFO] [stderr] 130 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / if tag_name == EId::Text && list.len() == 1 { [INFO] [stderr] 127 | | if list[0] == Length::zero() { [INFO] [stderr] 128 | | return true; [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 126 | if tag_name == EId::Text && list.len() == 1 && list[0] == Length::zero() { [INFO] [stderr] 127 | return true; [INFO] [stderr] 128 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | / if tag_name == EId::Circle || tag_name == EId::Ellipse { [INFO] [stderr] 166 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 167 | | return true; [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 165 | if (tag_name == EId::Circle || tag_name == EId::Ellipse) && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 166 | return true; [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | / if tag_name == EId::Marker { [INFO] [stderr] 173 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 174 | | return true; [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | if tag_name == EId::Marker && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 173 | return true; [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | / if tag_name == EId::Line { [INFO] [stderr] 180 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 181 | | return true; [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | if tag_name == EId::Line && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 180 | return true; [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_dupl_defs/mod.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) { [INFO] [stderr] 108 | | if attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 109 | | return false; [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) && attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 108 | return false; [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_text_attrs.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | / if child.node_type() == NodeType::Text { [INFO] [stderr] 193 | | if is_text_contains_spaces(&child) { [INFO] [stderr] 194 | | has_spaces = true; [INFO] [stderr] 195 | | break; [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if child.node_type() == NodeType::Text && is_text_contains_spaces(&child) { [INFO] [stderr] 193 | has_spaces = true; [INFO] [stderr] 194 | break; [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_unused_coords.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | / if attrs.contains(AId::Rx) { [INFO] [stderr] 51 | | if attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 52 | | rm_list.push(AId::Ry); [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | if attrs.contains(AId::Rx) && attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 51 | rm_list.push(AId::Ry); [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / if node.is_tag_name(EId::G) { [INFO] [stderr] 43 | | if can_ungroup(parent, &node) { [INFO] [stderr] 44 | | ungroup_group(&mut node); [INFO] [stderr] 45 | | node.remove(); [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | if node.is_tag_name(EId::G) && can_ungroup(parent, &node) { [INFO] [stderr] 43 | ungroup_group(&mut node); [INFO] [stderr] 44 | node.remove(); [INFO] [stderr] 45 | [INFO] [stderr] 46 | apply_transforms::prepare_transforms(parent, false, opt); [INFO] [stderr] 47 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / if node.has_children() { [INFO] [stderr] 54 | | if _ungroup_groups(&node, opt) { [INFO] [stderr] 55 | | return true; [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if node.has_children() && _ungroup_groups(&node, opt) { [INFO] [stderr] 54 | return true; [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | / if aid == AId::Opacity { [INFO] [stderr] 139 | | if child.has_attribute(aid) { [INFO] [stderr] 140 | | // We can't just replace 'opacity' attribute, [INFO] [stderr] 141 | | // we should multiply it. [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if aid == AId::Opacity && child.has_attribute(aid) { [INFO] [stderr] 139 | // We can't just replace 'opacity' attribute, [INFO] [stderr] 140 | // we should multiply it. [INFO] [stderr] 141 | [INFO] [stderr] 142 | let op1 = match attr.value { [INFO] [stderr] 143 | AttributeValue::Number(v) => v, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / if aid == AId::Transform { [INFO] [stderr] 159 | | if child.has_attribute(aid) { [INFO] [stderr] 160 | | // We should multiply transform matrices. [INFO] [stderr] 161 | | if let AttributeValue::Transform(mut t1) = attr.value { [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 158 | if aid == AId::Transform && child.has_attribute(aid) { [INFO] [stderr] 159 | // We should multiply transform matrices. [INFO] [stderr] 160 | if let AttributeValue::Transform(mut t1) = attr.value { [INFO] [stderr] 161 | let mut attrs = child.attributes_mut(); [INFO] [stderr] 162 | let av = attrs.get_value_mut(AId::Transform); [INFO] [stderr] 163 | if let Some(&mut AttributeValue::Transform(ref mut ts)) = av { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/conv_segments.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / if prev_cmd == Command::ClosePath { [INFO] [stderr] 63 | | if curr_cmd != Command::MoveTo { [INFO] [stderr] 64 | | path.d.insert(i, Segment::new_move_to(mx, my)); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | if prev_cmd == Command::ClosePath && curr_cmd != Command::MoveTo { [INFO] [stderr] 63 | path.d.insert(i, Segment::new_move_to(mx, my)); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/conv_segments.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / if y.fuzzy_eq(&c) { [INFO] [stderr] 237 | | if ( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 238 | | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less) { [INFO] [stderr] 239 | | return true; [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 236 | if y.fuzzy_eq(&c) && (( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 237 | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less)) { [INFO] [stderr] 238 | return true; [INFO] [stderr] 239 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/mod.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / if opt.apply_transform_to_paths { [INFO] [stderr] 45 | | if node.has_attribute(AId::Transform) { [INFO] [stderr] 46 | | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 47 | | [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if opt.apply_transform_to_paths && node.has_attribute(AId::Transform) { [INFO] [stderr] 45 | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 46 | [INFO] [stderr] 47 | if ts_utils::is_valid_transform(&tsl) [INFO] [stderr] 48 | && ts_utils::is_valid_attrs(&node) { [INFO] [stderr] 49 | ts = Some(tsl); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/utils.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 39 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 40 | | // Defined in the parent node. [INFO] [stderr] 41 | | n.attributes().get_value(aid).cloned().unwrap() [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 39 | // Defined in the parent node. [INFO] [stderr] 40 | n.attributes().get_value(aid).cloned().unwrap() [INFO] [stderr] 41 | } else { [INFO] [stderr] 42 | // Default value. [INFO] [stderr] 43 | AttributeValue::default_value(aid).unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/utils.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 64 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 65 | | // Defined in the parent node. [INFO] [stderr] 66 | | Some(n.attributes().get_value(aid).cloned().unwrap()) [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 64 | // Defined in the parent node. [INFO] [stderr] 65 | Some(n.attributes().get_value(aid).cloned().unwrap()) [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | None [INFO] [stderr] 68 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/cli.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | / writeln!(stderr(), "Error: You can use '--{}=true' only with '--{}=true'.", [INFO] [stderr] 353 | | KEYS[dep], KEYS[flag]).unwrap(); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/cleaner.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn clean_doc( [INFO] [stderr] 64 | | doc: &mut Document, [INFO] [stderr] 65 | | options: &CleaningOptions, [INFO] [stderr] 66 | | opt: &WriteOptions [INFO] [stderr] ... | [INFO] [stderr] 247 | | Ok(()) [INFO] [stderr] 248 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | if f[idx] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `f[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/task/rm_default_attrs.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | } else if s == "1" { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 204 | | return true; [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/task/rm_default_attrs.rs:201:58 [INFO] [stderr] | [INFO] [stderr] 201 | if tag_name == EId::FontFace && s == "0" { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 202 | | return true; [INFO] [stderr] 203 | | } else if s == "1" { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/trim_ids.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | fn shift(&mut self, pos: usize, head: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/apply_transforms/mod.rs:139:72 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn scale_coord(attrs: &mut Attributes, aid: AId, scale_factor: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task/paths/conv_segments.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / if let &SegmentData::MoveTo { x, y } = path.d[i - 1].data() { [INFO] [stderr] 58 | | mx = x; [INFO] [stderr] 59 | | my = y; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | if let SegmentData::MoveTo { x, y } = *path.d[i - 1].data() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/paths/conv_segments.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match *curr_seg.data() { [INFO] [stderr] 143 | | SegmentData::CurveTo { x1, y1, x2, y2, x, y } => { [INFO] [stderr] 144 | | let is_vlineto = || { [INFO] [stderr] 145 | | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => {} [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | if let SegmentData::CurveTo { x1, y1, x2, y2, x, y } = *curr_seg.data() { [INFO] [stderr] 143 | let is_vlineto = || { [INFO] [stderr] 144 | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] 145 | // y1 must be equal or greater than prev_y. [INFO] [stderr] 146 | // y2 must be equal or less than y. [INFO] [stderr] 147 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `svgcleaner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/cli.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | / writeln!(stderr(), "Error: You can use '--{}=true' only with '--{}=true'.", [INFO] [stderr] 353 | | KEYS[dep], KEYS[flag]).unwrap(); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/cleaner.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn clean_doc( [INFO] [stderr] 64 | | doc: &mut Document, [INFO] [stderr] 65 | | options: &CleaningOptions, [INFO] [stderr] 66 | | opt: &WriteOptions [INFO] [stderr] ... | [INFO] [stderr] 247 | | Ok(()) [INFO] [stderr] 248 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / test!(conv_line_1, [INFO] [stderr] 191 | | " [INFO] [stderr] 192 | | [INFO] [stderr] 193 | | ", [INFO] [stderr] ... | [INFO] [stderr] 196 | | [INFO] [stderr] 197 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / test!(conv_line_2, [INFO] [stderr] 200 | | " [INFO] [stderr] 201 | | [INFO] [stderr] 202 | | ", [INFO] [stderr] ... | [INFO] [stderr] 205 | | [INFO] [stderr] 206 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | / test!(conv_line_3, [INFO] [stderr] 210 | | " [INFO] [stderr] 211 | | [INFO] [stderr] 212 | | ", [INFO] [stderr] ... | [INFO] [stderr] 215 | | [INFO] [stderr] 216 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / test!(conv_rect_1, [INFO] [stderr] 219 | | " [INFO] [stderr] 220 | | [INFO] [stderr] 221 | | ", [INFO] [stderr] ... | [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / test!(conv_rect_2, [INFO] [stderr] 228 | | " [INFO] [stderr] 229 | | [INFO] [stderr] 230 | | ", [INFO] [stderr] ... | [INFO] [stderr] 233 | | [INFO] [stderr] 234 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / test!(conv_rect_3, [INFO] [stderr] 237 | | " [INFO] [stderr] 238 | | [INFO] [stderr] 239 | | [INFO] [stderr] ... | [INFO] [stderr] 248 | | [INFO] [stderr] 249 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | / test!(conv_polyline_1, [INFO] [stderr] 252 | | " [INFO] [stderr] 253 | | [INFO] [stderr] 254 | | ", [INFO] [stderr] ... | [INFO] [stderr] 257 | | [INFO] [stderr] 258 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | / test!(conv_polyline_2, [INFO] [stderr] 261 | | " [INFO] [stderr] 262 | | [INFO] [stderr] 263 | | ", [INFO] [stderr] ... | [INFO] [stderr] 266 | | [INFO] [stderr] 267 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `convert_shapes_to_paths` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/conv_shapes.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | / test!(conv_polygon_1, [INFO] [stderr] 270 | | " [INFO] [stderr] 271 | | [INFO] [stderr] 272 | | ", [INFO] [stderr] ... | [INFO] [stderr] 275 | | [INFO] [stderr] 276 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/final_fixes.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / test!(rm_defs_1, [INFO] [stderr] 79 | | " [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | ", [INFO] [stderr] 82 | | " [INFO] [stderr] 83 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/final_fixes.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / test!(rm_defs_2, [INFO] [stderr] 86 | | " [INFO] [stderr] 87 | | [INFO] [stderr] 88 | | [INFO] [stderr] ... | [INFO] [stderr] 94 | | [INFO] [stderr] 95 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/final_fixes.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / test!(keep_1, [INFO] [stderr] 98 | | " [INFO] [stderr] 99 | | [INFO] [stderr] 100 | | [INFO] [stderr] ... | [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | if f[idx] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `f[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | resolve_inherit(&mut doc).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 117 | / test!(inherit_1, [INFO] [stderr] 118 | | " [INFO] [stderr] 119 | | [INFO] [stderr] 120 | | ", [INFO] [stderr] ... | [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | resolve_inherit(&mut doc).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 126 | / test!(inherit_2, [INFO] [stderr] 127 | | " [INFO] [stderr] 128 | | [INFO] [stderr] 129 | | [INFO] [stderr] ... | [INFO] [stderr] 136 | | [INFO] [stderr] 137 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | resolve_inherit(&mut doc).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 139 | / test!(inherit_3, [INFO] [stderr] 140 | | " [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | ", [INFO] [stderr] ... | [INFO] [stderr] 145 | | [INFO] [stderr] 146 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | resolve_inherit(&mut doc).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 148 | / test!(current_color_1, [INFO] [stderr] 149 | | " [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | ", [INFO] [stderr] ... | [INFO] [stderr] 154 | | [INFO] [stderr] 155 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | resolve_inherit(&mut doc).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 157 | / test!(current_color_2, [INFO] [stderr] 158 | | " [INFO] [stderr] 159 | | [INFO] [stderr] 160 | | ", [INFO] [stderr] ... | [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | resolve_inherit(&mut doc).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 166 | / test!(current_color_3, [INFO] [stderr] 167 | | " [INFO] [stderr] 168 | | [INFO] [stderr] 169 | | ", [INFO] [stderr] ... | [INFO] [stderr] 172 | | [INFO] [stderr] 173 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:112:44 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(resolve_inherit(&mut doc).is_err(), true); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 175 | / test_err!(unresolvable_1, [INFO] [stderr] 176 | | " [INFO] [stderr] 177 | | [INFO] [stderr] 178 | | " [INFO] [stderr] 179 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:112:44 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(resolve_inherit(&mut doc).is_err(), true); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 181 | / test_err!(unresolvable_2, [INFO] [stderr] 182 | | " [INFO] [stderr] 183 | | [INFO] [stderr] 184 | | [INFO] [stderr] 185 | | " [INFO] [stderr] 186 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_inherit` doesn't need a mutable reference [INFO] [stderr] --> src/task/resolve_inherit.rs:112:44 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(resolve_inherit(&mut doc).is_err(), true); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 188 | / test_err!(unresolvable_3, [INFO] [stderr] 189 | | "" [INFO] [stderr] 190 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / test!(resolve_1, [INFO] [stderr] 120 | | " [INFO] [stderr] 121 | | [INFO] [stderr] 122 | | [INFO] [stderr] ... | [INFO] [stderr] 129 | | [INFO] [stderr] 130 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / test!(resolve_2, [INFO] [stderr] 133 | | " [INFO] [stderr] 134 | | [INFO] [stderr] 135 | | [INFO] [stderr] ... | [INFO] [stderr] 142 | | [INFO] [stderr] 143 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | / test!(resolve_3, [INFO] [stderr] 146 | | " [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | [INFO] [stderr] ... | [INFO] [stderr] 155 | | [INFO] [stderr] 156 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | / test!(resolve_4, [INFO] [stderr] 159 | | " [INFO] [stderr] 160 | | [INFO] [stderr] 161 | | [INFO] [stderr] ... | [INFO] [stderr] 168 | | [INFO] [stderr] 169 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / test!(resolve_5, [INFO] [stderr] 172 | | " [INFO] [stderr] 173 | | [INFO] [stderr] 174 | | [INFO] [stderr] ... | [INFO] [stderr] 184 | | [INFO] [stderr] 185 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / test!(resolve_6, [INFO] [stderr] 188 | | " [INFO] [stderr] 189 | | [INFO] [stderr] 190 | | [INFO] [stderr] ... | [INFO] [stderr] 199 | | " [INFO] [stderr] 200 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / test_eq!(keep_1, [INFO] [stderr] 203 | | " [INFO] [stderr] 204 | | [INFO] [stderr] 205 | | [INFO] [stderr] 206 | | [INFO] [stderr] 207 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | / test_eq!(keep_2, [INFO] [stderr] 210 | | " [INFO] [stderr] 211 | | [INFO] [stderr] 212 | | [INFO] [stderr] ... | [INFO] [stderr] 217 | | [INFO] [stderr] 218 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve_use` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/resolve_use.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / test_eq!(keep_3, [INFO] [stderr] 221 | | " [INFO] [stderr] 222 | | [INFO] [stderr] 223 | | [INFO] [stderr] ... | [INFO] [stderr] 227 | | [INFO] [stderr] 228 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/task/rm_default_attrs.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | } else if s == "1" { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 204 | | return true; [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/task/rm_default_attrs.rs:201:58 [INFO] [stderr] | [INFO] [stderr] 201 | if tag_name == EId::FontFace && s == "0" { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 202 | | return true; [INFO] [stderr] 203 | | } else if s == "1" { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / test!(rm_1, [INFO] [stderr] 245 | | " [INFO] [stderr] 246 | | [INFO] [stderr] 247 | | ", [INFO] [stderr] ... | [INFO] [stderr] 250 | | [INFO] [stderr] 251 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | / test!(keep_1, [INFO] [stderr] 254 | | " [INFO] [stderr] 255 | | [INFO] [stderr] 256 | | ", [INFO] [stderr] ... | [INFO] [stderr] 259 | | [INFO] [stderr] 260 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | / test!(rm_svg_w_h, [INFO] [stderr] 263 | | "", [INFO] [stderr] 264 | | " [INFO] [stderr] 265 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / test!(rm_len_list, [INFO] [stderr] 269 | | " [INFO] [stderr] 270 | | [INFO] [stderr] 271 | | ", [INFO] [stderr] ... | [INFO] [stderr] 274 | | [INFO] [stderr] 275 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | / test!(rm_mask, [INFO] [stderr] 278 | | " [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | ", [INFO] [stderr] ... | [INFO] [stderr] 283 | | [INFO] [stderr] 284 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / test!(rm_filter, [INFO] [stderr] 287 | | " [INFO] [stderr] 288 | | [INFO] [stderr] 289 | | ", [INFO] [stderr] ... | [INFO] [stderr] 292 | | [INFO] [stderr] 293 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_default_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_default_attrs.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / test!(rm_overflow_1, [INFO] [stderr] 296 | | " [INFO] [stderr] 297 | | [INFO] [stderr] 298 | | [INFO] [stderr] ... | [INFO] [stderr] 303 | | [INFO] [stderr] 304 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_dupl_fe_gaussian_blur` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_dupl_defs/fe_gaussian_blur.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / test!(rm_1, [INFO] [stderr] 124 | | " [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | [INFO] [stderr] ... | [INFO] [stderr] 142 | | [INFO] [stderr] 143 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_dupl_fe_gaussian_blur` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_dupl_defs/fe_gaussian_blur.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | / test!(rm_2, [INFO] [stderr] 146 | | " [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | [INFO] [stderr] ... | [INFO] [stderr] 164 | | [INFO] [stderr] 165 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_dupl_fe_gaussian_blur` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_dupl_defs/fe_gaussian_blur.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / test_eq!(keep_1, [INFO] [stderr] 169 | | " [INFO] [stderr] 170 | | [INFO] [stderr] 171 | | [INFO] [stderr] ... | [INFO] [stderr] 176 | | [INFO] [stderr] 177 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_dupl_fe_gaussian_blur` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_dupl_defs/fe_gaussian_blur.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | / test_eq!(keep_2, [INFO] [stderr] 180 | | " [INFO] [stderr] 181 | | [INFO] [stderr] 182 | | [INFO] [stderr] ... | [INFO] [stderr] 187 | | [INFO] [stderr] 188 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_dupl_fe_gaussian_blur` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_dupl_defs/fe_gaussian_blur.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / test_eq!(keep_3, [INFO] [stderr] 191 | | " [INFO] [stderr] 192 | | [INFO] [stderr] 193 | | [INFO] [stderr] ... | [INFO] [stderr] 198 | | [INFO] [stderr] 199 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 361 | / test!(rm_clip_path_children_1, [INFO] [stderr] 362 | | " [INFO] [stderr] 363 | | [INFO] [stderr] 364 | | [INFO] [stderr] ... | [INFO] [stderr] 376 | | [INFO] [stderr] 377 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 379 | / test!(rm_clip_path_children_2, [INFO] [stderr] 380 | | " [INFO] [stderr] 381 | | [INFO] [stderr] 382 | | [INFO] [stderr] ... | [INFO] [stderr] 399 | | [INFO] [stderr] 400 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 402 | / test!(rm_clip_path_1, [INFO] [stderr] 403 | | " [INFO] [stderr] 404 | | [INFO] [stderr] 405 | | [INFO] [stderr] ... | [INFO] [stderr] 408 | | " [INFO] [stderr] 409 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 411 | / test!(rm_clip_path_2, [INFO] [stderr] 412 | | " [INFO] [stderr] 413 | | [INFO] [stderr] 414 | | [INFO] [stderr] ... | [INFO] [stderr] 417 | | " [INFO] [stderr] 418 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 420 | / test!(rm_clip_path_3, [INFO] [stderr] 421 | | " [INFO] [stderr] 422 | | [INFO] [stderr] 423 | | [INFO] [stderr] ... | [INFO] [stderr] 426 | | " [INFO] [stderr] 427 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 429 | / test!(rm_path_1, [INFO] [stderr] 430 | | " [INFO] [stderr] 431 | | [INFO] [stderr] 432 | | ", [INFO] [stderr] 433 | | " [INFO] [stderr] 434 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 436 | / test!(rm_path_2, [INFO] [stderr] 437 | | " [INFO] [stderr] 438 | | [INFO] [stderr] 439 | | ", [INFO] [stderr] 440 | | " [INFO] [stderr] 441 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 443 | / test!(rm_path_3, [INFO] [stderr] 444 | | " [INFO] [stderr] 445 | | [INFO] [stderr] 446 | | [INFO] [stderr] 447 | | ", [INFO] [stderr] 448 | | " [INFO] [stderr] 449 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / test!(rm_display_none_1, [INFO] [stderr] 452 | | " [INFO] [stderr] 453 | | [INFO] [stderr] 454 | | ", [INFO] [stderr] 455 | | " [INFO] [stderr] 456 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 458 | / test!(rm_display_none_2, [INFO] [stderr] 459 | | " [INFO] [stderr] 460 | | [INFO] [stderr] 461 | | [INFO] [stderr] ... | [INFO] [stderr] 464 | | " [INFO] [stderr] 465 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 467 | / test_eq!(skip_display_none_1, [INFO] [stderr] 468 | | " [INFO] [stderr] 469 | | [INFO] [stderr] 470 | | [INFO] [stderr] ... | [INFO] [stderr] 473 | | [INFO] [stderr] 474 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 476 | / test!(rm_filter_1, [INFO] [stderr] 477 | | " [INFO] [stderr] 478 | | [INFO] [stderr] 479 | | ", [INFO] [stderr] 480 | | " [INFO] [stderr] 481 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 483 | / test!(rm_filter_2, [INFO] [stderr] 484 | | " [INFO] [stderr] 485 | | [INFO] [stderr] 486 | | [INFO] [stderr] 487 | | ", [INFO] [stderr] 488 | | " [INFO] [stderr] 489 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 491 | / test!(rm_use_1, [INFO] [stderr] 492 | | " [INFO] [stderr] 493 | | [INFO] [stderr] 494 | | ", [INFO] [stderr] 495 | | " [INFO] [stderr] 496 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 498 | / test!(rm_gradient_1, [INFO] [stderr] 499 | | " [INFO] [stderr] 500 | | [INFO] [stderr] 501 | | [INFO] [stderr] ... | [INFO] [stderr] 507 | | [INFO] [stderr] 508 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | / test!(rm_gradient_2, [INFO] [stderr] 511 | | " [INFO] [stderr] 512 | | [INFO] [stderr] 513 | | [INFO] [stderr] ... | [INFO] [stderr] 519 | | [INFO] [stderr] 520 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 522 | / test!(rm_gradient_3, [INFO] [stderr] 523 | | " [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | [INFO] [stderr] ... | [INFO] [stderr] 532 | | [INFO] [stderr] 533 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 535 | / test!(rm_rect_1, [INFO] [stderr] 536 | | " [INFO] [stderr] 537 | | [INFO] [stderr] 538 | | [INFO] [stderr] ... | [INFO] [stderr] 541 | | " [INFO] [stderr] 542 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_empty_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/rm_invisible_elems.rs:355:35 [INFO] [stderr] | [INFO] [stderr] 355 | remove_empty_defs(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 544 | / test!(rm_fe_color_matrix_1, [INFO] [stderr] 545 | | " [INFO] [stderr] 546 | | [INFO] [stderr] 547 | | [INFO] [stderr] ... | [INFO] [stderr] 553 | | [INFO] [stderr] 554 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | / test!(rm_text_1, [INFO] [stderr] 256 | | " [INFO] [stderr] 257 | | [INFO] [stderr] 258 | | ", [INFO] [stderr] ... | [INFO] [stderr] 261 | | [INFO] [stderr] 262 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / test!(rm_text_2, [INFO] [stderr] 267 | | " [INFO] [stderr] 268 | | [INFO] [stderr] 269 | | ", [INFO] [stderr] ... | [INFO] [stderr] 272 | | [INFO] [stderr] 273 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | / test!(rm_text_3, [INFO] [stderr] 276 | | " [INFO] [stderr] 277 | | [INFO] [stderr] 278 | | text [INFO] [stderr] ... | [INFO] [stderr] 291 | | [INFO] [stderr] 292 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:294:5 [INFO] [stderr] | [INFO] [stderr] 294 | / test!(rm_text_4, [INFO] [stderr] 295 | | " [INFO] [stderr] 296 | | [INFO] [stderr] 297 | | [INFO] [stderr] ... | [INFO] [stderr] 310 | | [INFO] [stderr] 311 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | / test!(keep_text_1, [INFO] [stderr] 314 | | " [INFO] [stderr] 315 | | [INFO] [stderr] 316 | | text [INFO] [stderr] ... | [INFO] [stderr] 323 | | [INFO] [stderr] 324 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | / test_eq!(keep_text_2, [INFO] [stderr] 328 | | " [INFO] [stderr] 329 | | [INFO] [stderr] 330 | | text [INFO] [stderr] 331 | | [INFO] [stderr] 332 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | / test!(keep_text_3, [INFO] [stderr] 335 | | " [INFO] [stderr] 336 | | [INFO] [stderr] 337 | | Hello [INFO] [stderr] ... | [INFO] [stderr] 348 | | [INFO] [stderr] 349 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | / test_eq!(keep_text_4, [INFO] [stderr] 352 | | " [INFO] [stderr] 353 | | [INFO] [stderr] 354 | | [INFO] [stderr] ... | [INFO] [stderr] 359 | | [INFO] [stderr] 360 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / test_eq!(keep_text_5, [INFO] [stderr] 363 | | " [INFO] [stderr] 364 | | [INFO] [stderr] 365 | | Text [INFO] [stderr] ... | [INFO] [stderr] 368 | | [INFO] [stderr] 369 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | / test_eq!(keep_text_6, [INFO] [stderr] 373 | | " [INFO] [stderr] 374 | | [INFO] [stderr] 375 | | text [INFO] [stderr] 376 | | [INFO] [stderr] 377 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_text_attributes` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | / test_eq!(keep_text_7, [INFO] [stderr] 380 | | " [INFO] [stderr] 381 | | [INFO] [stderr] 382 | | [INFO] [stderr] ... | [INFO] [stderr] 388 | | [INFO] [stderr] 389 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_xml_space` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | / test_space!(space_preserve_1, [INFO] [stderr] 404 | | " [INFO] [stderr] 405 | | [INFO] [stderr] 406 | | [INFO] [stderr] ... | [INFO] [stderr] 415 | | [INFO] [stderr] 416 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_xml_space` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_text_attrs.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | / test_space_eq!(space_preserve_keep_1, [INFO] [stderr] 419 | | " [INFO] [stderr] 420 | | Text [INFO] [stderr] 421 | | Text [INFO] [stderr] ... | [INFO] [stderr] 424 | | [INFO] [stderr] 425 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unreferenced_ids` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unref_ids.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / test!(test_1, [INFO] [stderr] 42 | | " [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | [INFO] [stderr] ... | [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_coordinates` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_coords.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / test!(rm_svg_x_y, [INFO] [stderr] 122 | | " [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | ", [INFO] [stderr] ... | [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_coordinates` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_coords.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / test!(rm_rect_rx_ry, [INFO] [stderr] 131 | | " [INFO] [stderr] 132 | | [INFO] [stderr] 133 | | [INFO] [stderr] ... | [INFO] [stderr] 138 | | [INFO] [stderr] 139 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_coordinates` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_coords.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / test_eq!(rect_rx_ry, [INFO] [stderr] 142 | | " [INFO] [stderr] 143 | | [INFO] [stderr] 144 | | [INFO] [stderr] 145 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_coordinates` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_coords.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / test!(rm_radial_gradient_fx, [INFO] [stderr] 148 | | " [INFO] [stderr] 149 | | [INFO] [stderr] 150 | | ", [INFO] [stderr] ... | [INFO] [stderr] 153 | | [INFO] [stderr] 154 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_coordinates` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_coords.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / test_eq!(keep_radial_gradient_fx_1, [INFO] [stderr] 157 | | " [INFO] [stderr] 158 | | [INFO] [stderr] 159 | | [INFO] [stderr] 160 | | [INFO] [stderr] 161 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_coordinates` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_coords.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / test_eq!(keep_radial_gradient_fx_2, [INFO] [stderr] 164 | | " [INFO] [stderr] 165 | | [INFO] [stderr] 166 | | [INFO] [stderr] 167 | | [INFO] [stderr] 168 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / test!(simple_1, [INFO] [stderr] 95 | | " [INFO] [stderr] 96 | | [INFO] [stderr] 97 | | [INFO] [stderr] ... | [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / test!(recursive_1, [INFO] [stderr] 112 | | " [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | [INFO] [stderr] ... | [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / test!(correct_ungroup_1, [INFO] [stderr] 127 | | " [INFO] [stderr] 128 | | [INFO] [stderr] 129 | | [INFO] [stderr] ... | [INFO] [stderr] 140 | | [INFO] [stderr] 141 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / test_eq!(correct_ungroup_2, [INFO] [stderr] 144 | | " [INFO] [stderr] 145 | | [INFO] [stderr] 146 | | [INFO] [stderr] ... | [INFO] [stderr] 151 | | [INFO] [stderr] 152 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / test_eq!(correct_ungroup_3, [INFO] [stderr] 155 | | " [INFO] [stderr] 156 | | [INFO] [stderr] 157 | | [INFO] [stderr] ... | [INFO] [stderr] 166 | | [INFO] [stderr] 167 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / test!(correct_ungroup_4, [INFO] [stderr] 170 | | " [INFO] [stderr] 171 | | [INFO] [stderr] 172 | | [INFO] [stderr] ... | [INFO] [stderr] 185 | | [INFO] [stderr] 186 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / test!(correct_ungroup_5, [INFO] [stderr] 189 | | " [INFO] [stderr] 190 | | [INFO] [stderr] 191 | | [INFO] [stderr] ... | [INFO] [stderr] 208 | | [INFO] [stderr] 209 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / test!(correct_ungroup_6, [INFO] [stderr] 212 | | " [INFO] [stderr] 213 | | [INFO] [stderr] 214 | | [INFO] [stderr] ... | [INFO] [stderr] 225 | | [INFO] [stderr] 226 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | / test!(keep_font_1, [INFO] [stderr] 229 | | " [INFO] [stderr] 230 | | [INFO] [stderr] 231 | | [INFO] [stderr] ... | [INFO] [stderr] 240 | | [INFO] [stderr] 241 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_unused_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/rm_unused_defs.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / test_eq!(keep_font_2, [INFO] [stderr] 244 | | " [INFO] [stderr] 245 | | [INFO] [stderr] 246 | | [INFO] [stderr] ... | [INFO] [stderr] 252 | | [INFO] [stderr] 253 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/trim_ids.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | fn shift(&mut self, pos: usize, head: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `ungroup_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/ungroup_defs.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / test!(ungroup_1, [INFO] [stderr] 61 | | " [INFO] [stderr] 62 | | [INFO] [stderr] 63 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `ungroup_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/ungroup_defs.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / test!(ungroup_2, [INFO] [stderr] 72 | | " [INFO] [stderr] 73 | | [INFO] [stderr] 74 | | [INFO] [stderr] ... | [INFO] [stderr] 83 | | [INFO] [stderr] 84 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `ungroup_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/ungroup_defs.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / test!(ungroup_3, [INFO] [stderr] 87 | | " [INFO] [stderr] 88 | | [INFO] [stderr] 89 | | [INFO] [stderr] ... | [INFO] [stderr] 96 | | [INFO] [stderr] 97 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `ungroup_defs` doesn't need a mutable reference [INFO] [stderr] --> src/task/macros.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | $functor(&mut doc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/task/ungroup_defs.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / test_eq!(keep_1, [INFO] [stderr] 100 | | " [INFO] [stderr] 101 | | [INFO] [stderr] 102 | | [INFO] [stderr] ... | [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | "); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/apply_transforms/mod.rs:139:72 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn scale_coord(attrs: &mut Attributes, aid: AId, scale_factor: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task/paths/conv_segments.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / if let &SegmentData::MoveTo { x, y } = path.d[i - 1].data() { [INFO] [stderr] 58 | | mx = x; [INFO] [stderr] 59 | | my = y; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | if let SegmentData::MoveTo { x, y } = *path.d[i - 1].data() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/paths/conv_segments.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match *curr_seg.data() { [INFO] [stderr] 143 | | SegmentData::CurveTo { x1, y1, x2, y2, x, y } => { [INFO] [stderr] 144 | | let is_vlineto = || { [INFO] [stderr] 145 | | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => {} [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | if let SegmentData::CurveTo { x1, y1, x2, y2, x, y } = *curr_seg.data() { [INFO] [stderr] 143 | let is_vlineto = || { [INFO] [stderr] 144 | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] 145 | // y1 must be equal or greater than prev_y. [INFO] [stderr] 146 | // y2 must be equal or less than y. [INFO] [stderr] 147 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `svgcleaner`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "32317aecef1118b164aa4504c67e0a6eb05adf2a0cf0d1f6fe01d2c4ab2d0173"` [INFO] running `"docker" "rm" "-f" "32317aecef1118b164aa4504c67e0a6eb05adf2a0cf0d1f6fe01d2c4ab2d0173"` [INFO] [stdout] 32317aecef1118b164aa4504c67e0a6eb05adf2a0cf0d1f6fe01d2c4ab2d0173