[INFO] crate svgbob_cli 0.3.2 is already in cache
[INFO] extracting crate svgbob_cli 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/svgbob_cli/0.3.2
[INFO] extracting crate svgbob_cli 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgbob_cli/0.3.2
[INFO] validating manifest of svgbob_cli-0.3.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of svgbob_cli-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing svgbob_cli-0.3.2
[INFO] finished frobbing svgbob_cli-0.3.2
[INFO] frobbed toml for svgbob_cli-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/svgbob_cli/0.3.2/Cargo.toml
[INFO] started frobbing svgbob_cli-0.3.2
[INFO] finished frobbing svgbob_cli-0.3.2
[INFO] frobbed toml for svgbob_cli-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svgbob_cli/0.3.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting svgbob_cli-0.3.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/svgbob_cli/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5f4498163649457fd9d85ff0a1fd0e979daec77df9a62a83d4efd82ab4fed5f5
[INFO] running `"docker" "start" "-a" "5f4498163649457fd9d85ff0a1fd0e979daec77df9a62a83d4efd82ab4fed5f5"`
[INFO] [stderr]     Checking svg v0.5.12
[INFO] [stderr]     Checking handlebars v0.21.1
[INFO] [stderr]     Checking svgbob v0.3.2
[INFO] [stderr]     Checking svgbob_cli v0.3.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> examples/comic.rs:28:12
[INFO] [stderr]    |
[INFO] [stderr] 28 |       if let Ok(_) = handlebars.template_renderw2(&mut source_template, &context, &mut output_file) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 29 | |         println!("Rendered to {}", html_file);
[INFO] [stderr] 30 | |     } else {
[INFO] [stderr] 31 | |         println!("Error");
[INFO] [stderr] 32 | |     };
[INFO] [stderr]    | |_____- help: try this: `if handlebars.template_renderw2(&mut source_template, &context, &mut output_file).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> examples/memes3.rs:28:12
[INFO] [stderr]    |
[INFO] [stderr] 28 |       if let Ok(_) = handlebars.template_renderw2(&mut source_template, &context, &mut output_file) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 29 | |         println!("Rendered to {}", html_file);
[INFO] [stderr] 30 | |     } else {
[INFO] [stderr] 31 | |         println!("Error");
[INFO] [stderr] 32 | |     };
[INFO] [stderr]    | |_____- help: try this: `if handlebars.template_renderw2(&mut source_template, &context, &mut output_file).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> examples/ascii_art.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |       if let Ok(_) = svg::save(svg_file, &svg) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 18 | |         println!("Saved to {}", svg_file);
[INFO] [stderr] 19 | |     } else {
[INFO] [stderr] 20 | |         println!("Error saving to file {}", svg_file);
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____- help: try this: `if svg::save(svg_file, &svg).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> examples/ascii_art.rs:31:12
[INFO] [stderr]    |
[INFO] [stderr] 31 |       if let Ok(_) = handlebars.template_renderw2(&mut source_template, &context, &mut output_file) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 32 | |         println!("Rendered to {}", html_file);
[INFO] [stderr] 33 | |     } else {
[INFO] [stderr] 34 | |         println!("Error");
[INFO] [stderr] 35 | |     };
[INFO] [stderr]    | |_____- help: try this: `if handlebars.template_renderw2(&mut source_template, &context, &mut output_file).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> examples/demo.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 |     arg
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> examples/demo.rs:16:15
[INFO] [stderr]     |
[INFO] [stderr] 16  |       let arg = r#"
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 17  | |
[INFO] [stderr] 18  | |
[INFO] [stderr] 19  | | +------+   +-----+   +-----+   +-----+
[INFO] [stderr] ...   |
[INFO] [stderr] 125 | |
[INFO] [stderr] 126 | | "#;
[INFO] [stderr]     | |__^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> examples/render.rs:28:12
[INFO] [stderr]    |
[INFO] [stderr] 28 |       if let Ok(_) = handlebars.template_renderw2(&mut source_template, &context, &mut output_file) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 29 | |         println!("Rendered to {}", html_file);
[INFO] [stderr] 30 | |     } else {
[INFO] [stderr] 31 | |         println!("Error");
[INFO] [stderr] 32 | |     };
[INFO] [stderr]    | |_____- help: try this: `if handlebars.template_renderw2(&mut source_template, &context, &mut output_file).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> examples/memes2.rs:28:12
[INFO] [stderr]    |
[INFO] [stderr] 28 |       if let Ok(_) = handlebars.template_renderw2(&mut source_template, &context, &mut output_file) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 29 | |         println!("Rendered to {}", html_file);
[INFO] [stderr] 30 | |     } else {
[INFO] [stderr] 31 | |         println!("Error");
[INFO] [stderr] 32 | |     };
[INFO] [stderr]    | |_____- help: try this: `if handlebars.template_renderw2(&mut source_template, &context, &mut output_file).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:78:12
[INFO] [stderr]     |
[INFO] [stderr] 78  |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 79  | |         if let Some(file) = args.value_of("input") {
[INFO] [stderr] 80  | |             match File::open(file) {
[INFO] [stderr] 81  | |                 Ok(mut f) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |         }
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 78  |     } else if let Some(file) = args.value_of("input") {
[INFO] [stderr] 79  |     match File::open(file) {
[INFO] [stderr] 80  |         Ok(mut f) => {
[INFO] [stderr] 81  |             f.read_to_string(&mut bob).unwrap();
[INFO] [stderr] 82  |         }
[INFO] [stderr] 83  |         Err(e) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/main.rs:146:5
[INFO] [stderr]     |
[INFO] [stderr] 146 | /     return args.value_of(arg_name)
[INFO] [stderr] 147 | |         .and_then(|arg| match arg.parse::<T>() {
[INFO] [stderr] 148 | |             Ok(a) => Some(a),
[INFO] [stderr] 149 | |             Err(e) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |             }
[INFO] [stderr] 161 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 146 |     args.value_of(arg_name)
[INFO] [stderr] 147 |         .and_then(|arg| match arg.parse::<T>() {
[INFO] [stderr] 148 |             Ok(a) => Some(a),
[INFO] [stderr] 149 |             Err(e) => {
[INFO] [stderr] 150 |                 use std::io::Write;
[INFO] [stderr] 151 |                 use std::process::exit;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `svgbob_cli`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:78:12
[INFO] [stderr]     |
[INFO] [stderr] 78  |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 79  | |         if let Some(file) = args.value_of("input") {
[INFO] [stderr] 80  | |             match File::open(file) {
[INFO] [stderr] 81  | |                 Ok(mut f) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |         }
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 78  |     } else if let Some(file) = args.value_of("input") {
[INFO] [stderr] 79  |     match File::open(file) {
[INFO] [stderr] 80  |         Ok(mut f) => {
[INFO] [stderr] 81  |             f.read_to_string(&mut bob).unwrap();
[INFO] [stderr] 82  |         }
[INFO] [stderr] 83  |         Err(e) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/main.rs:146:5
[INFO] [stderr]     |
[INFO] [stderr] 146 | /     return args.value_of(arg_name)
[INFO] [stderr] 147 | |         .and_then(|arg| match arg.parse::<T>() {
[INFO] [stderr] 148 | |             Ok(a) => Some(a),
[INFO] [stderr] 149 | |             Err(e) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |             }
[INFO] [stderr] 161 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 146 |     args.value_of(arg_name)
[INFO] [stderr] 147 |         .and_then(|arg| match arg.parse::<T>() {
[INFO] [stderr] 148 |             Ok(a) => Some(a),
[INFO] [stderr] 149 |             Err(e) => {
[INFO] [stderr] 150 |                 use std::io::Write;
[INFO] [stderr] 151 |                 use std::process::exit;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `svgbob_cli`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "5f4498163649457fd9d85ff0a1fd0e979daec77df9a62a83d4efd82ab4fed5f5"`
[INFO] running `"docker" "rm" "-f" "5f4498163649457fd9d85ff0a1fd0e979daec77df9a62a83d4efd82ab4fed5f5"`
[INFO] [stdout] 5f4498163649457fd9d85ff0a1fd0e979daec77df9a62a83d4efd82ab4fed5f5