[INFO] crate svd2rust 0.14.0 is already in cache [INFO] extracting crate svd2rust 0.14.0 into work/ex/clippy-test-run/sources/stable/reg/svd2rust/0.14.0 [INFO] extracting crate svd2rust 0.14.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svd2rust/0.14.0 [INFO] validating manifest of svd2rust-0.14.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of svd2rust-0.14.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing svd2rust-0.14.0 [INFO] finished frobbing svd2rust-0.14.0 [INFO] frobbed toml for svd2rust-0.14.0 written to work/ex/clippy-test-run/sources/stable/reg/svd2rust/0.14.0/Cargo.toml [INFO] started frobbing svd2rust-0.14.0 [INFO] finished frobbing svd2rust-0.14.0 [INFO] frobbed toml for svd2rust-0.14.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/svd2rust/0.14.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting svd2rust-0.14.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/svd2rust/0.14.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb4e069a72af4625ca48d3123829760f99fb188e22e7b6c6da06c5b96ecaa0ac [INFO] running `"docker" "start" "-a" "eb4e069a72af4625ca48d3123829760f99fb188e22e7b6c6da06c5b96ecaa0ac"` [INFO] [stderr] Compiling svd2rust v0.14.0 (/opt/crater/workdir) [INFO] [stderr] Checking inflections v1.1.1 [INFO] [stderr] Checking svd-parser v0.6.0 [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/generate/interrupt.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | / if !interrupts.is_empty() { [INFO] [stderr] 254 | | if *target != Target::CortexM { [INFO] [stderr] 255 | | root.push(quote! { [INFO] [stderr] 256 | | #[doc(hidden)] [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 253 | if !interrupts.is_empty() && *target != Target::CortexM { [INFO] [stderr] 254 | root.push(quote! { [INFO] [stderr] 255 | #[doc(hidden)] [INFO] [stderr] 256 | pub mod interrupt { [INFO] [stderr] 257 | #(#mod_items)* [INFO] [stderr] 258 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/generate/peripheral.rs:207:16 [INFO] [stderr] | [INFO] [stderr] 207 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 208 | | if first.get(index).is_some() && first[index].chars().all(|c| c.is_numeric()) { [INFO] [stderr] 209 | | Some(first.iter().take(index).cloned().collect()) [INFO] [stderr] 210 | | } else { [INFO] [stderr] 211 | | Some(first.iter().take(index - 1).cloned().collect()) [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | } else if first.get(index).is_some() && first[index].chars().all(|c| c.is_numeric()) { [INFO] [stderr] 208 | Some(first.iter().take(index).cloned().collect()) [INFO] [stderr] 209 | } else { [INFO] [stderr] 210 | Some(first.iter().take(index - 1).cloned().collect()) [INFO] [stderr] 211 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/util.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 149 | | if acc.ends_with("\\") { [INFO] [stderr] 150 | | acc.to_owned() + "[" + &x.to_string() [INFO] [stderr] 151 | | } else { [INFO] [stderr] 152 | | acc.to_owned() + "\\[" + &x.to_string() [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | } else if acc.ends_with("\\") { [INFO] [stderr] 149 | acc.to_owned() + "[" + &x.to_string() [INFO] [stderr] 150 | } else { [INFO] [stderr] 151 | acc.to_owned() + "\\[" + &x.to_string() [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/util.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 161 | | if acc.ends_with("\\") { [INFO] [stderr] 162 | | acc.to_owned() + "]" + &x.to_string() [INFO] [stderr] 163 | | } else { [INFO] [stderr] 164 | | acc.to_owned() + "\\]" + &x.to_string() [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 160 | } else if acc.ends_with("\\") { [INFO] [stderr] 161 | acc.to_owned() + "]" + &x.to_string() [INFO] [stderr] 162 | } else { [INFO] [stderr] 163 | acc.to_owned() + "\\]" + &x.to_string() [INFO] [stderr] 164 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/generate/interrupt.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | / if !interrupts.is_empty() { [INFO] [stderr] 254 | | if *target != Target::CortexM { [INFO] [stderr] 255 | | root.push(quote! { [INFO] [stderr] 256 | | #[doc(hidden)] [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 253 | if !interrupts.is_empty() && *target != Target::CortexM { [INFO] [stderr] 254 | root.push(quote! { [INFO] [stderr] 255 | #[doc(hidden)] [INFO] [stderr] 256 | pub mod interrupt { [INFO] [stderr] 257 | #(#mod_items)* [INFO] [stderr] 258 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/generate/peripheral.rs:207:16 [INFO] [stderr] | [INFO] [stderr] 207 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 208 | | if first.get(index).is_some() && first[index].chars().all(|c| c.is_numeric()) { [INFO] [stderr] 209 | | Some(first.iter().take(index).cloned().collect()) [INFO] [stderr] 210 | | } else { [INFO] [stderr] 211 | | Some(first.iter().take(index - 1).cloned().collect()) [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | } else if first.get(index).is_some() && first[index].chars().all(|c| c.is_numeric()) { [INFO] [stderr] 208 | Some(first.iter().take(index).cloned().collect()) [INFO] [stderr] 209 | } else { [INFO] [stderr] 210 | Some(first.iter().take(index - 1).cloned().collect()) [INFO] [stderr] 211 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/util.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 149 | | if acc.ends_with("\\") { [INFO] [stderr] 150 | | acc.to_owned() + "[" + &x.to_string() [INFO] [stderr] 151 | | } else { [INFO] [stderr] 152 | | acc.to_owned() + "\\[" + &x.to_string() [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | } else if acc.ends_with("\\") { [INFO] [stderr] 149 | acc.to_owned() + "[" + &x.to_string() [INFO] [stderr] 150 | } else { [INFO] [stderr] 151 | acc.to_owned() + "\\[" + &x.to_string() [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/util.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 161 | | if acc.ends_with("\\") { [INFO] [stderr] 162 | | acc.to_owned() + "]" + &x.to_string() [INFO] [stderr] 163 | | } else { [INFO] [stderr] 164 | | acc.to_owned() + "\\]" + &x.to_string() [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 160 | } else if acc.ends_with("\\") { [INFO] [stderr] 161 | acc.to_owned() + "]" + &x.to_string() [INFO] [stderr] 162 | } else { [INFO] [stderr] 163 | acc.to_owned() + "\\]" + &x.to_string() [INFO] [stderr] 164 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generate/device.rs:12:35 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn render(d: &Device, target: &Target, nightly: bool, device_x: &mut String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generate/device.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / let core_peripherals: &[&str]; [INFO] [stderr] 104 | | [INFO] [stderr] 105 | | if fpu_present { [INFO] [stderr] 106 | | core_peripherals = &[ [INFO] [stderr] ... | [INFO] [stderr] 112 | | ]; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 103 | let core_peripherals = if fpu_present { &[ [INFO] [stderr] 104 | "CBP", "CPUID", "DCB", "DWT", "FPB", "FPU", "ITM", "MPU", "NVIC", "SCB", "SYST", "TPIU" [INFO] [stderr] 105 | ] } else { &[ [INFO] [stderr] 106 | "CBP", "CPUID", "DCB", "DWT", "FPB", "ITM", "MPU", "NVIC", "SCB", "SYST", "TPIU" [INFO] [stderr] 107 | ] }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/device.rs:91:37 [INFO] [stderr] | [INFO] [stderr] 91 | let bits = util::unsuffixed(cpu.nvic_priority_bits as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cpu.nvic_priority_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generate/interrupt.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | target: &Target, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `field_num` is used as a loop counter. Consider using `for (field_num, item) in expand_svd_cluster(cluster).iter().enumerate()` or similar iterators [INFO] [stderr] --> src/generate/peripheral.rs:632:30 [INFO] [stderr] | [INFO] [stderr] 632 | for field in expand_svd_cluster(cluster).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `field_num` is used as a loop counter. Consider using `for (field_num, item) in expand_svd_register(register, name).iter().enumerate()` or similar iterators [INFO] [stderr] --> src/generate/peripheral.rs:693:30 [INFO] [stderr] | [INFO] [stderr] 693 | for field in expand_svd_register(register, name).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/peripheral.rs:880:51 [INFO] [stderr] | [INFO] [stderr] 880 | syn::ConstExpr::Lit(syn::Lit::Int(array_info.dim as u64, syn::IntTy::Unsuffixed)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(array_info.dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/peripheral.rs:995:51 [INFO] [stderr] | [INFO] [stderr] 995 | syn::ConstExpr::Lit(syn::Lit::Int(array_info.dim as u64, syn::IntTy::Unsuffixed)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(array_info.dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/generate/register.rs:201:1 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn fields( [INFO] [stderr] 202 | | fields: &[Field], [INFO] [stderr] 203 | | parent: &Register, [INFO] [stderr] 204 | | all_registers: &[&Register], [INFO] [stderr] ... | [INFO] [stderr] 803 | | Ok(()) [INFO] [stderr] 804 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/generate/register.rs:201:1 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn fields( [INFO] [stderr] 202 | | fields: &[Field], [INFO] [stderr] 203 | | parent: &Register, [INFO] [stderr] 204 | | all_registers: &[&Register], [INFO] [stderr] ... | [INFO] [stderr] 803 | | Ok(()) [INFO] [stderr] 804 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/register.rs:809:16 [INFO] [stderr] | [INFO] [stderr] 809 | if range.min as u64 == 0 && range.max as u64 == (1u64 << width) - 1 => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(range.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/register.rs:809:41 [INFO] [stderr] | [INFO] [stderr] 809 | if range.min as u64 == 0 && range.max as u64 == (1u64 << width) - 1 => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(range.max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generate/device.rs:12:35 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn render(d: &Device, target: &Target, nightly: bool, device_x: &mut String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generate/device.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / let core_peripherals: &[&str]; [INFO] [stderr] 104 | | [INFO] [stderr] 105 | | if fpu_present { [INFO] [stderr] 106 | | core_peripherals = &[ [INFO] [stderr] ... | [INFO] [stderr] 112 | | ]; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 103 | let core_peripherals = if fpu_present { &[ [INFO] [stderr] 104 | "CBP", "CPUID", "DCB", "DWT", "FPB", "FPU", "ITM", "MPU", "NVIC", "SCB", "SYST", "TPIU" [INFO] [stderr] 105 | ] } else { &[ [INFO] [stderr] 106 | "CBP", "CPUID", "DCB", "DWT", "FPB", "ITM", "MPU", "NVIC", "SCB", "SYST", "TPIU" [INFO] [stderr] 107 | ] }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/device.rs:91:37 [INFO] [stderr] | [INFO] [stderr] 91 | let bits = util::unsuffixed(cpu.nvic_priority_bits as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cpu.nvic_priority_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | if acc.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:161:34 [INFO] [stderr] | [INFO] [stderr] 161 | if acc.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generate/interrupt.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | target: &Target, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `field_num` is used as a loop counter. Consider using `for (field_num, item) in expand_svd_cluster(cluster).iter().enumerate()` or similar iterators [INFO] [stderr] --> src/generate/peripheral.rs:632:30 [INFO] [stderr] | [INFO] [stderr] 632 | for field in expand_svd_cluster(cluster).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `field_num` is used as a loop counter. Consider using `for (field_num, item) in expand_svd_register(register, name).iter().enumerate()` or similar iterators [INFO] [stderr] --> src/generate/peripheral.rs:693:30 [INFO] [stderr] | [INFO] [stderr] 693 | for field in expand_svd_register(register, name).iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/peripheral.rs:880:51 [INFO] [stderr] | [INFO] [stderr] 880 | syn::ConstExpr::Lit(syn::Lit::Int(array_info.dim as u64, syn::IntTy::Unsuffixed)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(array_info.dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/peripheral.rs:995:51 [INFO] [stderr] | [INFO] [stderr] 995 | syn::ConstExpr::Lit(syn::Lit::Int(array_info.dim as u64, syn::IntTy::Unsuffixed)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(array_info.dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/generate/register.rs:201:1 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn fields( [INFO] [stderr] 202 | | fields: &[Field], [INFO] [stderr] 203 | | parent: &Register, [INFO] [stderr] 204 | | all_registers: &[&Register], [INFO] [stderr] ... | [INFO] [stderr] 803 | | Ok(()) [INFO] [stderr] 804 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/generate/register.rs:201:1 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn fields( [INFO] [stderr] 202 | | fields: &[Field], [INFO] [stderr] 203 | | parent: &Register, [INFO] [stderr] 204 | | all_registers: &[&Register], [INFO] [stderr] ... | [INFO] [stderr] 803 | | Ok(()) [INFO] [stderr] 804 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/register.rs:809:16 [INFO] [stderr] | [INFO] [stderr] 809 | if range.min as u64 == 0 && range.max as u64 == (1u64 << width) - 1 => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(range.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generate/register.rs:809:41 [INFO] [stderr] | [INFO] [stderr] 809 | if range.min as u64 == 0 && range.max as u64 == (1u64 << width) - 1 => [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(range.max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | if acc.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:161:34 [INFO] [stderr] | [INFO] [stderr] 161 | if acc.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.12s [INFO] running `"docker" "inspect" "eb4e069a72af4625ca48d3123829760f99fb188e22e7b6c6da06c5b96ecaa0ac"` [INFO] running `"docker" "rm" "-f" "eb4e069a72af4625ca48d3123829760f99fb188e22e7b6c6da06c5b96ecaa0ac"` [INFO] [stdout] eb4e069a72af4625ca48d3123829760f99fb188e22e7b6c6da06c5b96ecaa0ac