[INFO] crate suppositions 0.1.4 is already in cache [INFO] extracting crate suppositions 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/suppositions/0.1.4 [INFO] extracting crate suppositions 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/suppositions/0.1.4 [INFO] validating manifest of suppositions-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of suppositions-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing suppositions-0.1.4 [INFO] finished frobbing suppositions-0.1.4 [INFO] frobbed toml for suppositions-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/suppositions/0.1.4/Cargo.toml [INFO] started frobbing suppositions-0.1.4 [INFO] finished frobbing suppositions-0.1.4 [INFO] frobbed toml for suppositions-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/suppositions/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting suppositions-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/suppositions/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 766fe02898e118af655c0631db50a21677e1efe887094afe8b36d973e9863c0f [INFO] running `"docker" "start" "-a" "766fe02898e118af655c0631db50a21677e1efe887094afe8b36d973e9863c0f"` [INFO] [stderr] Checking suppositions v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | InfoPool { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generators.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | num_tests: num_tests, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | gen: gen, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | InfoPool { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generators.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | num_tests: num_tests, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | gen: gen, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::InfoPool` [INFO] [stderr] --> src/data.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | Self { data: Vec::new() } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/data.rs:133:8 [INFO] [stderr] | [INFO] [stderr] 133 | if p.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `p.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: trait `OneOfItem` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/generators.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / pub trait OneOfItem { [INFO] [stderr] 63 | | /// The generator type. [INFO] [stderr] 64 | | type Item; [INFO] [stderr] 65 | | /// The number of cases reachable from this one. [INFO] [stderr] ... | [INFO] [stderr] 75 | | ) -> Maybe; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/generators.rs:320:49 [INFO] [stderr] | [INFO] [stderr] 320 | val = val.wrapping_shl(8) | src.next().ok_or(DataError::PoolExhausted)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(src.next().ok_or(DataError::PoolExhausted)?)` [INFO] [stderr] ... [INFO] [stderr] 330 | unsigned_integer_gen!(u16s, u16); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/generators.rs:320:49 [INFO] [stderr] | [INFO] [stderr] 320 | val = val.wrapping_shl(8) | src.next().ok_or(DataError::PoolExhausted)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(src.next().ok_or(DataError::PoolExhausted)?)` [INFO] [stderr] ... [INFO] [stderr] 331 | unsigned_integer_gen!(u32s, u32); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generators.rs:320:49 [INFO] [stderr] | [INFO] [stderr] 320 | val = val.wrapping_shl(8) | src.next().ok_or(DataError::PoolExhausted)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(src.next().ok_or(DataError::PoolExhausted)?)` [INFO] [stderr] ... [INFO] [stderr] 332 | unsigned_integer_gen!(u64s, u64); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/generators.rs:705:34 [INFO] [stderr] | [INFO] [stderr] 705 | gen.generate(&mut t).map(|v| check(v)).unwrap_or(false) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::InfoPool` [INFO] [stderr] --> src/data.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | Self { data: Vec::new() } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/data.rs:133:8 [INFO] [stderr] | [INFO] [stderr] 133 | if p.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `p.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: trait `OneOfItem` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/generators.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / pub trait OneOfItem { [INFO] [stderr] 63 | | /// The generator type. [INFO] [stderr] 64 | | type Item; [INFO] [stderr] 65 | | /// The number of cases reachable from this one. [INFO] [stderr] ... | [INFO] [stderr] 75 | | ) -> Maybe; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/generators.rs:320:49 [INFO] [stderr] | [INFO] [stderr] 320 | val = val.wrapping_shl(8) | src.next().ok_or(DataError::PoolExhausted)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(src.next().ok_or(DataError::PoolExhausted)?)` [INFO] [stderr] ... [INFO] [stderr] 330 | unsigned_integer_gen!(u16s, u16); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/generators.rs:320:49 [INFO] [stderr] | [INFO] [stderr] 320 | val = val.wrapping_shl(8) | src.next().ok_or(DataError::PoolExhausted)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(src.next().ok_or(DataError::PoolExhausted)?)` [INFO] [stderr] ... [INFO] [stderr] 331 | unsigned_integer_gen!(u32s, u32); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generators.rs:320:49 [INFO] [stderr] | [INFO] [stderr] 320 | val = val.wrapping_shl(8) | src.next().ok_or(DataError::PoolExhausted)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(src.next().ok_or(DataError::PoolExhausted)?)` [INFO] [stderr] ... [INFO] [stderr] 332 | unsigned_integer_gen!(u64s, u64); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/generators.rs:705:34 [INFO] [stderr] | [INFO] [stderr] 705 | gen.generate(&mut t).map(|v| check(v)).unwrap_or(false) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/generators.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | ).check(|(v0, v1)| v0 == v1) [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(v0 - v1).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/generators.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | ).check(|(v0, v1)| v0 == v1) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/generators.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | ).check(|(v0, v1)| v0 == v1) [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(v0 - v1).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/generators.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | ).check(|(v0, v1)| v0 == v1) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> tests/generators.rs:129:28 [INFO] [stderr] | [INFO] [stderr] 129 | property(u8s().map(|v| (v as u16) * 2)).check(|v| v % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `suppositions`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/die-hard.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/die-hard.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match op { [INFO] [stderr] 41 | | &Op::FillSmallJug => { [INFO] [stderr] 42 | | self.small = 3; [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *op { [INFO] [stderr] 41 | Op::FillSmallJug => { [INFO] [stderr] 42 | self.small = 3; [INFO] [stderr] 43 | } [INFO] [stderr] 44 | Op::FillBigJug => self.big = 5, [INFO] [stderr] 45 | Op::EmptySmallJug => self.small = 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/smoketest.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return rev2 == l; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rev2 == l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/smoketest.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return rev2 == l; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rev2 == l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | property((booleans())).check(|_| false) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | property((booleans())).check(|_| false) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | property((booleans())).check(|_| true) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | property((booleans())).check(|_| true) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | property((booleans())).check(|_| -> Result<(), ()> { Err(()) }) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | property((booleans())).check(|_| -> Result<(), ()> { Err(()) }) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:83:14 [INFO] [stderr] | [INFO] [stderr] 83 | property((booleans())).check(|_| -> Result<(), &'static str> { Err("horrible failure") }) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:83:14 [INFO] [stderr] | [INFO] [stderr] 83 | property((booleans())).check(|_| -> Result<(), &'static str> { Err("horrible failure") }) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | property((booleans())).check(|_| -> Result<(), ()> { Ok(()) }) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | property((booleans())).check(|_| -> Result<(), ()> { Ok(()) }) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | property((booleans())).check(|_| -> () { panic!("Big bad boom") }) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | property((booleans())).check(|_| -> () { panic!("Big bad boom") }) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/smoketest.rs:95:38 [INFO] [stderr] | [INFO] [stderr] 95 | property((booleans())).check(|_| -> () { panic!("Big bad boom") }) [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> tests/smoketest.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | property((booleans())).check(|_| -> () { panic!("Big bad boom") }) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> tests/smoketest.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | property((booleans())).check(|_| -> () { panic!("Big bad boom") }) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/smoketest.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | property((booleans())).check(|_| -> () { panic!("Big bad boom") }) [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/recursive.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Expr::Lit(n) => n as u64, [INFO] [stderr] 31 | | &Expr::Add(ref a, ref b) => a.eval() + b.eval(), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Expr::Lit(n) => n as u64, [INFO] [stderr] 31 | Expr::Add(ref a, ref b) => a.eval() + b.eval(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/recursive.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | &Expr::Lit(n) => n as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> tests/smoketest.rs:26:55 [INFO] [stderr] | [INFO] [stderr] 26 | info!("in:{:?}; out:{:?}; ok? {:?}", l, rev2, &rev2 == &l); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 26 | info!("in:{:?}; out:{:?}; ok? {:?}", l, rev2, rev2 == l); [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/smoketest.rs:47:31 [INFO] [stderr] | [INFO] [stderr] 47 | let primep = is_prime(n as u64); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "766fe02898e118af655c0631db50a21677e1efe887094afe8b36d973e9863c0f"` [INFO] running `"docker" "rm" "-f" "766fe02898e118af655c0631db50a21677e1efe887094afe8b36d973e9863c0f"` [INFO] [stdout] 766fe02898e118af655c0631db50a21677e1efe887094afe8b36d973e9863c0f