[INFO] crate supercow 0.1.0 is already in cache [INFO] extracting crate supercow 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/supercow/0.1.0 [INFO] extracting crate supercow 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/supercow/0.1.0 [INFO] validating manifest of supercow-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of supercow-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing supercow-0.1.0 [INFO] finished frobbing supercow-0.1.0 [INFO] frobbed toml for supercow-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/supercow/0.1.0/Cargo.toml [INFO] started frobbing supercow-0.1.0 [INFO] finished frobbing supercow-0.1.0 [INFO] frobbed toml for supercow-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/supercow/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting supercow-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/supercow/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c308bbdd779ae872937f195054ac9467e82e978c86246419d5a96983b59b11c [INFO] running `"docker" "start" "-a" "6c308bbdd779ae872937f195054ac9467e82e978c86246419d5a96983b59b11c"` [INFO] [stderr] Checking supercow v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/ext.rs:506:24 [INFO] [stderr] | [INFO] [stderr] 506 | fn new() -> Self { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:1614:9 [INFO] [stderr] | [INFO] [stderr] 1614 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:1604:19 [INFO] [stderr] | [INFO] [stderr] 1604 | let ret = Supercow { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1605 | | ptr: (), [INFO] [stderr] 1606 | | // mem::replace is critical for safety, otherwise we would [INFO] [stderr] 1607 | | // double-free when `this` is dropped. [INFO] [stderr] ... | [INFO] [stderr] 1612 | | _shared: PhantomData, [INFO] [stderr] 1613 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/ext.rs:506:24 [INFO] [stderr] | [INFO] [stderr] 506 | fn new() -> Self { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:1614:9 [INFO] [stderr] | [INFO] [stderr] 1614 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:1604:19 [INFO] [stderr] | [INFO] [stderr] 1604 | let ret = Supercow { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1605 | | ptr: (), [INFO] [stderr] 1606 | | // mem::replace is critical for safety, otherwise we would [INFO] [stderr] 1607 | | // double-free when `this` is dropped. [INFO] [stderr] ... | [INFO] [stderr] 1612 | | _shared: PhantomData, [INFO] [stderr] 1613 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | fn borrow_replacement<'a>(ptr: &'a T) -> &'a T; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | unsafe fn get_ptr_a<'a>(&'a self, ptr: *mut ()) -> &'a A; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:254:5 [INFO] [stderr] | [INFO] [stderr] 254 | unsafe fn get_ptr_b<'a>(&'a self, ptr: *mut ()) -> &'a B; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | unsafe fn get_mut_a<'a>(&'a mut self, ptr: *mut ()) -> &'a mut A; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | unsafe fn get_mut_b<'a>(&'a mut self, ptr: *mut ()) -> &'a mut B; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | / unsafe fn get_ptr_a<'a>(&'a self, _: *mut ()) -> &'a A { [INFO] [stderr] 331 | | match self.0 { [INFO] [stderr] 332 | | InlineStorageImpl::A(ref r) => r, [INFO] [stderr] 333 | | _ => unreachable!(), [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / unsafe fn get_ptr_b<'a>(&'a self, _: *mut ()) -> &'a B { [INFO] [stderr] 339 | | match self.0 { [INFO] [stderr] 340 | | InlineStorageImpl::B(ref r) => r, [INFO] [stderr] 341 | | _ => unreachable!(), [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / unsafe fn get_mut_a<'a>(&'a mut self, _: *mut ()) -> &'a mut A { [INFO] [stderr] 347 | | match self.0 { [INFO] [stderr] 348 | | InlineStorageImpl::A(ref mut r) => r, [INFO] [stderr] 349 | | _ => unreachable!(), [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | / unsafe fn get_mut_b<'a>(&'a mut self, _: *mut ()) -> &'a mut B { [INFO] [stderr] 355 | | match self.0 { [INFO] [stderr] 356 | | InlineStorageImpl::B(ref mut r) => r, [INFO] [stderr] 357 | | _ => unreachable!(), [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | / unsafe fn get_ptr_a<'a>(&'a self, ptr: *mut ()) -> &'a A { [INFO] [stderr] 431 | | &(*(ptr as *const Aligned)).1 [INFO] [stderr] 432 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / unsafe fn get_ptr_b<'a>(&'a self, ptr: *mut ()) -> &'a B { [INFO] [stderr] 436 | | &(*(ptr as *const Aligned)).1 [INFO] [stderr] 437 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:440:5 [INFO] [stderr] | [INFO] [stderr] 440 | / unsafe fn get_mut_a<'a>(&'a mut self, ptr: *mut ()) -> &'a mut A { [INFO] [stderr] 441 | | &mut(*(ptr as *mut Aligned)).1 [INFO] [stderr] 442 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | / unsafe fn get_mut_b<'a>(&'a mut self, ptr: *mut ()) -> &'a mut B { [INFO] [stderr] 446 | | &mut(*(ptr as *mut Aligned)).1 [INFO] [stderr] 447 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut ext::TwoStepArc`) [INFO] [stderr] --> src/lib.rs:941:27 [INFO] [stderr] | [INFO] [stderr] 941 | &mut* ($feature_name::self_address_mut(&mut **self) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 942 | | as *mut $twostep_inner)) [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 949 | / supercow_features!( [INFO] [stderr] 950 | | /// The default shared reference type for `Supercow`. [INFO] [stderr] 951 | | /// [INFO] [stderr] 952 | | /// This requires the shared reference type to be `Clone`, `Send`, and [INFO] [stderr] ... | [INFO] [stderr] 957 | | /// See also `NonSyncFeatures`. [INFO] [stderr] 958 | | pub trait DefaultFeatures: Clone, TwoStepShared(TwoStepArc), Send, Sync); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut ext::TwoStepRc`) [INFO] [stderr] --> src/lib.rs:941:27 [INFO] [stderr] | [INFO] [stderr] 941 | &mut* ($feature_name::self_address_mut(&mut **self) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 942 | | as *mut $twostep_inner)) [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 959 | / supercow_features!( [INFO] [stderr] 960 | | /// The shared reference type for `NonSyncSupercow`. [INFO] [stderr] 961 | | /// [INFO] [stderr] 962 | | /// Unlike `DefaultFeatures`, this only requires the shared reference type [INFO] [stderr] 963 | | /// to be `Clone`, thus permitting `Rc`. [INFO] [stderr] 964 | | pub trait NonSyncFeatures: Clone, TwoStepShared(TwoStepRc)); [INFO] [stderr] | |________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:1452:23 [INFO] [stderr] | [INFO] [stderr] 1452 | pub fn into_inner(mut this: Self) -> OWNED [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:1476:5 [INFO] [stderr] | [INFO] [stderr] 1476 | / pub fn to_mut<'b>(&'b mut self) -> Ref<'b, Self> [INFO] [stderr] 1477 | | where OWNED : SafeBorrow, [INFO] [stderr] 1478 | | BORROWED : ToOwned, [INFO] [stderr] 1479 | | PTR : PtrRead [INFO] [stderr] ... | [INFO] [stderr] 1500 | | } [INFO] [stderr] 1501 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:1923:5 [INFO] [stderr] | [INFO] [stderr] 1923 | / fn ne(&self, other: &T) -> bool { [INFO] [stderr] 1924 | | **self != *other.borrow() [INFO] [stderr] 1925 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:2000:13 [INFO] [stderr] | [INFO] [stderr] 2000 | mem::transmute(&self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const Self as *const usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:2012:13 [INFO] [stderr] | [INFO] [stderr] 2012 | mem::transmute(&mut self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self as *mut Self as *mut usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:2022:13 [INFO] [stderr] | [INFO] [stderr] 2022 | mem::transmute(saddr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(saddr as *mut usize as *mut Self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `supercow`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | fn borrow_replacement<'a>(ptr: &'a T) -> &'a T; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | unsafe fn get_ptr_a<'a>(&'a self, ptr: *mut ()) -> &'a A; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:254:5 [INFO] [stderr] | [INFO] [stderr] 254 | unsafe fn get_ptr_b<'a>(&'a self, ptr: *mut ()) -> &'a B; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | unsafe fn get_mut_a<'a>(&'a mut self, ptr: *mut ()) -> &'a mut A; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | unsafe fn get_mut_b<'a>(&'a mut self, ptr: *mut ()) -> &'a mut B; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | / unsafe fn get_ptr_a<'a>(&'a self, _: *mut ()) -> &'a A { [INFO] [stderr] 331 | | match self.0 { [INFO] [stderr] 332 | | InlineStorageImpl::A(ref r) => r, [INFO] [stderr] 333 | | _ => unreachable!(), [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / unsafe fn get_ptr_b<'a>(&'a self, _: *mut ()) -> &'a B { [INFO] [stderr] 339 | | match self.0 { [INFO] [stderr] 340 | | InlineStorageImpl::B(ref r) => r, [INFO] [stderr] 341 | | _ => unreachable!(), [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / unsafe fn get_mut_a<'a>(&'a mut self, _: *mut ()) -> &'a mut A { [INFO] [stderr] 347 | | match self.0 { [INFO] [stderr] 348 | | InlineStorageImpl::A(ref mut r) => r, [INFO] [stderr] 349 | | _ => unreachable!(), [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | / unsafe fn get_mut_b<'a>(&'a mut self, _: *mut ()) -> &'a mut B { [INFO] [stderr] 355 | | match self.0 { [INFO] [stderr] 356 | | InlineStorageImpl::B(ref mut r) => r, [INFO] [stderr] 357 | | _ => unreachable!(), [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | / unsafe fn get_ptr_a<'a>(&'a self, ptr: *mut ()) -> &'a A { [INFO] [stderr] 431 | | &(*(ptr as *const Aligned)).1 [INFO] [stderr] 432 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / unsafe fn get_ptr_b<'a>(&'a self, ptr: *mut ()) -> &'a B { [INFO] [stderr] 436 | | &(*(ptr as *const Aligned)).1 [INFO] [stderr] 437 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:440:5 [INFO] [stderr] | [INFO] [stderr] 440 | / unsafe fn get_mut_a<'a>(&'a mut self, ptr: *mut ()) -> &'a mut A { [INFO] [stderr] 441 | | &mut(*(ptr as *mut Aligned)).1 [INFO] [stderr] 442 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ext.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | / unsafe fn get_mut_b<'a>(&'a mut self, ptr: *mut ()) -> &'a mut B { [INFO] [stderr] 446 | | &mut(*(ptr as *mut Aligned)).1 [INFO] [stderr] 447 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut ext::TwoStepArc`) [INFO] [stderr] --> src/lib.rs:941:27 [INFO] [stderr] | [INFO] [stderr] 941 | &mut* ($feature_name::self_address_mut(&mut **self) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 942 | | as *mut $twostep_inner)) [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 949 | / supercow_features!( [INFO] [stderr] 950 | | /// The default shared reference type for `Supercow`. [INFO] [stderr] 951 | | /// [INFO] [stderr] 952 | | /// This requires the shared reference type to be `Clone`, `Send`, and [INFO] [stderr] ... | [INFO] [stderr] 957 | | /// See also `NonSyncFeatures`. [INFO] [stderr] 958 | | pub trait DefaultFeatures: Clone, TwoStepShared(TwoStepArc), Send, Sync); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut ext::TwoStepRc`) [INFO] [stderr] --> src/lib.rs:941:27 [INFO] [stderr] | [INFO] [stderr] 941 | &mut* ($feature_name::self_address_mut(&mut **self) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 942 | | as *mut $twostep_inner)) [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 959 | / supercow_features!( [INFO] [stderr] 960 | | /// The shared reference type for `NonSyncSupercow`. [INFO] [stderr] 961 | | /// [INFO] [stderr] 962 | | /// Unlike `DefaultFeatures`, this only requires the shared reference type [INFO] [stderr] 963 | | /// to be `Clone`, thus permitting `Rc`. [INFO] [stderr] 964 | | pub trait NonSyncFeatures: Clone, TwoStepShared(TwoStepRc)); [INFO] [stderr] | |________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:1452:23 [INFO] [stderr] | [INFO] [stderr] 1452 | pub fn into_inner(mut this: Self) -> OWNED [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:1476:5 [INFO] [stderr] | [INFO] [stderr] 1476 | / pub fn to_mut<'b>(&'b mut self) -> Ref<'b, Self> [INFO] [stderr] 1477 | | where OWNED : SafeBorrow, [INFO] [stderr] 1478 | | BORROWED : ToOwned, [INFO] [stderr] 1479 | | PTR : PtrRead [INFO] [stderr] ... | [INFO] [stderr] 1500 | | } [INFO] [stderr] 1501 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:1923:5 [INFO] [stderr] | [INFO] [stderr] 1923 | / fn ne(&self, other: &T) -> bool { [INFO] [stderr] 1924 | | **self != *other.borrow() [INFO] [stderr] 1925 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:2000:13 [INFO] [stderr] | [INFO] [stderr] 2000 | mem::transmute(&self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const Self as *const usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:2012:13 [INFO] [stderr] | [INFO] [stderr] 2012 | mem::transmute(&mut self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self as *mut Self as *mut usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:2022:13 [INFO] [stderr] | [INFO] [stderr] 2022 | mem::transmute(saddr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(saddr as *mut usize as *mut Self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/lib.rs:2079:23 [INFO] [stderr] | [INFO] [stderr] 2079 | fn add_two_cow(a: &Cow, b: &Cow) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/lib.rs:2079:37 [INFO] [stderr] | [INFO] [stderr] 2079 | fn add_two_cow(a: &Cow, b: &Cow) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2226:17 [INFO] [stderr] | [INFO] [stderr] 2226 | assert!("hello".to_owned() == *s || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2523 | tests!(inline_sync_tests, InlineSupercow, InlinePhantomcow); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2227:17 [INFO] [stderr] | [INFO] [stderr] 2227 | "world".to_owned() == *s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2523 | tests!(inline_sync_tests, InlineSupercow, InlinePhantomcow); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2226:17 [INFO] [stderr] | [INFO] [stderr] 2226 | assert!("hello".to_owned() == *s || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2524 | tests!(inline_nonsync_tests, InlineNonSyncSupercow, InlineNonSyncPhantomcow); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2227:17 [INFO] [stderr] | [INFO] [stderr] 2227 | "world".to_owned() == *s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2524 | tests!(inline_nonsync_tests, InlineNonSyncSupercow, InlineNonSyncPhantomcow); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2226:17 [INFO] [stderr] | [INFO] [stderr] 2226 | assert!("hello".to_owned() == *s || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2525 | tests!(boxed_sync_tests, Supercow, Phantomcow); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2227:17 [INFO] [stderr] | [INFO] [stderr] 2227 | "world".to_owned() == *s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2525 | tests!(boxed_sync_tests, Supercow, Phantomcow); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2226:17 [INFO] [stderr] | [INFO] [stderr] 2226 | assert!("hello".to_owned() == *s || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2526 | tests!(boxed_nonsync_tests, NonSyncSupercow, NonSyncPhantomcow); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:2227:17 [INFO] [stderr] | [INFO] [stderr] 2227 | "world".to_owned() == *s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] ... [INFO] [stderr] 2526 | tests!(boxed_nonsync_tests, NonSyncSupercow, NonSyncPhantomcow); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `supercow`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6c308bbdd779ae872937f195054ac9467e82e978c86246419d5a96983b59b11c"` [INFO] running `"docker" "rm" "-f" "6c308bbdd779ae872937f195054ac9467e82e978c86246419d5a96983b59b11c"` [INFO] [stdout] 6c308bbdd779ae872937f195054ac9467e82e978c86246419d5a96983b59b11c