[INFO] crate sulfur 0.1.0 is already in cache [INFO] extracting crate sulfur 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/sulfur/0.1.0 [INFO] extracting crate sulfur 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sulfur/0.1.0 [INFO] validating manifest of sulfur-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sulfur-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sulfur-0.1.0 [INFO] finished frobbing sulfur-0.1.0 [INFO] frobbed toml for sulfur-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/sulfur/0.1.0/Cargo.toml [INFO] started frobbing sulfur-0.1.0 [INFO] finished frobbing sulfur-0.1.0 [INFO] frobbed toml for sulfur-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sulfur/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sulfur-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sulfur/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd085b6da0e761bd14e8f0a581ad8af3497845321daa1910d2987890feb31291 [INFO] running `"docker" "start" "-a" "dd085b6da0e761bd14e8f0a581ad8af3497845321daa1910d2987890feb31291"` [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Compiling headers-derive v0.0.2 [INFO] [stderr] Checking headers-core v0.0.2 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking block-padding v0.1.3 [INFO] [stderr] Checking block-buffer v0.7.2 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking headers-ext v0.0.4 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking warp v0.1.11 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking sulfur v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:278:17 [INFO] [stderr] | [INFO] [stderr] 278 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:278:17 [INFO] [stderr] | [INFO] [stderr] 278 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | / return self [INFO] [stderr] 240 | | .session_id [INFO] [stderr] 241 | | .as_ref() [INFO] [stderr] 242 | | .map(|r| &**r) [INFO] [stderr] 243 | | .ok_or_else(|| failure::err_msg("No current session")); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 239 | self [INFO] [stderr] 240 | .session_id [INFO] [stderr] 241 | .as_ref() [INFO] [stderr] 242 | .map(|r| &**r) [INFO] [stderr] 243 | .ok_or_else(|| failure::err_msg("No current session")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | / return self [INFO] [stderr] 240 | | .session_id [INFO] [stderr] 241 | | .as_ref() [INFO] [stderr] 242 | | .map(|r| &**r) [INFO] [stderr] 243 | | .ok_or_else(|| failure::err_msg("No current session")); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 239 | self [INFO] [stderr] 240 | .session_id [INFO] [stderr] 241 | .as_ref() [INFO] [stderr] 242 | .map(|r| &**r) [INFO] [stderr] 243 | .ok_or_else(|| failure::err_msg("No current session")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/canary.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/canary.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | const TEST_HTML_DIR: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/tests/html"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> tests/canary.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | let () = s.click(&elt).expect("click"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> tests/canary.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | let () = s.send_keys(&text, "Canary text").expect("send_keys"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> tests/canary.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | let () = s.click(&button).expect("click"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.45s [INFO] running `"docker" "inspect" "dd085b6da0e761bd14e8f0a581ad8af3497845321daa1910d2987890feb31291"` [INFO] running `"docker" "rm" "-f" "dd085b6da0e761bd14e8f0a581ad8af3497845321daa1910d2987890feb31291"` [INFO] [stdout] dd085b6da0e761bd14e8f0a581ad8af3497845321daa1910d2987890feb31291