[INFO] crate sudo_pair 0.11.1 is already in cache [INFO] extracting crate sudo_pair 0.11.1 into work/ex/clippy-test-run/sources/stable/reg/sudo_pair/0.11.1 [INFO] extracting crate sudo_pair 0.11.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sudo_pair/0.11.1 [INFO] validating manifest of sudo_pair-0.11.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sudo_pair-0.11.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sudo_pair-0.11.1 [INFO] finished frobbing sudo_pair-0.11.1 [INFO] frobbed toml for sudo_pair-0.11.1 written to work/ex/clippy-test-run/sources/stable/reg/sudo_pair/0.11.1/Cargo.toml [INFO] started frobbing sudo_pair-0.11.1 [INFO] finished frobbing sudo_pair-0.11.1 [INFO] frobbed toml for sudo_pair-0.11.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sudo_pair/0.11.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sudo_pair-0.11.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sudo_pair/0.11.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f99f724839ae99bcce46244a39d0f7581848ba788a5e97b2eba8fc45d71f9954 [INFO] running `"docker" "start" "-a" "f99f724839ae99bcce46244a39d0f7581848ba788a5e97b2eba8fc45d71f9954"` [INFO] [stderr] Compiling memchr v1.0.2 [INFO] [stderr] Compiling which v1.0.5 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling env_logger v0.5.13 [INFO] [stderr] Compiling clang-sys v0.23.0 [INFO] [stderr] Compiling nom v3.2.1 [INFO] [stderr] Compiling cexpr v0.2.3 [INFO] [stderr] Compiling bindgen v0.37.4 [INFO] [stderr] Compiling sudo_plugin-sys v1.1.0 [INFO] [stderr] Checking sudo_plugin v1.1.0 [INFO] [stderr] Checking sudo_pair v0.11.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | #![cfg_attr(feature="cargo-clippy", warn(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | #![cfg_attr(feature="cargo-clippy", warn(clippy_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_correctness` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_correctness))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::correctness` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_perf` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | #![cfg_attr(feature="cargo-clippy", warn(clippy_perf))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::perf` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_style` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", warn(clippy_style))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::style` [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/socket.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | gid: gid_t, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::similar_names)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/socket.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | uid: uid_t, [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `g_id` [INFO] [stderr] --> src/socket.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | gid: gid_t, [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | #![cfg_attr(feature="cargo-clippy", warn(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | #![cfg_attr(feature="cargo-clippy", warn(clippy_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_correctness` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_correctness))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::correctness` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_perf` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | #![cfg_attr(feature="cargo-clippy", warn(clippy_perf))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::perf` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_style` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", warn(clippy_style))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::style` [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/socket.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | gid: gid_t, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::similar_names)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/socket.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | uid: uid_t, [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `g_id` [INFO] [stderr] --> src/socket.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | gid: gid_t, [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | #![cfg_attr(feature="cargo-clippy", warn(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | #![cfg_attr(feature="cargo-clippy", warn(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `similar_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/socket.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | #[cfg_attr(feature="cargo-clippy", allow(similar_names))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::similar_names` [INFO] [stderr] [INFO] [stderr] warning: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition [INFO] [stderr] --> src/lib.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | use template::Spec; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use `crate`: `crate::template::Spec` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | #![warn(rust_2018_compatibility)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(absolute_paths_not_starting_with_crate)] implied by #[warn(rust_2018_compatibility)] [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #53130 [INFO] [stderr] [INFO] [stderr] warning: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | use socket::Socket; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use `crate`: `crate::socket::Socket` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #53130 [INFO] [stderr] [INFO] [stderr] warning: lint name `similar_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/socket.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | #[cfg_attr(feature="cargo-clippy", allow(similar_names))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::similar_names` [INFO] [stderr] [INFO] [stderr] warning: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition [INFO] [stderr] --> src/lib.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | use template::Spec; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use `crate`: `crate::template::Spec` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | #![warn(rust_2018_compatibility)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(absolute_paths_not_starting_with_crate)] implied by #[warn(rust_2018_compatibility)] [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #53130 [INFO] [stderr] [INFO] [stderr] warning: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | use socket::Socket; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use `crate`: `crate::socket::Socket` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #53130 [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/template.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | let _ = spec.replace(b'a', &b"foo"[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", warn(clippy_style))] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] implied by #[warn(clippy::style)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/template.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let _ = spec.replace(b'b', &b"bar"[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/template.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | let _ = spec.replace(b'a', &b"x"[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/template.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | let _ = spec.replace(b'b', &b"y"[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.07s [INFO] running `"docker" "inspect" "f99f724839ae99bcce46244a39d0f7581848ba788a5e97b2eba8fc45d71f9954"` [INFO] running `"docker" "rm" "-f" "f99f724839ae99bcce46244a39d0f7581848ba788a5e97b2eba8fc45d71f9954"` [INFO] [stdout] f99f724839ae99bcce46244a39d0f7581848ba788a5e97b2eba8fc45d71f9954