[INFO] crate subprocess 0.1.17 is already in cache
[INFO] extracting crate subprocess 0.1.17 into work/ex/clippy-test-run/sources/stable/reg/subprocess/0.1.17
[INFO] extracting crate subprocess 0.1.17 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/subprocess/0.1.17
[INFO] validating manifest of subprocess-0.1.17 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of subprocess-0.1.17 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing subprocess-0.1.17
[INFO] finished frobbing subprocess-0.1.17
[INFO] frobbed toml for subprocess-0.1.17 written to work/ex/clippy-test-run/sources/stable/reg/subprocess/0.1.17/Cargo.toml
[INFO] started frobbing subprocess-0.1.17
[INFO] finished frobbing subprocess-0.1.17
[INFO] frobbed toml for subprocess-0.1.17 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/subprocess/0.1.17/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting subprocess-0.1.17 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/subprocess/0.1.17:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5d6df6bbcc9dafc3f7b7f7de8af3be36b8afb14405c93ebec1c8e9ceee175a4e
[INFO] running `"docker" "start" "-a" "5d6df6bbcc9dafc3f7b7f7de8af3be36b8afb14405c93ebec1c8e9ceee175a4e"`
[INFO] [stderr]     Checking subprocess v0.1.17 (/opt/crater/workdir)
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/popen.rs:540:33
[INFO] [stderr]     |
[INFO] [stderr] 540 |                              -> IoResult<(Option<Vec<u8>>, Option<Vec<u8>>)> {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:711:21
[INFO] [stderr]     |
[INFO] [stderr] 711 |                     error_buf[0] as u32 | (error_buf[1] as u32) << 8
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:711:43
[INFO] [stderr]     |
[INFO] [stderr] 711 |                     error_buf[0] as u32 | (error_buf[1] as u32) << 8
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:712:23
[INFO] [stderr]     |
[INFO] [stderr] 712 |                     | (error_buf[2] as u32) << 16 | (error_buf[3] as u32) << 24;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:712:53
[INFO] [stderr]     |
[INFO] [stderr] 712 |                     | (error_buf[2] as u32) << 16 | (error_buf[3] as u32) << 24;
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/communicate.rs:103:27
[INFO] [stderr]     |
[INFO] [stderr] 103 |                        -> IoResult<(Option<Vec<u8>>, Option<Vec<u8>>)> {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/posix.rs:257:26
[INFO] [stderr]     |
[INFO] [stderr] 257 |     unsafe { libc::_exit(status as c_int) }
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^ help: try: `i32::from(status)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/os_common.rs:36:20
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn success(&self) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/os_common.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         if let &ExitStatus::Exited(0) = self {
[INFO] [stderr] 38 | |             true
[INFO] [stderr] 39 | |         } else {
[INFO] [stderr] 40 | |             false
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if let ExitStatus::Exited(0) = *self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/popen.rs:540:33
[INFO] [stderr]     |
[INFO] [stderr] 540 |                              -> IoResult<(Option<Vec<u8>>, Option<Vec<u8>>)> {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:711:21
[INFO] [stderr]     |
[INFO] [stderr] 711 |                     error_buf[0] as u32 | (error_buf[1] as u32) << 8
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:711:43
[INFO] [stderr]     |
[INFO] [stderr] 711 |                     error_buf[0] as u32 | (error_buf[1] as u32) << 8
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:712:23
[INFO] [stderr]     |
[INFO] [stderr] 712 |                     | (error_buf[2] as u32) << 16 | (error_buf[3] as u32) << 24;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/popen.rs:712:53
[INFO] [stderr]     |
[INFO] [stderr] 712 |                     | (error_buf[2] as u32) << 16 | (error_buf[3] as u32) << 24;
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(error_buf[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/communicate.rs:103:27
[INFO] [stderr]     |
[INFO] [stderr] 103 |                        -> IoResult<(Option<Vec<u8>>, Option<Vec<u8>>)> {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/posix.rs:257:26
[INFO] [stderr]     |
[INFO] [stderr] 257 |     unsafe { libc::_exit(status as c_int) }
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^ help: try: `i32::from(status)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/os_common.rs:36:20
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn success(&self) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/os_common.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         if let &ExitStatus::Exited(0) = self {
[INFO] [stderr] 38 | |             true
[INFO] [stderr] 39 | |         } else {
[INFO] [stderr] 40 | |             false
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if let ExitStatus::Exited(0) = *self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]  --> tests/just-echo.rs:2:15
[INFO] [stderr]   |
[INFO] [stderr] 2 |     print!("{}", ::std::env::args().skip(1).next().unwrap());
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.95s
[INFO] running `"docker" "inspect" "5d6df6bbcc9dafc3f7b7f7de8af3be36b8afb14405c93ebec1c8e9ceee175a4e"`
[INFO] running `"docker" "rm" "-f" "5d6df6bbcc9dafc3f7b7f7de8af3be36b8afb14405c93ebec1c8e9ceee175a4e"`
[INFO] [stdout] 5d6df6bbcc9dafc3f7b7f7de8af3be36b8afb14405c93ebec1c8e9ceee175a4e