[INFO] crate sublock 0.1.1 is already in cache [INFO] extracting crate sublock 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/sublock/0.1.1 [INFO] extracting crate sublock 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sublock/0.1.1 [INFO] validating manifest of sublock-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sublock-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sublock-0.1.1 [INFO] finished frobbing sublock-0.1.1 [INFO] frobbed toml for sublock-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/sublock/0.1.1/Cargo.toml [INFO] started frobbing sublock-0.1.1 [INFO] finished frobbing sublock-0.1.1 [INFO] frobbed toml for sublock-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sublock/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sublock-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sublock/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65a9822f6dd2db753f04cdc6ce76d9f7c25b4eaef630317a2039b0e4cb1646a9 [INFO] running `"docker" "start" "-a" "65a9822f6dd2db753f04cdc6ce76d9f7c25b4eaef630317a2039b0e4cb1646a9"` [INFO] [stderr] Checking sublock v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atomlock.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atomlock.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | liveness: liveness [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `liveness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prooflock.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | ownership: ownership [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ownership` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atomlock.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atomlock.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | liveness: liveness [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `liveness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prooflock.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | ownership: ownership [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ownership` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/atomlock.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new<'a>(liveness: &Arc, value: T) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `borrow` on this type; consider implementing the `std::borrow::Borrow` trait or choosing a less ambiguous name [INFO] [stderr] --> src/atomlock.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn borrow(&self) -> &T { [INFO] [stderr] 29 | | assert!(self.liveness.is_alive.load(Ordering::Relaxed)); [INFO] [stderr] 30 | | unsafe { &*self.cell.get() } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/atomlock.rs:33:33 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn borrow_mut(&self) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/atomlock.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn borrow_mut(&self) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/prooflock.rs:16:47 [INFO] [stderr] | [INFO] [stderr] 16 | fn borrow_mut<'a>(&'a self, proof: &P) -> &'a mut T; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/prooflock.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | fn borrow_mut<'a>(&'a self, proof: &P) -> &'a mut T; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sublock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/atomlock.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new<'a>(liveness: &Arc, value: T) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `borrow` on this type; consider implementing the `std::borrow::Borrow` trait or choosing a less ambiguous name [INFO] [stderr] --> src/atomlock.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn borrow(&self) -> &T { [INFO] [stderr] 29 | | assert!(self.liveness.is_alive.load(Ordering::Relaxed)); [INFO] [stderr] 30 | | unsafe { &*self.cell.get() } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/atomlock.rs:33:33 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn borrow_mut(&self) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/atomlock.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn borrow_mut(&self) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/prooflock.rs:16:47 [INFO] [stderr] | [INFO] [stderr] 16 | fn borrow_mut<'a>(&'a self, proof: &P) -> &'a mut T; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/prooflock.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | fn borrow_mut<'a>(&'a self, proof: &P) -> &'a mut T; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sublock`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "65a9822f6dd2db753f04cdc6ce76d9f7c25b4eaef630317a2039b0e4cb1646a9"` [INFO] running `"docker" "rm" "-f" "65a9822f6dd2db753f04cdc6ce76d9f7c25b4eaef630317a2039b0e4cb1646a9"` [INFO] [stdout] 65a9822f6dd2db753f04cdc6ce76d9f7c25b4eaef630317a2039b0e4cb1646a9