[INFO] crate stund_protocol 0.1.3 is already in cache [INFO] extracting crate stund_protocol 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/stund_protocol/0.1.3 [INFO] extracting crate stund_protocol 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stund_protocol/0.1.3 [INFO] validating manifest of stund_protocol-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stund_protocol-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stund_protocol-0.1.3 [INFO] finished frobbing stund_protocol-0.1.3 [INFO] frobbed toml for stund_protocol-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/stund_protocol/0.1.3/Cargo.toml [INFO] started frobbing stund_protocol-0.1.3 [INFO] finished frobbing stund_protocol-0.1.3 [INFO] frobbed toml for stund_protocol-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stund_protocol/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stund_protocol-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stund_protocol/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b30637d5a6f19487b1d56930733b67a2b53121e6daf6781a243d54709e493b8 [INFO] running `"docker" "start" "-a" "3b30637d5a6f19487b1d56930733b67a2b53121e6daf6781a243d54709e493b8"` [INFO] [stderr] Checking rent_to_own v0.1.0 [INFO] [stderr] Compiling derive-error v0.0.3 [INFO] [stderr] Compiling serde_derive v1.0.55 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking tokio-serde v0.1.0 [INFO] [stderr] Compiling darling_core v0.8.3 [INFO] [stderr] Checking tokio-serde-bincode v0.1.1 [INFO] [stderr] Compiling darling_macro v0.8.3 [INFO] [stderr] Compiling darling v0.8.3 [INFO] [stderr] Compiling derive_state_machine_future v0.1.8 [INFO] [stderr] Checking state_machine_future v0.1.8 [INFO] [stderr] Checking stund_protocol v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:155:56 [INFO] [stderr] | [INFO] [stderr] 155 | Some(ServerMessage::Error(msg)) => return Err(format_err!("{}", msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("{}", msg))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:156:36 [INFO] [stderr] | [INFO] [stderr] 156 | Some(other) => return Err(format_err!("unexpected server reply: {:?}", other)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected server reply: {:?}", other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | None => return Err(format_err!("unexpected disconnection from server")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected disconnection from server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:181:56 [INFO] [stderr] | [INFO] [stderr] 181 | Some(ServerMessage::Error(msg)) => return Err(format_err!("{}", msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("{}", msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | Some(other) => return Err(format_err!("unexpected server reply: {:?}", other)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected server reply: {:?}", other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:183:29 [INFO] [stderr] | [INFO] [stderr] 183 | None => return Err(format_err!("unexpected disconnection from server")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected disconnection from server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:210:56 [INFO] [stderr] | [INFO] [stderr] 210 | Some(ServerMessage::Error(msg)) => return Err(format_err!("{}", msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("{}", msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:211:36 [INFO] [stderr] | [INFO] [stderr] 211 | Some(other) => return Err(format_err!("unexpected server reply: {:?}", other)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected server reply: {:?}", other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | None => return Err(format_err!("unexpected disconnection from server")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected disconnection from server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | use tokio_io::codec::length_delimited::{FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | use tokio_io::codec::length_delimited::{FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | type Ser = WriteBincode>, ClientMessage>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | type De = ReadBincode>, ServerMessage>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | let mut p = env::home_dir().ok_or(format_err!("unable to determine your home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:87:22 [INFO] [stderr] | [INFO] [stderr] 87 | let wdelim = FramedWrite::new(write); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let rdelim = FramedRead::new(read); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:155:56 [INFO] [stderr] | [INFO] [stderr] 155 | Some(ServerMessage::Error(msg)) => return Err(format_err!("{}", msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("{}", msg))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:156:36 [INFO] [stderr] | [INFO] [stderr] 156 | Some(other) => return Err(format_err!("unexpected server reply: {:?}", other)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected server reply: {:?}", other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | None => return Err(format_err!("unexpected disconnection from server")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected disconnection from server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:181:56 [INFO] [stderr] | [INFO] [stderr] 181 | Some(ServerMessage::Error(msg)) => return Err(format_err!("{}", msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("{}", msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | Some(other) => return Err(format_err!("unexpected server reply: {:?}", other)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected server reply: {:?}", other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:183:29 [INFO] [stderr] | [INFO] [stderr] 183 | None => return Err(format_err!("unexpected disconnection from server")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected disconnection from server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:210:56 [INFO] [stderr] | [INFO] [stderr] 210 | Some(ServerMessage::Error(msg)) => return Err(format_err!("{}", msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("{}", msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:211:36 [INFO] [stderr] | [INFO] [stderr] 211 | Some(other) => return Err(format_err!("unexpected server reply: {:?}", other)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected server reply: {:?}", other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | None => return Err(format_err!("unexpected disconnection from server")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("unexpected disconnection from server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | use tokio_io::codec::length_delimited::{FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | use tokio_io::codec::length_delimited::{FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | type Ser = WriteBincode>, ClientMessage>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | type De = ReadBincode>, ServerMessage>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | let mut p = env::home_dir().ok_or(format_err!("unable to determine your home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:87:22 [INFO] [stderr] | [INFO] [stderr] 87 | let wdelim = FramedWrite::new(write); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::length_delimited::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let rdelim = FramedRead::new(read); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / Communicating { [INFO] [stderr] 246 | | tx_ssh: Ser, [INFO] [stderr] 247 | | rx_ssh: De, [INFO] [stderr] 248 | | ssh_buf: Vec, [INFO] [stderr] ... | [INFO] [stderr] 251 | | user_buf: Vec, [INFO] [stderr] 252 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/client.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / Communicating { [INFO] [stderr] 246 | | tx_ssh: Ser, [INFO] [stderr] 247 | | rx_ssh: De, [INFO] [stderr] 248 | | ssh_buf: Vec, [INFO] [stderr] ... | [INFO] [stderr] 251 | | user_buf: Vec, [INFO] [stderr] 252 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client.rs:224:27 [INFO] [stderr] | [INFO] [stderr] 224 | #[derive(StateMachineFuture)] [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:369:12 [INFO] [stderr] | [INFO] [stderr] 369 | if state.user_buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.user_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:379:12 [INFO] [stderr] | [INFO] [stderr] 379 | if state.ssh_buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.ssh_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | let mut p = env::home_dir().ok_or(format_err!("unable to determine your home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("unable to determine your home directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / Communicating { [INFO] [stderr] 246 | | tx_ssh: Ser, [INFO] [stderr] 247 | | rx_ssh: De, [INFO] [stderr] 248 | | ssh_buf: Vec, [INFO] [stderr] ... | [INFO] [stderr] 251 | | user_buf: Vec, [INFO] [stderr] 252 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/client.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / Communicating { [INFO] [stderr] 246 | | tx_ssh: Ser, [INFO] [stderr] 247 | | rx_ssh: De, [INFO] [stderr] 248 | | ssh_buf: Vec, [INFO] [stderr] ... | [INFO] [stderr] 251 | | user_buf: Vec, [INFO] [stderr] 252 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client.rs:224:27 [INFO] [stderr] | [INFO] [stderr] 224 | #[derive(StateMachineFuture)] [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:369:12 [INFO] [stderr] | [INFO] [stderr] 369 | if state.user_buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.user_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:379:12 [INFO] [stderr] | [INFO] [stderr] 379 | if state.ssh_buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.ssh_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | let mut p = env::home_dir().ok_or(format_err!("unable to determine your home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("unable to determine your home directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.28s [INFO] running `"docker" "inspect" "3b30637d5a6f19487b1d56930733b67a2b53121e6daf6781a243d54709e493b8"` [INFO] running `"docker" "rm" "-f" "3b30637d5a6f19487b1d56930733b67a2b53121e6daf6781a243d54709e493b8"` [INFO] [stdout] 3b30637d5a6f19487b1d56930733b67a2b53121e6daf6781a243d54709e493b8