[INFO] crate stun 0.0.2 is already in cache [INFO] extracting crate stun 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/stun/0.0.2 [INFO] extracting crate stun 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stun/0.0.2 [INFO] validating manifest of stun-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stun-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stun-0.0.2 [INFO] finished frobbing stun-0.0.2 [INFO] frobbed toml for stun-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/stun/0.0.2/Cargo.toml [INFO] started frobbing stun-0.0.2 [INFO] finished frobbing stun-0.0.2 [INFO] frobbed toml for stun-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stun/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stun-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stun/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad7590d1b00eead3965e4f0f654f0e3a361eac95d8e730783ff707acf8a7cbee [INFO] running `"docker" "start" "-a" "ad7590d1b00eead3965e4f0f654f0e3a361eac95d8e730783ff707acf8a7cbee"` [INFO] [stderr] Checking stun v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | transaction_id: transaction_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | attributes: attributes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | transaction_id: transaction_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | attributes: attributes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | Request = 0b00000000000000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | Indication = 0b00000000010000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | SuccessResponse = 0b00000100000000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | FailureResponse = 0b00000100010000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | 0b00000000000000 => Some(MessageClass::Request), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | 0b00000000010000 => Some(MessageClass::Indication), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | 0b00000100000000 => Some(MessageClass::SuccessResponse), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | 0b00000100010000 => Some(MessageClass::FailureResponse), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | Binding = 0b00000000000001 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:45:59 [INFO] [stderr] | [INFO] [stderr] 45 | let class = MessageClass::from_u16(message_type & 0b00000100010000).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | Request = 0b00000000000000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | Indication = 0b00000000010000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | SuccessResponse = 0b00000100000000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | FailureResponse = 0b00000100010000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | 0b00000000000000 => Some(MessageClass::Request), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | 0b00000000010000 => Some(MessageClass::Indication), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | 0b00000100000000 => Some(MessageClass::SuccessResponse), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | 0b00000100010000 => Some(MessageClass::FailureResponse), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | Binding = 0b00000000000001 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0000_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:45:59 [INFO] [stderr] | [INFO] [stderr] 45 | let class = MessageClass::from_u16(message_type & 0b00000100010000).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b00_0001_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | let message_type = ((encoded[0] as u16) << 8) | (encoded[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:44:57 [INFO] [stderr] | [INFO] [stderr] 44 | let message_type = ((encoded[0] as u16) << 8) | (encoded[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | let port = (((encoded[2] as u16) << 8) | (encoded[3] as u16)) ^ 0x2112; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:50 [INFO] [stderr] | [INFO] [stderr] 83 | let port = (((encoded[2] as u16) << 8) | (encoded[3] as u16)) ^ 0x2112; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | .map(|seg| ((seg[0] as u16) << 8) | (seg[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(seg[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:99:57 [INFO] [stderr] | [INFO] [stderr] 99 | .map(|seg| ((seg[0] as u16) << 8) | (seg[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(seg[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/lib.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | e @ _ => { return Err(format!("Invalid address family: {:?}", e)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let attribute_type = ((encoded.remove(0) as u16) << 8) | (encoded.remove(0) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded.remove(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:70 [INFO] [stderr] | [INFO] [stderr] 137 | let attribute_type = ((encoded.remove(0) as u16) << 8) | (encoded.remove(0) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded.remove(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:190:61 [INFO] [stderr] | [INFO] [stderr] 190 | XorMappedAddress::decode(value, transaction_id).map(|a| Attribute::XorMappedAddress(a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Attribute::XorMappedAddress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | let message_type = ((encoded[0] as u16) << 8) | (encoded[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:44:57 [INFO] [stderr] | [INFO] [stderr] 44 | let message_type = ((encoded[0] as u16) << 8) | (encoded[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | let port = (((encoded[2] as u16) << 8) | (encoded[3] as u16)) ^ 0x2112; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:50 [INFO] [stderr] | [INFO] [stderr] 83 | let port = (((encoded[2] as u16) << 8) | (encoded[3] as u16)) ^ 0x2112; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | .map(|seg| ((seg[0] as u16) << 8) | (seg[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(seg[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:99:57 [INFO] [stderr] | [INFO] [stderr] 99 | .map(|seg| ((seg[0] as u16) << 8) | (seg[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(seg[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/lib.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | e @ _ => { return Err(format!("Invalid address family: {:?}", e)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let attribute_type = ((encoded.remove(0) as u16) << 8) | (encoded.remove(0) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded.remove(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:70 [INFO] [stderr] | [INFO] [stderr] 137 | let attribute_type = ((encoded.remove(0) as u16) << 8) | (encoded.remove(0) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(encoded.remove(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:190:61 [INFO] [stderr] | [INFO] [stderr] 190 | XorMappedAddress::decode(value, transaction_id).map(|a| Attribute::XorMappedAddress(a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Attribute::XorMappedAddress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | e @ _ => Err(format!("Unknown IP version: {}", e)) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | e @ _ => Err(format!("Unknown IP version: {}", e)) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.64s [INFO] running `"docker" "inspect" "ad7590d1b00eead3965e4f0f654f0e3a361eac95d8e730783ff707acf8a7cbee"` [INFO] running `"docker" "rm" "-f" "ad7590d1b00eead3965e4f0f654f0e3a361eac95d8e730783ff707acf8a7cbee"` [INFO] [stdout] ad7590d1b00eead3965e4f0f654f0e3a361eac95d8e730783ff707acf8a7cbee