[INFO] crate structure-macro-impl 0.1.2 is already in cache [INFO] extracting crate structure-macro-impl 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/structure-macro-impl/0.1.2 [INFO] extracting crate structure-macro-impl 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structure-macro-impl/0.1.2 [INFO] validating manifest of structure-macro-impl-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of structure-macro-impl-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing structure-macro-impl-0.1.2 [INFO] finished frobbing structure-macro-impl-0.1.2 [INFO] frobbed toml for structure-macro-impl-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/structure-macro-impl/0.1.2/Cargo.toml [INFO] started frobbing structure-macro-impl-0.1.2 [INFO] finished frobbing structure-macro-impl-0.1.2 [INFO] frobbed toml for structure-macro-impl-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structure-macro-impl/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting structure-macro-impl-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/structure-macro-impl/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 078a6c9a6d68fdc369532beeae1c1fbf0e68d4dabc895c9d03ea921b3f7bed5c [INFO] running `"docker" "start" "-a" "078a6c9a6d68fdc369532beeae1c1fbf0e68d4dabc895c9d03ea921b3f7bed5c"` [INFO] [stderr] Checking structure-macro-impl v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:23 [INFO] [stderr] | [INFO] [stderr] 425 | StructValue { type_name: type_name, repeat: repeat, kind: kind } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:45 [INFO] [stderr] | [INFO] [stderr] 425 | StructValue { type_name: type_name, repeat: repeat, kind: kind } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:61 [INFO] [stderr] | [INFO] [stderr] 425 | StructValue { type_name: type_name, repeat: repeat, kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:23 [INFO] [stderr] | [INFO] [stderr] 425 | StructValue { type_name: type_name, repeat: repeat, kind: kind } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:45 [INFO] [stderr] | [INFO] [stderr] 425 | StructValue { type_name: type_name, repeat: repeat, kind: kind } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:61 [INFO] [stderr] | [INFO] [stderr] 425 | StructValue { type_name: type_name, repeat: repeat, kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:290:38 [INFO] [stderr] | [INFO] [stderr] 290 | if v.type_name().starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:305:32 [INFO] [stderr] | [INFO] [stderr] 305 | t if t.starts_with("*") => mem::size_of::(), [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:440:45 [INFO] [stderr] | [INFO] [stderr] 440 | if input.chars().nth(0) != Some('"') && input.chars().last() != Some('"') || input.len() < 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!input.ends_with('"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:290:38 [INFO] [stderr] | [INFO] [stderr] 290 | if v.type_name().starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:305:32 [INFO] [stderr] | [INFO] [stderr] 305 | t if t.starts_with("*") => mem::size_of::(), [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:440:45 [INFO] [stderr] | [INFO] [stderr] 440 | if input.chars().nth(0) != Some('"') && input.chars().last() != Some('"') || input.len() < 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!input.ends_with('"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.98s [INFO] running `"docker" "inspect" "078a6c9a6d68fdc369532beeae1c1fbf0e68d4dabc895c9d03ea921b3f7bed5c"` [INFO] running `"docker" "rm" "-f" "078a6c9a6d68fdc369532beeae1c1fbf0e68d4dabc895c9d03ea921b3f7bed5c"` [INFO] [stdout] 078a6c9a6d68fdc369532beeae1c1fbf0e68d4dabc895c9d03ea921b3f7bed5c