[INFO] crate structopt-derive 0.2.13 is already in cache [INFO] extracting crate structopt-derive 0.2.13 into work/ex/clippy-test-run/sources/stable/reg/structopt-derive/0.2.13 [INFO] extracting crate structopt-derive 0.2.13 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structopt-derive/0.2.13 [INFO] validating manifest of structopt-derive-0.2.13 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of structopt-derive-0.2.13 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing structopt-derive-0.2.13 [INFO] finished frobbing structopt-derive-0.2.13 [INFO] frobbed toml for structopt-derive-0.2.13 written to work/ex/clippy-test-run/sources/stable/reg/structopt-derive/0.2.13/Cargo.toml [INFO] started frobbing structopt-derive-0.2.13 [INFO] finished frobbing structopt-derive-0.2.13 [INFO] frobbed toml for structopt-derive-0.2.13 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structopt-derive/0.2.13/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting structopt-derive-0.2.13 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/structopt-derive/0.2.13:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee024b7a88d87a2892733ea1c477d3f06414cfaab97df6d628d01582e46cd01e [INFO] running `"docker" "start" "-a" "ee024b7a88d87a2892733ea1c477d3f06414cfaab97df6d628d01582e46cd01e"` [INFO] [stderr] Checking heck v0.3.1 [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking structopt-derive v0.2.13 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/attrs.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | fn translate(&self, input: &str) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/attrs.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | .expect(&format!("invalid structopt syntax: {}", quote!(attr))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("invalid structopt syntax: {}", quote!(attr)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `l @ _` pattern can be written as just `l` [INFO] [stderr] --> src/attrs.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | ref l @ _ => panic!("unknown value parser specification: {}", quote!(#l)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `mi @ _` pattern can be written as just `mi` [INFO] [stderr] --> src/attrs.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | ref mi @ _ => panic!("unsupported raw entry: {}", quote!(#mi)), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/attrs.rs:270:52 [INFO] [stderr] | [INFO] [stderr] 270 | let ts: TokenStream = args.value().parse().expect(&format!( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 271 | | "bad parameter {} = {}: the parameter must be valid rust code", [INFO] [stderr] 272 | | name, [INFO] [stderr] 273 | | quote!(#args) [INFO] [stderr] 274 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("bad parameter {} = {}: the parameter must be valid rust code", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/attrs.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | / match quote!(#path).to_string() == "doc" { [INFO] [stderr] 286 | | true => attr.interpret_meta(), [INFO] [stderr] 287 | | false => None, [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if quote!(#path).to_string() == "doc" { attr.interpret_meta() } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/attrs.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | self.methods.iter().find(|m| m.name == method).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|m| m.name == method).is_some()` with `any(|m| m.name == method)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/attrs.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | fn translate(&self, input: &str) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/attrs.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | .expect(&format!("invalid structopt syntax: {}", quote!(attr))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("invalid structopt syntax: {}", quote!(attr)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `l @ _` pattern can be written as just `l` [INFO] [stderr] --> src/attrs.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | ref l @ _ => panic!("unknown value parser specification: {}", quote!(#l)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `mi @ _` pattern can be written as just `mi` [INFO] [stderr] --> src/attrs.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | ref mi @ _ => panic!("unsupported raw entry: {}", quote!(#mi)), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/attrs.rs:270:52 [INFO] [stderr] | [INFO] [stderr] 270 | let ts: TokenStream = args.value().parse().expect(&format!( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 271 | | "bad parameter {} = {}: the parameter must be valid rust code", [INFO] [stderr] 272 | | name, [INFO] [stderr] 273 | | quote!(#args) [INFO] [stderr] 274 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("bad parameter {} = {}: the parameter must be valid rust code", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/attrs.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | / match quote!(#path).to_string() == "doc" { [INFO] [stderr] 286 | | true => attr.interpret_meta(), [INFO] [stderr] 287 | | false => None, [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if quote!(#path).to_string() == "doc" { attr.interpret_meta() } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/attrs.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | self.methods.iter().find(|m| m.name == method).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|m| m.name == method).is_some()` with `any(|m| m.name == method)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.86s [INFO] running `"docker" "inspect" "ee024b7a88d87a2892733ea1c477d3f06414cfaab97df6d628d01582e46cd01e"` [INFO] running `"docker" "rm" "-f" "ee024b7a88d87a2892733ea1c477d3f06414cfaab97df6d628d01582e46cd01e"` [INFO] [stdout] ee024b7a88d87a2892733ea1c477d3f06414cfaab97df6d628d01582e46cd01e