[INFO] crate struct-diff 0.2.3 is already in cache [INFO] extracting crate struct-diff 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/struct-diff/0.2.3 [INFO] extracting crate struct-diff 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/struct-diff/0.2.3 [INFO] validating manifest of struct-diff-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of struct-diff-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing struct-diff-0.2.3 [INFO] finished frobbing struct-diff-0.2.3 [INFO] frobbed toml for struct-diff-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/struct-diff/0.2.3/Cargo.toml [INFO] started frobbing struct-diff-0.2.3 [INFO] finished frobbing struct-diff-0.2.3 [INFO] frobbed toml for struct-diff-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/struct-diff/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting struct-diff-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/struct-diff/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae8e819f33b2a128cf262f35ba41989b12322ebd0d44c296d15f09e3de94331d [INFO] running `"docker" "start" "-a" "ae8e819f33b2a128cf262f35ba41989b12322ebd0d44c296d15f09e3de94331d"` [INFO] [stderr] Checking struct-diff v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | Some(vec![Difference { field: format!("none"), left: self, right: other }]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"none".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:74:47 [INFO] [stderr] | [INFO] [stderr] 74 | Some(vec![Difference { field: format!("some"), left: self, right: other }]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"some".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | if diffs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!diffs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 121 | impl_for_prim!(f32); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 121 | impl_for_prim!(f32); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 122 | impl_for_prim!(f64); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 122 | impl_for_prim!(f64); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `struct-diff`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | Some(vec![Difference { field: format!("none"), left: self, right: other }]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"none".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:74:47 [INFO] [stderr] | [INFO] [stderr] 74 | Some(vec![Difference { field: format!("some"), left: self, right: other }]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"some".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | if diffs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!diffs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 121 | impl_for_prim!(f32); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 121 | impl_for_prim!(f32); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 122 | impl_for_prim!(f64); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if self != other { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 122 | impl_for_prim!(f64); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `struct-diff`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ae8e819f33b2a128cf262f35ba41989b12322ebd0d44c296d15f09e3de94331d"` [INFO] running `"docker" "rm" "-f" "ae8e819f33b2a128cf262f35ba41989b12322ebd0d44c296d15f09e3de94331d"` [INFO] [stdout] ae8e819f33b2a128cf262f35ba41989b12322ebd0d44c296d15f09e3de94331d