[INFO] crate strings 0.1.1 is already in cache [INFO] extracting crate strings 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/strings/0.1.1 [INFO] extracting crate strings 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strings/0.1.1 [INFO] validating manifest of strings-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of strings-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing strings-0.1.1 [INFO] finished frobbing strings-0.1.1 [INFO] frobbed toml for strings-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/strings/0.1.1/Cargo.toml [INFO] started frobbing strings-0.1.1 [INFO] finished frobbing strings-0.1.1 [INFO] frobbed toml for strings-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/strings/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting strings-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/strings/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8aaffffe9ca43b9458cd83ab290fbf046ed6b8bfdc3667f509bf6f3fb935258e [INFO] running `"docker" "start" "-a" "8aaffffe9ca43b9458cd83ab290fbf046ed6b8bfdc3667f509bf6f3fb935258e"` [INFO] [stderr] Checking strings v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:383:13 [INFO] [stderr] | [INFO] [stderr] 383 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | src_weight: src_weight, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | src_offset: src_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/rope.rs:383:13 [INFO] [stderr] | [INFO] [stderr] 383 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | src_weight: src_weight, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ropes/src_rope.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | src_offset: src_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/string_buffer.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | return Some((result, byte)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, byte))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return Some((result, byte)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, byte))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:503:9 [INFO] [stderr] | [INFO] [stderr] 503 | return NodeAction::Adjust(total_adj); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Adjust(total_adj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:623:9 [INFO] [stderr] | [INFO] [stderr] 623 | return NodeAction::Change(Box::new(new_node), delta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(Box::new(new_node), delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:651:9 [INFO] [stderr] | [INFO] [stderr] 651 | return NodeAction::Change(new_node, len as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(new_node, len as isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | return Some((result, byte)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, byte))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:628:9 [INFO] [stderr] | [INFO] [stderr] 628 | return NodeAction::Adjust(total_adj); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Adjust(total_adj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:701:9 [INFO] [stderr] | [INFO] [stderr] 701 | return NodeAction::Adjust(total_adj); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Adjust(total_adj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | return NodeAction::Change(Box::new(new_node), delta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(Box::new(new_node), delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:986:9 [INFO] [stderr] | [INFO] [stderr] 986 | return NodeAction::Change(new_node, len as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(new_node, len as isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:1053:9 [INFO] [stderr] | [INFO] [stderr] 1053 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/string_buffer.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | return Some((result, byte)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, byte))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return Some((result, byte)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, byte))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:503:9 [INFO] [stderr] | [INFO] [stderr] 503 | return NodeAction::Adjust(total_adj); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Adjust(total_adj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:623:9 [INFO] [stderr] | [INFO] [stderr] 623 | return NodeAction::Change(Box::new(new_node), delta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(Box::new(new_node), delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/rope.rs:651:9 [INFO] [stderr] | [INFO] [stderr] 651 | return NodeAction::Change(new_node, len as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(new_node, len as isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | return Some((result, byte)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, byte))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:628:9 [INFO] [stderr] | [INFO] [stderr] 628 | return NodeAction::Adjust(total_adj); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Adjust(total_adj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:701:9 [INFO] [stderr] | [INFO] [stderr] 701 | return NodeAction::Adjust(total_adj); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Adjust(total_adj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | return NodeAction::Change(Box::new(new_node), delta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(Box::new(new_node), delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:986:9 [INFO] [stderr] | [INFO] [stderr] 986 | return NodeAction::Change(new_node, len as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeAction::Change(new_node, len as isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ropes/src_rope.rs:1053:9 [INFO] [stderr] | [INFO] [stderr] 1053 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/string_buffer.rs:264:17 [INFO] [stderr] | [INFO] [stderr] 264 | let mut last = &mut *result.first; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `string_buffer::StringBuffer` [INFO] [stderr] --> src/string_buffer.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> StringBuffer { [INFO] [stderr] 52 | | StringBuffer::with_capacity(INIT_CAPACITY) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for string_buffer::StringBuffer { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/string_buffer.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | last: 0 as *mut StringNode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/string_buffer.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn chars<'a>(&'a self) -> Chars<'a> { [INFO] [stderr] 112 | | Chars::new(&self.first) [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/string_buffer.rs:259:19 [INFO] [stderr] | [INFO] [stderr] 259 | last: 0 as *mut StringNode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/string_buffer.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / fn new<'b>(first_node: &'b StringNode) -> Chars<'b> { [INFO] [stderr] 281 | | Chars { [INFO] [stderr] 282 | | cur_node: first_node, [INFO] [stderr] 283 | | cur_byte: 0, [INFO] [stderr] 284 | | abs_byte: 0, [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ropes::rope::Rope` [INFO] [stderr] --> src/ropes/rope.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> Rope { [INFO] [stderr] 62 | | Rope { [INFO] [stderr] 63 | | root: Node::empty_inner(), [INFO] [stderr] 64 | | len: 0, [INFO] [stderr] 65 | | storage: vec![], [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | impl Default for ropes::rope::Rope { [INFO] [stderr] 60 | fn default() -> Self { [INFO] [stderr] 61 | Self::new() [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/rope.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/rope.rs:224:12 [INFO] [stderr] | [INFO] [stderr] 224 | if self.nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ropes::src_rope::Rope` [INFO] [stderr] --> src/ropes/src_rope.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> Rope { [INFO] [stderr] 63 | | Rope { [INFO] [stderr] 64 | | root: Node::empty_inner(), [INFO] [stderr] 65 | | len: 0, [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | impl Default for ropes::src_rope::Rope { [INFO] [stderr] 61 | fn default() -> Self { [INFO] [stderr] 62 | Self::new() [INFO] [stderr] 63 | } [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/src_rope.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/src_rope.rs:268:12 [INFO] [stderr] | [INFO] [stderr] 268 | if self.nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:897:9 [INFO] [stderr] | [INFO] [stderr] 897 | / match self.right { [INFO] [stderr] 898 | | Some(ref right) => match right.find_last_char(c) { [INFO] [stderr] 899 | | Some(x) => return Some(x), [INFO] [stderr] 900 | | None => {}, [INFO] [stderr] 901 | | }, [INFO] [stderr] 902 | | None => {} [INFO] [stderr] 903 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 897 | if let Some(ref right) = self.right { match right.find_last_char(c) { [INFO] [stderr] 898 | Some(x) => return Some(x), [INFO] [stderr] 899 | None => {}, [INFO] [stderr] 900 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:898:32 [INFO] [stderr] | [INFO] [stderr] 898 | Some(ref right) => match right.find_last_char(c) { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 899 | | Some(x) => return Some(x), [INFO] [stderr] 900 | | None => {}, [INFO] [stderr] 901 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = right.find_last_char(c) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:904:9 [INFO] [stderr] | [INFO] [stderr] 904 | / match self.left { [INFO] [stderr] 905 | | Some(ref left) => match left.find_last_char(c) { [INFO] [stderr] 906 | | Some(x) => return Some(x), [INFO] [stderr] 907 | | None => {}, [INFO] [stderr] 908 | | }, [INFO] [stderr] 909 | | None => {} [INFO] [stderr] 910 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 904 | if let Some(ref left) = self.left { match left.find_last_char(c) { [INFO] [stderr] 905 | Some(x) => return Some(x), [INFO] [stderr] 906 | None => {}, [INFO] [stderr] 907 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:905:31 [INFO] [stderr] | [INFO] [stderr] 905 | Some(ref left) => match left.find_last_char(c) { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 906 | | Some(x) => return Some(x), [INFO] [stderr] 907 | | None => {}, [INFO] [stderr] 908 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = left.find_last_char(c) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/string_buffer.rs:264:17 [INFO] [stderr] | [INFO] [stderr] 264 | let mut last = &mut *result.first; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `string_buffer::StringBuffer` [INFO] [stderr] --> src/string_buffer.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> StringBuffer { [INFO] [stderr] 52 | | StringBuffer::with_capacity(INIT_CAPACITY) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for string_buffer::StringBuffer { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/string_buffer.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | last: 0 as *mut StringNode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/string_buffer.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn chars<'a>(&'a self) -> Chars<'a> { [INFO] [stderr] 112 | | Chars::new(&self.first) [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/string_buffer.rs:259:19 [INFO] [stderr] | [INFO] [stderr] 259 | last: 0 as *mut StringNode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/string_buffer.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / fn new<'b>(first_node: &'b StringNode) -> Chars<'b> { [INFO] [stderr] 281 | | Chars { [INFO] [stderr] 282 | | cur_node: first_node, [INFO] [stderr] 283 | | cur_byte: 0, [INFO] [stderr] 284 | | abs_byte: 0, [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ropes::rope::Rope` [INFO] [stderr] --> src/ropes/rope.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> Rope { [INFO] [stderr] 62 | | Rope { [INFO] [stderr] 63 | | root: Node::empty_inner(), [INFO] [stderr] 64 | | len: 0, [INFO] [stderr] 65 | | storage: vec![], [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | impl Default for ropes::rope::Rope { [INFO] [stderr] 60 | fn default() -> Self { [INFO] [stderr] 61 | Self::new() [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/rope.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/rope.rs:224:12 [INFO] [stderr] | [INFO] [stderr] 224 | if self.nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ropes::src_rope::Rope` [INFO] [stderr] --> src/ropes/src_rope.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> Rope { [INFO] [stderr] 63 | | Rope { [INFO] [stderr] 64 | | root: Node::empty_inner(), [INFO] [stderr] 65 | | len: 0, [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | impl Default for ropes::src_rope::Rope { [INFO] [stderr] 61 | fn default() -> Self { [INFO] [stderr] 62 | Self::new() [INFO] [stderr] 63 | } [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/src_rope.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ropes/src_rope.rs:268:12 [INFO] [stderr] | [INFO] [stderr] 268 | if self.nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:897:9 [INFO] [stderr] | [INFO] [stderr] 897 | / match self.right { [INFO] [stderr] 898 | | Some(ref right) => match right.find_last_char(c) { [INFO] [stderr] 899 | | Some(x) => return Some(x), [INFO] [stderr] 900 | | None => {}, [INFO] [stderr] 901 | | }, [INFO] [stderr] 902 | | None => {} [INFO] [stderr] 903 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 897 | if let Some(ref right) = self.right { match right.find_last_char(c) { [INFO] [stderr] 898 | Some(x) => return Some(x), [INFO] [stderr] 899 | None => {}, [INFO] [stderr] 900 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:898:32 [INFO] [stderr] | [INFO] [stderr] 898 | Some(ref right) => match right.find_last_char(c) { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 899 | | Some(x) => return Some(x), [INFO] [stderr] 900 | | None => {}, [INFO] [stderr] 901 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = right.find_last_char(c) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:904:9 [INFO] [stderr] | [INFO] [stderr] 904 | / match self.left { [INFO] [stderr] 905 | | Some(ref left) => match left.find_last_char(c) { [INFO] [stderr] 906 | | Some(x) => return Some(x), [INFO] [stderr] 907 | | None => {}, [INFO] [stderr] 908 | | }, [INFO] [stderr] 909 | | None => {} [INFO] [stderr] 910 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 904 | if let Some(ref left) = self.left { match left.find_last_char(c) { [INFO] [stderr] 905 | Some(x) => return Some(x), [INFO] [stderr] 906 | None => {}, [INFO] [stderr] 907 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ropes/src_rope.rs:905:31 [INFO] [stderr] | [INFO] [stderr] 905 | Some(ref left) => match left.find_last_char(c) { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 906 | | Some(x) => return Some(x), [INFO] [stderr] 907 | | None => {}, [INFO] [stderr] 908 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let Some(x) = left.find_last_char(c) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `expected` [INFO] [stderr] --> src/ropes/src_rope.rs:1208:18 [INFO] [stderr] | [INFO] [stderr] 1208 | for i in 0..13 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1208 | for (i, ) in expected.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `"docker" "inspect" "8aaffffe9ca43b9458cd83ab290fbf046ed6b8bfdc3667f509bf6f3fb935258e"` [INFO] running `"docker" "rm" "-f" "8aaffffe9ca43b9458cd83ab290fbf046ed6b8bfdc3667f509bf6f3fb935258e"` [INFO] [stdout] 8aaffffe9ca43b9458cd83ab290fbf046ed6b8bfdc3667f509bf6f3fb935258e