[INFO] crate stringly_typed_derive 0.1.0 is already in cache [INFO] extracting crate stringly_typed_derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/stringly_typed_derive/0.1.0 [INFO] extracting crate stringly_typed_derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringly_typed_derive/0.1.0 [INFO] validating manifest of stringly_typed_derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stringly_typed_derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stringly_typed_derive-0.1.0 [INFO] finished frobbing stringly_typed_derive-0.1.0 [INFO] frobbed toml for stringly_typed_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/stringly_typed_derive/0.1.0/Cargo.toml [INFO] started frobbing stringly_typed_derive-0.1.0 [INFO] finished frobbing stringly_typed_derive-0.1.0 [INFO] frobbed toml for stringly_typed_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringly_typed_derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stringly_typed_derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/stringly_typed_derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 090643efbdd888936513480c32aa1687097ba608582f19267bf6ca68745270a0 [INFO] running `"docker" "start" "-a" "090643efbdd888936513480c32aa1687097ba608582f19267bf6ca68745270a0"` [INFO] [stderr] Checking proc-macro2 v0.3.8 [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking synstructure v0.8.1 [INFO] [stderr] Checking stringly_typed_derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | const INVALID_FIELD_ERROR: &'static str = "StringlyTyped can only be derived on structs with fields that have identifiers"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | const INVALID_FIELD_ERROR: &'static str = "StringlyTyped can only be derived on structs with fields that have identifiers"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:28:62 [INFO] [stderr] | [INFO] [stderr] 28 | let field_names: Vec = s.variants()[0].bindings().into_iter().map(|field| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | field.ast().ident.expect(INVALID_FIELD_ERROR).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `field.ast().ident.expect(INVALID_FIELD_ERROR)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:28:62 [INFO] [stderr] | [INFO] [stderr] 28 | let field_names: Vec = s.variants()[0].bindings().into_iter().map(|field| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | field.ast().ident.expect(INVALID_FIELD_ERROR).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `field.ast().ident.expect(INVALID_FIELD_ERROR)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.52s [INFO] running `"docker" "inspect" "090643efbdd888936513480c32aa1687097ba608582f19267bf6ca68745270a0"` [INFO] running `"docker" "rm" "-f" "090643efbdd888936513480c32aa1687097ba608582f19267bf6ca68745270a0"` [INFO] [stdout] 090643efbdd888936513480c32aa1687097ba608582f19267bf6ca68745270a0