[INFO] crate string_cache_codegen 0.4.2 is already in cache [INFO] extracting crate string_cache_codegen 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/string_cache_codegen/0.4.2 [INFO] extracting crate string_cache_codegen 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string_cache_codegen/0.4.2 [INFO] validating manifest of string_cache_codegen-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of string_cache_codegen-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing string_cache_codegen-0.4.2 [INFO] finished frobbing string_cache_codegen-0.4.2 [INFO] frobbed toml for string_cache_codegen-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/string_cache_codegen/0.4.2/Cargo.toml [INFO] started frobbing string_cache_codegen-0.4.2 [INFO] finished frobbing string_cache_codegen-0.4.2 [INFO] frobbed toml for string_cache_codegen-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string_cache_codegen/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting string_cache_codegen-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/string_cache_codegen/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97becfc1cd3896f7700157abc35dece82acc2afbc69342876266b4c41b3899aa [INFO] running `"docker" "start" "-a" "97becfc1cd3896f7700157abc35dece82acc2afbc69342876266b4c41b3899aa"` [INFO] [stderr] Checking phf_generator v0.7.24 [INFO] [stderr] Checking string_cache_codegen v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> lib.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | assert!(macro_name.ends_with("!"), "`macro_name` must end with '!'"); [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> lib.rs:182:18 [INFO] [stderr] | [INFO] [stderr] 182 | fn to_tokens(&mut self) -> proc_macro2::TokenStream { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> lib.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | assert!(macro_name.ends_with("!"), "`macro_name` must end with '!'"); [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> lib.rs:182:18 [INFO] [stderr] | [INFO] [stderr] 182 | fn to_tokens(&mut self) -> proc_macro2::TokenStream { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.81s [INFO] running `"docker" "inspect" "97becfc1cd3896f7700157abc35dece82acc2afbc69342876266b4c41b3899aa"` [INFO] running `"docker" "rm" "-f" "97becfc1cd3896f7700157abc35dece82acc2afbc69342876266b4c41b3899aa"` [INFO] [stdout] 97becfc1cd3896f7700157abc35dece82acc2afbc69342876266b4c41b3899aa