[INFO] crate string_cache 0.7.3 is already in cache [INFO] extracting crate string_cache 0.7.3 into work/ex/clippy-test-run/sources/stable/reg/string_cache/0.7.3 [INFO] extracting crate string_cache 0.7.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string_cache/0.7.3 [INFO] validating manifest of string_cache-0.7.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of string_cache-0.7.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing string_cache-0.7.3 [INFO] finished frobbing string_cache-0.7.3 [INFO] frobbed toml for string_cache-0.7.3 written to work/ex/clippy-test-run/sources/stable/reg/string_cache/0.7.3/Cargo.toml [INFO] started frobbing string_cache-0.7.3 [INFO] finished frobbing string_cache-0.7.3 [INFO] frobbed toml for string_cache-0.7.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string_cache/0.7.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting string_cache-0.7.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/string_cache/0.7.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f5bd8aa2f569cece20766345874830cd9b746e09e4642fecbfbb9eb14d3c627 [INFO] running `"docker" "start" "-a" "9f5bd8aa2f569cece20766345874830cd9b746e09e4642fecbfbb9eb14d3c627"` [INFO] [stderr] Compiling string_cache v0.7.3 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/atom.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atom.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/atom.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | hashes: &[0x3ddddef3], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ddd_def3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/atom.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | hashes: &[0x3ddddef3], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ddd_def3` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:3:199 [INFO] [stderr] | [INFO] [stderr] 3 | impl :: string_cache :: StaticAtomSet for TestAtomStaticSet { fn get ( ) -> & 'static :: string_cache :: PhfStrSet { static SET : :: string_cache :: PhfStrSet = :: string_cache :: PhfStrSet { key : 732231254413039614u64 , disps : & [ ( 0u32 , 0u32 ) , ( 1u32 , 5u32 ) , ( 0u32 , 5u32 ) ] , atoms : &[ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `732_231_254_413_039_614u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_523_015_218u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:41 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `3_993_733_920u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:57 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `3_558_784_543u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:73 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_690_684_349u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:89 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `388_901_393u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:104 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_359_926_067u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:120 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `276_304_134u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:135 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_890_225_098u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:151 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_232_698_746u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:167 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_871_158_724u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:14:183 [INFO] [stderr] | [INFO] [stderr] 14 | "html" ] , hashes : & [ 1523015218u32 , 3993733920u32 , 3558784543u32 , 1690684349u32 , 388901393u32 , 1359926067u32 , 276304134u32 , 1890225098u32 , 2232698746u32 , 2871158724u32 , 3276045433u32 ] } ; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `3_276_045_433u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:22:66 [INFO] [stderr] | [INFO] [stderr] 22 | ( "" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x600000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0006_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:713:41 [INFO] [stderr] | [INFO] [stderr] 713 | assert_eq!(TestAtom::default(), test_atom!("")); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:21:67 [INFO] [stderr] | [INFO] [stderr] 21 | ( "a" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x500000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0005_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:792:33 [INFO] [stderr] | [INFO] [stderr] 792 | check_static("a", test_atom!("a")); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:23:73 [INFO] [stderr] | [INFO] [stderr] 23 | ( "address" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x700000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0007_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:793:33 [INFO] [stderr] | [INFO] [stderr] 793 | check_static("address", test_atom!("address")); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:19:70 [INFO] [stderr] | [INFO] [stderr] 19 | ( "area" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x300000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0003_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:794:33 [INFO] [stderr] | [INFO] [stderr] 794 | check_static("area", test_atom!("area")); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:24:70 [INFO] [stderr] | [INFO] [stderr] 24 | ( "body" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x800000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0008_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:833:20 [INFO] [stderr] | [INFO] [stderr] 833 | assert_eq!(test_atom!("body"), Atom::from("body")); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:25:77 [INFO] [stderr] | [INFO] [stderr] 25 | ( "font-weight" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x900000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0009_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:834:20 [INFO] [stderr] | [INFO] [stderr] 834 | assert_eq!(test_atom!("font-weight"), Atom::from("font-weight")); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:17:68 [INFO] [stderr] | [INFO] [stderr] 17 | ( "br" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x100000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:840:13 [INFO] [stderr] | [INFO] [stderr] 840 | test_atom!("br") => 1, [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:26:70 [INFO] [stderr] | [INFO] [stderr] 26 | ( "html" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0xA00000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x000A_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:841:13 [INFO] [stderr] | [INFO] [stderr] 841 | test_atom!("html") | test_atom!("head") => 2, [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:20:70 [INFO] [stderr] | [INFO] [stderr] 20 | ( "head" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x400000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0004_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:841:34 [INFO] [stderr] | [INFO] [stderr] 841 | test_atom!("html") | test_atom!("head") => 2, [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:17:68 [INFO] [stderr] | [INFO] [stderr] 17 | ( "br" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x100000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:846:13 [INFO] [stderr] | [INFO] [stderr] 846 | test_atom!("br") => 1, [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:26:70 [INFO] [stderr] | [INFO] [stderr] 26 | ( "html" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0xA00000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x000A_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:847:13 [INFO] [stderr] | [INFO] [stderr] 847 | test_atom!("html") | test_atom!("head") => 2, [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:20:70 [INFO] [stderr] | [INFO] [stderr] 20 | ( "head" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x400000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0004_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:847:34 [INFO] [stderr] | [INFO] [stderr] 847 | test_atom!("html") | test_atom!("head") => 2, [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:17:68 [INFO] [stderr] | [INFO] [stderr] 17 | ( "br" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x100000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:852:13 [INFO] [stderr] | [INFO] [stderr] 852 | test_atom!("br") => 1, [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:26:70 [INFO] [stderr] | [INFO] [stderr] 26 | ( "html" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0xA00000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x000A_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:853:13 [INFO] [stderr] | [INFO] [stderr] 853 | test_atom!("html") | test_atom!("head") => 2, [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/string_cache-54bf0b3acee6e3b4/out/test_atom.rs:20:70 [INFO] [stderr] | [INFO] [stderr] 20 | ( "head" ) => { $ crate :: atom :: tests :: TestAtom { unsafe_data : 0x400000002u64 , phantom : :: std :: marker :: PhantomData , } } ; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0004_0000_0002u64` [INFO] [stderr] | [INFO] [stderr] ::: src/atom.rs:853:34 [INFO] [stderr] | [INFO] [stderr] 853 | test_atom!("html") | test_atom!("head") => 2, [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/atom.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | if entry.hash == hash && &*entry.string == &*string { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 82 | if entry.hash == hash && *entry.string == *string { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/atom.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / loop { [INFO] [stderr] 125 | | let entry_ptr: *mut StringCacheEntry = match current.as_mut() { [INFO] [stderr] 126 | | Some(entry) => &mut **entry, [INFO] [stderr] 127 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 133 | | current = unsafe { &mut (*entry_ptr).next_in_bucket }; [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(entry) = current.as_mut() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut atom::StringCacheEntry`) [INFO] [stderr] --> src/atom.rs:239:29 [INFO] [stderr] | [INFO] [stderr] 239 | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/atom.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | &self[..] == &other[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 290 | self[..] == other[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/atom.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | / match from_packed_dynamic(self.unsafe_data) { [INFO] [stderr] 339 | | Some(entry) => { [INFO] [stderr] 340 | | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] 341 | | (*entry).ref_count.fetch_add(1, SeqCst); [INFO] [stderr] 342 | | }, [INFO] [stderr] 343 | | None => (), [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 338 | if let Some(entry) = from_packed_dynamic(self.unsafe_data) { [INFO] [stderr] 339 | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] 340 | (*entry).ref_count.fetch_add(1, SeqCst); [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut atom::StringCacheEntry`) [INFO] [stderr] --> src/atom.rs:340:33 [INFO] [stderr] | [INFO] [stderr] 340 | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/atom.rs:362:13 [INFO] [stderr] | [INFO] [stderr] 362 | / match from_packed_dynamic(self.unsafe_data) { [INFO] [stderr] 363 | | Some(entry) => { [INFO] [stderr] 364 | | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] 365 | | if (*entry).ref_count.fetch_sub(1, SeqCst) == 1 { [INFO] [stderr] ... | [INFO] [stderr] 369 | | _ => (), [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | if let Some(entry) = from_packed_dynamic(self.unsafe_data) { [INFO] [stderr] 363 | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] 364 | if (*entry).ref_count.fetch_sub(1, SeqCst) == 1 { [INFO] [stderr] 365 | drop_slow(self); [INFO] [stderr] 366 | } [INFO] [stderr] 367 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut atom::StringCacheEntry`) [INFO] [stderr] --> src/atom.rs:364:33 [INFO] [stderr] | [INFO] [stderr] 364 | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut atom::StringCacheEntry`) [INFO] [stderr] --> src/atom.rs:388:33 [INFO] [stderr] | [INFO] [stderr] 388 | let entry = entry as *mut StringCacheEntry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/atom.rs:571:37 [INFO] [stderr] | [INFO] [stderr] 571 | let mut data: u64 = (INLINE_TAG as u64) | ((len as u64) << 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(INLINE_TAG)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/atom.rs:571:60 [INFO] [stderr] | [INFO] [stderr] 571 | let mut data: u64 = (INLINE_TAG as u64) | ((len as u64) << 4); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/atom.rs:605:8 [INFO] [stderr] | [INFO] [stderr] 605 | if (DYNAMIC_TAG as u64) == (data & TAG_MASK) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(DYNAMIC_TAG)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/atom.rs:617:1 [INFO] [stderr] | [INFO] [stderr] 617 | / unsafe fn inline_orig_bytes<'a>(data: &'a u64) -> &'a [u8] { [INFO] [stderr] 618 | | match UnpackedAtom::from_packed(*data) { [INFO] [stderr] 619 | | Inline(len, _) => { [INFO] [stderr] 620 | | let src = inline_atom_slice(&data); [INFO] [stderr] ... | [INFO] [stderr] 624 | | } [INFO] [stderr] 625 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `string_cache`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 29 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `string_cache`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9f5bd8aa2f569cece20766345874830cd9b746e09e4642fecbfbb9eb14d3c627"` [INFO] running `"docker" "rm" "-f" "9f5bd8aa2f569cece20766345874830cd9b746e09e4642fecbfbb9eb14d3c627"` [INFO] [stdout] 9f5bd8aa2f569cece20766345874830cd9b746e09e4642fecbfbb9eb14d3c627