[INFO] crate string-wrapper 0.3.0 is already in cache [INFO] extracting crate string-wrapper 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/string-wrapper/0.3.0 [INFO] extracting crate string-wrapper 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string-wrapper/0.3.0 [INFO] validating manifest of string-wrapper-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of string-wrapper-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing string-wrapper-0.3.0 [INFO] finished frobbing string-wrapper-0.3.0 [INFO] frobbed toml for string-wrapper-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/string-wrapper/0.3.0/Cargo.toml [INFO] started frobbing string-wrapper-0.3.0 [INFO] finished frobbing string-wrapper-0.3.0 [INFO] frobbed toml for string-wrapper-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string-wrapper/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting string-wrapper-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/string-wrapper/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5147229c348812e4602cdc268ce03914bb478ed7bca4b9cc58ae749fa4dc61cc [INFO] running `"docker" "start" "-a" "5147229c348812e4602cdc268ce03914bb478ed7bca4b9cc58ae749fa4dc61cc"` [INFO] [stderr] Checking string-wrapper v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> lib.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn from_str(s: &str) -> StringWrapper { [INFO] [stderr] 202 | | let buffer = T::new(); [INFO] [stderr] 203 | | let mut sw = StringWrapper::new(buffer); [INFO] [stderr] 204 | | sw.push_str(s); [INFO] [stderr] 205 | | sw [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str` [INFO] [stderr] --> lib.rs:269:18 [INFO] [stderr] | [INFO] [stderr] 269 | unsafe { transmute::<&mut [u8], &mut str>(&mut self.buffer.as_mut()[..self.len]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(&mut self.buffer.as_mut()[..self.len]).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_bytes_to_str)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> lib.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn from_str(s: &str) -> StringWrapper { [INFO] [stderr] 202 | | let buffer = T::new(); [INFO] [stderr] 203 | | let mut sw = StringWrapper::new(buffer); [INFO] [stderr] 204 | | sw.push_str(s); [INFO] [stderr] 205 | | sw [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str` [INFO] [stderr] --> lib.rs:269:18 [INFO] [stderr] | [INFO] [stderr] 269 | unsafe { transmute::<&mut [u8], &mut str>(&mut self.buffer.as_mut()[..self.len]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(&mut self.buffer.as_mut()[..self.len]).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_bytes_to_str)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> lib.rs:538:5 [INFO] [stderr] | [INFO] [stderr] 538 | / fn it_works() { [INFO] [stderr] 539 | | let mut s = StringWrapper::new([0; 10]); [INFO] [stderr] 540 | | assert_eq!(&*s, ""); [INFO] [stderr] 541 | | assert_eq!(s.len(), 0); [INFO] [stderr] ... | [INFO] [stderr] 602 | | assert_eq!(s.extra_capacity(), 0); [INFO] [stderr] 603 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:593:32 [INFO] [stderr] | [INFO] [stderr] 593 | let buffer: [u8; 10] = s.clone().into_buffer(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib.rs:632:42 [INFO] [stderr] | [INFO] [stderr] 632 | let y: StringWrapper<[u8; 64]> = s.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "5147229c348812e4602cdc268ce03914bb478ed7bca4b9cc58ae749fa4dc61cc"` [INFO] running `"docker" "rm" "-f" "5147229c348812e4602cdc268ce03914bb478ed7bca4b9cc58ae749fa4dc61cc"` [INFO] [stdout] 5147229c348812e4602cdc268ce03914bb478ed7bca4b9cc58ae749fa4dc61cc