[INFO] crate string-lines 0.1.0 is already in cache
[INFO] extracting crate string-lines 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/string-lines/0.1.0
[INFO] extracting crate string-lines 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string-lines/0.1.0
[INFO] validating manifest of string-lines-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of string-lines-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing string-lines-0.1.0
[INFO] finished frobbing string-lines-0.1.0
[INFO] frobbed toml for string-lines-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/string-lines/0.1.0/Cargo.toml
[INFO] started frobbing string-lines-0.1.0
[INFO] finished frobbing string-lines-0.1.0
[INFO] frobbed toml for string-lines-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/string-lines/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting string-lines-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/string-lines/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b44b29c047d04f4c04a28d6e8112d1c64f1da6669c10801989a8256768f424dd
[INFO] running `"docker" "start" "-a" "b44b29c047d04f4c04a28d6e8112d1c64f1da6669c10801989a8256768f424dd"`
[INFO] [stderr]    Compiling file-lock v0.0.17
[INFO] [stderr]     Checking string-lines v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:125:4
[INFO] [stderr]     |
[INFO] [stderr] 125 |             file: file,            
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:126:4
[INFO] [stderr]     |
[INFO] [stderr] 126 |             lock: lock,            
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `lock`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:125:4
[INFO] [stderr]     |
[INFO] [stderr] 125 |             file: file,            
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:126:4
[INFO] [stderr]     |
[INFO] [stderr] 126 |             lock: lock,            
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `lock`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:75:3
[INFO] [stderr]    |
[INFO] [stderr] 75 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:97:3
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return Error::FileError(error);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::FileError(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:103:3
[INFO] [stderr]     |
[INFO] [stderr] 103 |         return Error::LockError(error);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::LockError(error)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:3
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return Error::Utf8Error(error);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::Utf8Error(error)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:137:3
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:149:4
[INFO] [stderr]     |
[INFO] [stderr] 149 |             return Ok(Some(result));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(result))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:151:4
[INFO] [stderr]     |
[INFO] [stderr] 151 |             return Ok(None);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:202:3
[INFO] [stderr]     |
[INFO] [stderr] 202 |         return self.pop_inner(offset,data);            
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pop_inner(offset,data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:210:3
[INFO] [stderr]     |
[INFO] [stderr] 210 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:64:3
[INFO] [stderr]    |
[INFO] [stderr] 64 |           match self {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 65 | |             &Error::FileError(ref error) => {
[INFO] [stderr] 66 | |                 let _ = try!(write!(f,"File error: {}",error));
[INFO] [stderr] 67 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |             },
[INFO] [stderr] 74 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 64 |         match *self {
[INFO] [stderr] 65 |             Error::FileError(ref error) => {
[INFO] [stderr] 66 |                 let _ = try!(write!(f,"File error: {}",error));
[INFO] [stderr] 67 |             },
[INFO] [stderr] 68 |             Error::LockError(ref error) => {
[INFO] [stderr] 69 |                 let _ = try!(write!(f,"Locking error: {:?}",error));
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/lib.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 let _ = try!(write!(f,"File error: {}",error));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/lib.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 let _ = try!(write!(f,"Locking error: {:?}",error));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/lib.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |                 let _ = try!(write!(f,"UTF8 error: {:?}",error));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:81:3
[INFO] [stderr]    |
[INFO] [stderr] 81 |           match self {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 82 | |             &Error::FileError(..) => {
[INFO] [stderr] 83 | |                 "File error"
[INFO] [stderr] 84 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 90 | |             },
[INFO] [stderr] 91 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |         match *self {
[INFO] [stderr] 82 |             Error::FileError(..) => {
[INFO] [stderr] 83 |                 "File error"
[INFO] [stderr] 84 |             },
[INFO] [stderr] 85 |             Error::LockError(..) => {
[INFO] [stderr] 86 |                 "Locking error"
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:133:3
[INFO] [stderr]     |
[INFO] [stderr] 133 |         let _ = try!(self.lock.lock(LockKind::Blocking, AccessMode::Write));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:136:3
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let _ = try!(self.lock.unlock());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:144:3
[INFO] [stderr]     |
[INFO] [stderr] 144 |         let _ = try!(self.file.set_len(offset as u64));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:145:3
[INFO] [stderr]     |
[INFO] [stderr] 145 |         let _ = try!(self.lock.unlock());        
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:146:6
[INFO] [stderr]     |
[INFO] [stderr] 146 |         if data.len() > 0 {            
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:157:3
[INFO] [stderr]     |
[INFO] [stderr] 157 |         let _ = try!(self.lock.lock(LockKind::Blocking, AccessMode::Write));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |                                 char_offset = char_offset + 1;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_offset += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/lib.rs:180:12
[INFO] [stderr]     |
[INFO] [stderr] 180 |                                 if last_line.len() >= 1 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!last_line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:190:6
[INFO] [stderr]     |
[INFO] [stderr] 190 |                     offset = offset - buf.len() as i64;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset -= buf.len() as i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:194:6
[INFO] [stderr]     |
[INFO] [stderr] 194 |                     let _ = try!(self.lock.unlock());
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:207:3
[INFO] [stderr]     |
[INFO] [stderr] 207 |         let _ = try!(self.lock.lock(LockKind::Blocking, AccessMode::Write));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:208:3
[INFO] [stderr]     |
[INFO] [stderr] 208 |         let _ = try!(self.file.set_len(0));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:209:3
[INFO] [stderr]     |
[INFO] [stderr] 209 |         let _ = try!(self.lock.unlock());        
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:75:3
[INFO] [stderr]    |
[INFO] [stderr] 75 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:97:3
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return Error::FileError(error);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::FileError(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:103:3
[INFO] [stderr]     |
[INFO] [stderr] 103 |         return Error::LockError(error);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::LockError(error)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:3
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return Error::Utf8Error(error);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::Utf8Error(error)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:137:3
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:149:4
[INFO] [stderr]     |
[INFO] [stderr] 149 |             return Ok(Some(result));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(result))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:151:4
[INFO] [stderr]     |
[INFO] [stderr] 151 |             return Ok(None);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:202:3
[INFO] [stderr]     |
[INFO] [stderr] 202 |         return self.pop_inner(offset,data);            
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pop_inner(offset,data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:210:3
[INFO] [stderr]     |
[INFO] [stderr] 210 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:64:3
[INFO] [stderr]    |
[INFO] [stderr] 64 |           match self {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 65 | |             &Error::FileError(ref error) => {
[INFO] [stderr] 66 | |                 let _ = try!(write!(f,"File error: {}",error));
[INFO] [stderr] 67 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |             },
[INFO] [stderr] 74 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 64 |         match *self {
[INFO] [stderr] 65 |             Error::FileError(ref error) => {
[INFO] [stderr] 66 |                 let _ = try!(write!(f,"File error: {}",error));
[INFO] [stderr] 67 |             },
[INFO] [stderr] 68 |             Error::LockError(ref error) => {
[INFO] [stderr] 69 |                 let _ = try!(write!(f,"Locking error: {:?}",error));
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/lib.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |                 let _ = try!(write!(f,"File error: {}",error));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/lib.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 let _ = try!(write!(f,"Locking error: {:?}",error));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/lib.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |                 let _ = try!(write!(f,"UTF8 error: {:?}",error));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:81:3
[INFO] [stderr]    |
[INFO] [stderr] 81 |           match self {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 82 | |             &Error::FileError(..) => {
[INFO] [stderr] 83 | |                 "File error"
[INFO] [stderr] 84 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 90 | |             },
[INFO] [stderr] 91 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |         match *self {
[INFO] [stderr] 82 |             Error::FileError(..) => {
[INFO] [stderr] 83 |                 "File error"
[INFO] [stderr] 84 |             },
[INFO] [stderr] 85 |             Error::LockError(..) => {
[INFO] [stderr] 86 |                 "Locking error"
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:133:3
[INFO] [stderr]     |
[INFO] [stderr] 133 |         let _ = try!(self.lock.lock(LockKind::Blocking, AccessMode::Write));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:136:3
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let _ = try!(self.lock.unlock());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:144:3
[INFO] [stderr]     |
[INFO] [stderr] 144 |         let _ = try!(self.file.set_len(offset as u64));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:145:3
[INFO] [stderr]     |
[INFO] [stderr] 145 |         let _ = try!(self.lock.unlock());        
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:146:6
[INFO] [stderr]     |
[INFO] [stderr] 146 |         if data.len() > 0 {            
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:157:3
[INFO] [stderr]     |
[INFO] [stderr] 157 |         let _ = try!(self.lock.lock(LockKind::Blocking, AccessMode::Write));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |                                 char_offset = char_offset + 1;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_offset += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/lib.rs:180:12
[INFO] [stderr]     |
[INFO] [stderr] 180 |                                 if last_line.len() >= 1 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!last_line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:190:6
[INFO] [stderr]     |
[INFO] [stderr] 190 |                     offset = offset - buf.len() as i64;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset -= buf.len() as i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:194:6
[INFO] [stderr]     |
[INFO] [stderr] 194 |                     let _ = try!(self.lock.unlock());
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:207:3
[INFO] [stderr]     |
[INFO] [stderr] 207 |         let _ = try!(self.lock.lock(LockKind::Blocking, AccessMode::Write));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:208:3
[INFO] [stderr]     |
[INFO] [stderr] 208 |         let _ = try!(self.file.set_len(0));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:209:3
[INFO] [stderr]     |
[INFO] [stderr] 209 |         let _ = try!(self.lock.unlock());        
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:227:7
[INFO] [stderr]     |
[INFO] [stderr] 227 |             let _ = lines.push(&line).expect("Unable to push line");
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:230:6
[INFO] [stderr]     |
[INFO] [stderr] 230 |           loop {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 231 | |             match items.pop() {
[INFO] [stderr] 232 | |                 Some(item_line) => {
[INFO] [stderr] 233 | |                     let line = lines.pop().expect("Unable to pop line");                    
[INFO] [stderr] ...   |
[INFO] [stderr] 239 | |             }
[INFO] [stderr] 240 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(item_line) = items.pop() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/lib.rs:258:7
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let _ = lines.push(&line).expect("Unable to push line");
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel
[INFO] [stderr]  --> benches/string_lines.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![feature(test)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0554`.
[INFO] [stderr] error: Could not compile `string-lines`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "b44b29c047d04f4c04a28d6e8112d1c64f1da6669c10801989a8256768f424dd"`
[INFO] running `"docker" "rm" "-f" "b44b29c047d04f4c04a28d6e8112d1c64f1da6669c10801989a8256768f424dd"`
[INFO] [stdout] b44b29c047d04f4c04a28d6e8112d1c64f1da6669c10801989a8256768f424dd